1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

benchmark: check for and fix multiple end()

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/31624
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
Brian White 2020-02-03 16:18:29 -05:00
parent 93c4c1a273
commit b862a0c6d6
No known key found for this signature in database
GPG Key ID: 606D7358F94DA209
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
benchmark/common.js
View File

@ -33,6 +33,7 @@ function Benchmark(fn, configs, options) {
this._time = [0, 0];
// Used to make sure a benchmark only start a timer once
this._started = false;
this._ended = false;
// this._run will use fork() to create a new process for each configuration
// combination.
@ -197,6 +198,9 @@ Benchmark.prototype.end = function(operations) {
if (!this._started) {
throw new Error('called end without start');
}
if (this._ended) {
throw new Error('called end multiple times');
}
if (typeof operations !== 'number') {
throw new Error('called end() without specifying operation count');
}
@ -210,6 +214,7 @@ Benchmark.prototype.end = function(operations) {
elapsed[1] = 1;
}
this._ended = true;
const time = elapsed[0] + elapsed[1] / 1e9;
const rate = operations / time;
this.report(rate, elapsed);

4
benchmark/streams/writable-manywrites.js
View File

@ -35,8 +35,10 @@ function main({ n, sync, writev, callback }) {
let k = 0;
function run() {
while (k++ < n && s.write(b, cb));
if (k >= n)
if (k >= n) {
bench.end(n);
s.removeListener('drain', run);
}
}
s.on('drain', run);
run();