1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: simplify test-http2-client-promisify-connect-error

Browse Source 
There is no need to try to create a TCP connection that fails due to a
missing listening server. Also, the port used for the connection might
be used by another process when the connection is made.

PR-URL: https://github.com/nodejs/node/pull/57144
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This commit is contained in:
Luigi Pinca 2025-02-22 10:25:11 +01:00 committed by GitHub
parent 90ab559f4d
commit ba8fbf34f4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
test/parallel/test-http2-client-promisify-connect-error.js
View File

@ -8,14 +8,15 @@ const assert = require('assert');
const http2 = require('http2'); const http2 = require('http2');
const util = require('util'); const util = require('util');
const server = http2.createServer(); const connect = util.promisify(http2.connect);
server.listen(0, common.mustCall(() => { const error = new Error('Unable to resolve hostname');
const port = server.address().port;
server.close(common.mustCall(() => { function lookup(hostname, options, callback) {
const connect = util.promisify(http2.connect); callback(error);
assert.rejects(connect(`http://localhost:${port}`), { }
code: 'ECONNREFUSED'
}).then(common.mustCall()); assert.rejects(
})); connect('http://hostname', { lookup }),
})); error,
).then(common.mustCall());