1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fail when child dies in fork-net

Browse Source 
Previously when the child dies with errors in this test, the parent
will just hang and timeout, the errors in the child would be
swallowed. This makes it fail so at least there is more information
about why this test fails.

Also removes the unnecessary child.kill() call.

PR-URL: https://github.com/nodejs/node/pull/11684
Ref: https://github.com/nodejs/node/pull/11667
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Joyee Cheung 2017-03-04 18:54:48 +08:00 committed by James M Snell
parent 39d9afe279
commit c9bc3e50ed
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/parallel/test-child-process-fork-net.js
View File

@ -20,7 +20,7 @@
// USE OR OTHER DEALINGS IN THE SOFTWARE.
'use strict';
require('../common');
const common = require('../common');
const assert = require('assert');
const fork = require('child_process').fork;
const net = require('net');
@ -81,9 +81,10 @@ if (process.argv[2] === 'child') {
const child = fork(process.argv[1], ['child']);
child.on('exit', function() {
console.log('CHILD: died');
});
child.on('exit', common.mustCall(function(code, signal) {
const message = `CHILD: died with ${code}, ${signal}`;
assert.strictEqual(code, 0, message);
}));
// send net.Server to child and test by connecting
const testServer = function(callback) {
@ -192,7 +193,6 @@ if (process.argv[2] === 'child') {
testSocket(function() {
socketSuccess = true;
child.kill();
});
});