1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: swap expected and actual arguments in assert.strictEqual()

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/23542
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
Erin Bush 2018-10-12 10:38:06 -07:00 committed by Ruben Bridgewater
parent 810c0d99d1
commit d83d3ed2bc
No known key found for this signature in database
GPG Key ID: F07496B3EB3C1762
1 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
test/pummel/test-net-pingpong-delay.js
View File

@ -35,11 +35,11 @@ function pingPongTest(port, host, on_complete) {
socket.on('data', function(data) {
console.log(data);
assert.strictEqual('PING', data);
assert.strictEqual('open', socket.readyState);
assert.strictEqual(true, count <= N);
assert.strictEqual(data, 'PING');
assert.strictEqual(socket.readyState, 'open');
assert.strictEqual(count <= N, true);
setTimeout(function() {
assert.strictEqual('open', socket.readyState);
assert.strictEqual(socket.readyState, 'open');
socket.write('PONG');
}, DELAY);
});
@ -51,14 +51,14 @@ function pingPongTest(port, host, on_complete) {
socket.on('end', function() {
console.log('server-side socket EOF');
assert.strictEqual('writeOnly', socket.readyState);
assert.strictEqual(socket.readyState, 'writeOnly');
socket.end();
});
socket.on('close', function(had_error) {
console.log('server-side socket.end');
assert.strictEqual(false, had_error);
assert.strictEqual('closed', socket.readyState);
assert.strictEqual(had_error, false);
assert.strictEqual(socket.readyState, 'closed');
socket.server.close();
});
});
@ -69,17 +69,17 @@ function pingPongTest(port, host, on_complete) {
client.setEncoding('utf8');
client.on('connect', function() {
assert.strictEqual('open', client.readyState);
assert.strictEqual(client.readyState, 'open');
client.write('PING');
});
client.on('data', function(data) {
console.log(data);
assert.strictEqual('PONG', data);
assert.strictEqual('open', client.readyState);
assert.strictEqual(data, 'PONG');
assert.strictEqual(client.readyState, 'open');
setTimeout(function() {
assert.strictEqual('open', client.readyState);
assert.strictEqual(client.readyState, 'open');
if (count++ < N) {
client.write('PING');
} else {
@ -97,7 +97,7 @@ function pingPongTest(port, host, on_complete) {
client.on('close', common.mustCall(function() {
console.log('client.end');
assert.strictEqual(N + 1, count);
assert.strictEqual(count, N + 1);
assert.ok(client_ended);
if (on_complete) on_complete();
}));