1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix fs test-fs-utimes strictEqual arg order

Browse Source 
`actual` is the first argument, `expected` the second, but the test
flipped them around and was producing confusing assertion messages
as a result.

Refs: https://github.com/nodejs/node/pull/32408#issuecomment-602170887

PR-URL: https://github.com/nodejs/node/pull/32420
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
Ben Noordhuis 2020-03-22 10:42:39 +01:00 committed by Anna Henningsen
parent 88b4e86fd7
commit e20b4f918a
No known key found for this signature in database
GPG Key ID: A94130F0BFC8EBE9
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/parallel/test-fs-utimes.js
View File

@ -150,7 +150,7 @@ if (!process.arch.includes('arm') &&
const Y2K38_mtime = 2 ** 31; const Y2K38_mtime = 2 ** 31;
fs.utimesSync(path, Y2K38_mtime, Y2K38_mtime); fs.utimesSync(path, Y2K38_mtime, Y2K38_mtime);
const Y2K38_stats = fs.statSync(path); const Y2K38_stats = fs.statSync(path);
assert.strictEqual(Y2K38_mtime, Y2K38_stats.mtime.getTime() / 1000); assert.strictEqual(Y2K38_stats.mtime.getTime() / 1000, Y2K38_mtime);
} }
if (common.isWindows) { if (common.isWindows) {
@ -158,7 +158,7 @@ if (common.isWindows) {
const truncate_mtime = 1713037251360; const truncate_mtime = 1713037251360;
fs.utimesSync(path, truncate_mtime / 1000, truncate_mtime / 1000); fs.utimesSync(path, truncate_mtime / 1000, truncate_mtime / 1000);
const truncate_stats = fs.statSync(path); const truncate_stats = fs.statSync(path);
assert.strictEqual(truncate_mtime, truncate_stats.mtime.getTime()); assert.strictEqual(truncate_stats.mtime.getTime(), truncate_mtime);
// test Y2K38 for windows // test Y2K38 for windows
// This value if treaded as a `signed long` gets converted to -2135622133469. // This value if treaded as a `signed long` gets converted to -2135622133469.
@ -168,7 +168,7 @@ if (common.isWindows) {
const overflow_mtime = 2159345162531; const overflow_mtime = 2159345162531;
fs.utimesSync(path, overflow_mtime / 1000, overflow_mtime / 1000); fs.utimesSync(path, overflow_mtime / 1000, overflow_mtime / 1000);
const overflow_stats = fs.statSync(path); const overflow_stats = fs.statSync(path);
assert.strictEqual(overflow_mtime, overflow_stats.mtime.getTime()); assert.strictEqual(overflow_stats.mtime.getTime(), overflow_mtime);
} }
const expectTypeError = { const expectTypeError = {