1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

url: remove javascript URL special case

Browse Source 
Fixes: https://github.com/nodejs/node/issues/11485
PR-URL: https://github.com/nodejs/node/pull/12331
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Daijiro Wachi 2017-04-12 20:43:22 +02:00
parent 2ced07ccaf
commit eb0492d51e
2 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/internal/url.js
View File

@ -556,8 +556,6 @@ Object.defineProperties(URL.prototype, {
const ctx = this[context]; const ctx = this[context];
// toUSVString is not needed. // toUSVString is not needed.
hash = `${hash}`; hash = `${hash}`;
if (this.protocol === 'javascript:')
return;
if (!hash) { if (!hash) {
ctx.fragment = null; ctx.fragment = null;
ctx.flags &= ~binding.URL_FLAGS_HAS_FRAGMENT; ctx.flags &= ~binding.URL_FLAGS_HAS_FRAGMENT;

16
test/fixtures/url-setter-tests.js vendored
View File

@ -1800,13 +1800,13 @@ module.exports =
"hash": "#%c3%89t%C3%A9" "hash": "#%c3%89t%C3%A9"
} }
}, },
// { {
// "href": "javascript:alert(1)", "href": "javascript:alert(1)",
// "new_value": "castle", "new_value": "castle",
// "expected": { "expected": {
// "href": "javascript:alert(1)#castle", "href": "javascript:alert(1)#castle",
// "hash": "#castle" "hash": "#castle"
// } }
// } }
] ]
} }