1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

deps: V8: cherry-pick f2d92ec

Browse Source 
Original commit message:

    [base] Add missing include of <type_traits>

    The missing include causes compilation failures for node.js, see
    https://github.com/nodejs/node/pull/30020.

    It's not great to have includes in a file called "macros.h", but we
    define several functions there that make use of type traits. Fixing
    that is a separate project.

    R=mlippautz@chromium.org

    Change-Id: Idb067679e597521230f94eb8c99f1347ed3808cb
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1868622
    Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#64386}

Refs: f2d92ec3c5

PR-URL: https://github.com/nodejs/node/pull/30020
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This commit is contained in:
Michaël Zasso 2019-10-18 17:56:48 +02:00
parent d776cebbfb
commit f15559a891
No known key found for this signature in database
GPG Key ID: 770F7A9A5AE15600
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
common.gypi
View File

@ -39,7 +39,7 @@
# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.8',
'v8_embedder_string': '-node.9',
##### V8 defaults for Node.js #####

1
deps/v8/src/base/macros.h vendored
View File

@ -6,6 +6,7 @@
#define V8_BASE_MACROS_H_
#include <limits>
#include <type_traits>
#include "src/base/compiler-specific.h"
#include "src/base/logging.h"