1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

stream: remove always-false condition check

Browse Source 
Remove comparison to null of variable guaranteed to be a boolean.

PR-URL: https://github.com/nodejs/node/pull/41488
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
This commit is contained in:
Rich Trott 2022-01-14 16:07:46 -08:00 committed by GitHub
parent 2ea2621ace
commit f7be6ab042
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/internal/streams/utils.js
View File

@ -119,14 +119,14 @@ function isReadableFinished(stream, strict) {
function isReadable(stream) { function isReadable(stream) {
if (stream && stream[kIsReadable] != null) return stream[kIsReadable]; if (stream && stream[kIsReadable] != null) return stream[kIsReadable];
const r = isReadableNodeStream(stream); const r = isReadableNodeStream(stream);
if (r === null || typeof stream?.readable !== 'boolean') return null; if (typeof stream?.readable !== 'boolean') return null;
if (isDestroyed(stream)) return false; if (isDestroyed(stream)) return false;
return r && stream.readable && !isReadableFinished(stream); return r && stream.readable && !isReadableFinished(stream);
} }
function isWritable(stream) { function isWritable(stream) {
const r = isWritableNodeStream(stream); const r = isWritableNodeStream(stream);
if (r === null || typeof stream?.writable !== 'boolean') return null; if (typeof stream?.writable !== 'boolean') return null;
if (isDestroyed(stream)) return false; if (isDestroyed(stream)) return false;
return r && stream.writable && !isWritableEnded(stream); return r && stream.writable && !isWritableEnded(stream);
} }