1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

doc,lib,test: rename node-report to report

Browse Source 
This commit completes the renaming of node-report to report
in order to better differentiate core's reporting from the
node-report npm module.

PR-URL: https://github.com/nodejs/node/pull/26371
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
cjihrig 2019-02-28 21:03:31 -05:00
parent fe292fac55
commit f9cd5e3094
No known key found for this signature in database
GPG Key ID: 7434390BDBE9B9C5
4 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
doc/api/report.md
View File

@ -32,7 +32,7 @@ is provided below for reference.
"/home/nodeuser/project/node/out/Release/node", "/home/nodeuser/project/node/out/Release/node",
"--experimental-report", "--experimental-report",
"--diagnostic-report-uncaught-exception", "--diagnostic-report-uncaught-exception",
"/home/nodeuser/project/node/test/node-report/test-exception.js", "/home/nodeuser/project/node/test/report/test-exception.js",
"child" "child"
], ],
"nodejsVersion": "v12.0.0-pre", "nodejsVersion": "v12.0.0-pre",
@ -66,8 +66,8 @@ is provided below for reference.
"javascriptStack": { "javascriptStack": {
"message": "Error: *** test-exception.js: throwing uncaught Error", "message": "Error: *** test-exception.js: throwing uncaught Error",
"stack": [ "stack": [
"at myException (/home/nodeuser/project/node/test/node-report/test-exception.js:9:11)", "at myException (/home/nodeuser/project/node/test/report/test-exception.js:9:11)",
"at Object.<anonymous> (/home/nodeuser/project/node/test/node-report/test-exception.js:12:3)", "at Object.<anonymous> (/home/nodeuser/project/node/test/report/test-exception.js:12:3)",
"at Module._compile (internal/modules/cjs/loader.js:718:30)", "at Module._compile (internal/modules/cjs/loader.js:718:30)",
"at Object.Module._extensions..js (internal/modules/cjs/loader.js:729:10)", "at Object.Module._extensions..js (internal/modules/cjs/loader.js:729:10)",
"at Module.load (internal/modules/cjs/loader.js:617:32)", "at Module.load (internal/modules/cjs/loader.js:617:32)",

2
lib/internal/bootstrap/pre_execution.js
View File

@ -11,7 +11,7 @@ function prepareMainThreadExecution() {
// Only main thread receives signals. // Only main thread receives signals.
setupSignalHandlers(); setupSignalHandlers();
// Process initial configurations of node-report, if any. // Process initial diagnostic reporting configuration, if present.
initializeReport(); initializeReport();
initializeReportSignalHandlers(); // Main-thread-only. initializeReportSignalHandlers(); // Main-thread-only.

4
lib/internal/process/execution.js
View File

@ -102,7 +102,7 @@ function createFatalException() {
// call that threw and was never cleared. So clear it now. // call that threw and was never cleared. So clear it now.
clearDefaultTriggerAsyncId(); clearDefaultTriggerAsyncId();
// If node-report is enabled, call into its handler to see // If diagnostic reporting is enabled, call into its handler to see
// whether it is interested in handling the situation. // whether it is interested in handling the situation.
// Ignore if the error is scoped inside a domain. // Ignore if the error is scoped inside a domain.
// use == in the checks as we want to allow for null and undefined // use == in the checks as we want to allow for null and undefined
@ -119,7 +119,7 @@ function createFatalException() {
report.onUnCaughtException(er ? er.stack : undefined); report.onUnCaughtException(er ? er.stack : undefined);
} }
} }
} catch {} // NOOP, node_report unavailable. } catch {} // Ignore the exception. Diagnostic reporting is unavailable.
} }
if (exceptionHandlerState.captureFn !== null) { if (exceptionHandlerState.captureFn !== null) {

2
test/common/index.js
View File

@ -624,7 +624,7 @@ function skipIfInspectorDisabled() {
function skipIfReportDisabled() { function skipIfReportDisabled() {
if (!process.config.variables.node_report) { if (!process.config.variables.node_report) {
skip('Node Report is disabled'); skip('Diagnostic reporting is disabled');
} }
} }