1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

deps: V8: cherry-pick 9a607043cb31

Browse Source 
Original commit message:

    [compiler] Gracefully handle an unsupported situation

    ... by skipping the optimization instead of CHECK-failing.

    Bug: v8:12188
    Change-Id: I6709bf1c55506f3d12886efbfbb9934788cd02ce
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148132
    Auto-Submit: Georg Neis <neis@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#76741}

Refs: 9a607043cb

PR-URL: https://github.com/nodejs/node/pull/40046
Fixes: https://github.com/nodejs/node/issues/40030
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
This commit is contained in:
Jiawen Geng 2021-09-09 06:38:19 +00:00 committed by Michaël Zasso
parent a909f6942b
commit fc056a301e
No known key found for this signature in database
GPG Key ID: 770F7A9A5AE15600
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
common.gypi
View File

@ -36,7 +36,7 @@
# Reset this number to 0 on major V8 upgrades. # Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8. # Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.10', 'v8_embedder_string': '-node.11',
##### V8 defaults for Node.js ##### ##### V8 defaults for Node.js #####

4
deps/v8/src/objects/lookup.cc vendored
View File

@ -1527,8 +1527,8 @@ base::Optional<PropertyCell> ConcurrentLookupIterator::TryGetPropertyCell(
DisallowGarbageCollection no_gc; DisallowGarbageCollection no_gc;
Map holder_map = holder->map(); Map holder_map = holder->map();
CHECK(!holder_map.is_access_check_needed()); if (holder_map.is_access_check_needed()) return {};
CHECK(!holder_map.has_named_interceptor()); if (holder_map.has_named_interceptor()) return {};
GlobalDictionary dict = holder->global_dictionary(kAcquireLoad); GlobalDictionary dict = holder->global_dictionary(kAcquireLoad);
base::Optional<PropertyCell> cell = base::Optional<PropertyCell> cell =