1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

lib: fix consistency of methods that emit warnings

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/41249
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
This commit is contained in:
Yoshiki Kurihara 2022-01-22 08:53:53 +09:00 committed by GitHub
parent 806c7c13f3
commit feafea1154
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
lib/internal/dns/utils.js
View File

@ -178,18 +178,16 @@ function validateHints(hints) {
} }
let invalidHostnameWarningEmitted = false; let invalidHostnameWarningEmitted = false;
function emitInvalidHostnameWarning(hostname) { function emitInvalidHostnameWarning(hostname) {
if (invalidHostnameWarningEmitted) { if (!invalidHostnameWarningEmitted) {
return; process.emitWarning(
`The provided hostname "${hostname}" is not a valid ` +
'hostname, and is supported in the dns module solely for compatibility.',
'DeprecationWarning',
'DEP0118'
);
invalidHostnameWarningEmitted = true;
} }
invalidHostnameWarningEmitted = true;
process.emitWarning(
`The provided hostname "${hostname}" is not a valid ` +
'hostname, and is supported in the dns module solely for compatibility.',
'DeprecationWarning',
'DEP0118'
);
} }
let typeCoercionWarningEmitted = false; let typeCoercionWarningEmitted = false;