1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
44,410 Commits 59 Branches 887 Tags
Commit Graph

3 Commits

Author SHA1 Message Date
Ouyang Yadong
acd2a3210d
net: remove redundant connecting assignment 
PR-URL: https://github.com/nodejs/node/pull/43710
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
 2022-07-09 17:10:16 +01:00
Luigi Pinca
66cf4b5d6e test: refactor net-connect-handle-econnrefused 
- Remove unneeded server
- Use `common.PORT`

PR-URL: https://github.com/nodejs/node/pull/27014
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2019-04-27 08:21:51 +02:00
Luigi Pinca
f7afed17b6 test: move test-net-connect-handle-econnrefused 
The port used in the test could be taken by another process before
the callback of `server.close()` is called. Move it to sequential.

PR-URL: https://github.com/nodejs/node/pull/27014
Fixes: https://github.com/nodejs/node/issues/26907
Refs: https://github.com/nodejs/node/pull/18257#discussion_r162717096
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2019-04-27 08:20:21 +02:00