nodejs

Author SHA1 Message Date

Author	SHA1	Message	Date
Antoine du Hamel	c6dabe3083	doc: add lint rule to enforce trailing commas PR-URL: https://github.com/nodejs/node/pull/45471 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>	2022-11-17 13:19:12 +00:00
Antoine du Hamel	528fef2285	doc: improve fragment (`:target`) anchors behavior on HTML version This commit aims to improve the UX when navigating the docs using links to subsections. Previously the browser would scroll down to the section body, skipping the section heading. Using `scroll-margin-top` CSS property, we can fix this behavior (at least on some browsers). Links to other versions are now updated with the current targeted hash to improve the UX when navigating from docs of one release line to another. I've also removed syntax not parsable by older browsers (arrow functions and array destructuring) since the diff is pretty small and should improve UX on those browsers. PR-URL: https://github.com/nodejs/node/pull/42739 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>	2022-04-17 15:51:42 +01:00
Paolo Insogna	0f79a27462	doc: make header smaller and dropdown click-driven when JS is on PR-URL: https://github.com/nodejs/node/pull/42165 Fixes: https://github.com/nodejs/node/issues/42286 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>	2022-03-22 21:31:56 +00:00

Antoine du Hamel

c6dabe3083

doc: add lint rule to enforce trailing commas

PR-URL: https://github.com/nodejs/node/pull/45471
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

2022-11-17 13:19:12 +00:00

Antoine du Hamel

528fef2285

doc: improve fragment (:target) anchors behavior on HTML version

This commit aims to improve the UX when navigating the docs using links
to subsections. Previously the browser would scroll down to the section
body, skipping the section heading. Using `scroll-margin-top` CSS
property, we can fix this behavior (at least on some browsers).

Links to other versions are now updated with the current targeted hash
to improve the UX when navigating from docs of one release line to
another.

I've also removed syntax not parsable by older browsers (arrow functions
and array destructuring) since the diff is pretty small and should
improve UX on those browsers.

PR-URL: https://github.com/nodejs/node/pull/42739
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

2022-04-17 15:51:42 +01:00

Paolo Insogna

0f79a27462

doc: make header smaller and dropdown click-driven when JS is on

PR-URL: https://github.com/nodejs/node/pull/42165
Fixes: https://github.com/nodejs/node/issues/42286
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

2022-03-22 21:31:56 +00:00

3 Commits