npm CLI robot 063afa85fe
deps: upgrade npm to 10.8.1
PR-URL: https://github.com/nodejs/node/pull/53207
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
2024-05-30 11:21:05 +00:00

311 lines
9.7 KiB
JavaScript

const fs = require('node:fs')
const path = require('node:path')
const t = require('tap')
const {
loadNpmWithRegistry: loadMockNpm,
workspaceMock,
} = require('../../fixtures/mock-npm')
// t.cleanSnapshot = str => str.replace(/ in [0-9ms]+/g, ' in {TIME}')
const packageJson = {
name: 'test-package',
version: '1.0.0',
dependencies: {
abbrev: '^1.0.0',
},
}
const packageLock = {
name: 'test-package',
version: '1.0.0',
lockfileVersion: 2,
requires: true,
packages: {
'': {
name: 'test-package',
version: '1.0.0',
dependencies: {
abbrev: '^1.0.0',
},
},
'node_modules/abbrev': {
version: '1.0.0',
resolved: 'https://registry.npmjs.org/abbrev/-/abbrev-1.0.0.tgz',
// integrity changes w/ each test cause the path is different?
},
},
dependencies: {
abbrev: {
version: '1.0.0',
resolved: 'https://registry.npmjs.org/abbrev/-/abbrev-1.0.0.tgz',
// integrity changes w/ each test cause the path is different?
},
},
}
const abbrev = {
'package.json': '{"name": "abbrev", "version": "1.0.0"}',
test: 'test file',
}
t.test('reifies, but doesn\'t remove node_modules because --dry-run', async t => {
const { npm, joinedOutput } = await loadMockNpm(t, {
config: {
'dry-run': true,
},
prefixDir: {
abbrev: abbrev,
'package.json': JSON.stringify(packageJson),
'package-lock.json': JSON.stringify(packageLock),
node_modules: { test: 'test file that will not be removed' },
},
})
await npm.exec('ci', [])
t.match(joinedOutput(), 'added 1 package, and removed 1 package in')
const nmTest = path.join(npm.prefix, 'node_modules', 'test')
t.equal(fs.existsSync(nmTest), true, 'existing node_modules is not removed')
const nmAbbrev = path.join(npm.prefix, 'node_modules', 'abbrev')
t.equal(fs.existsSync(nmAbbrev), false, 'does not install abbrev')
})
t.test('reifies, audits, removes node_modules', async t => {
const { npm, joinedOutput, registry } = await loadMockNpm(t, {
prefixDir: {
abbrev: abbrev,
'package.json': JSON.stringify(packageJson),
'package-lock.json': JSON.stringify(packageLock),
node_modules: { test: 'test file that will be removed' },
},
})
const manifest = registry.manifest({ name: 'abbrev' })
await registry.tarball({
manifest: manifest.versions['1.0.0'],
tarball: path.join(npm.prefix, 'abbrev'),
})
registry.nock.post('/-/npm/v1/security/advisories/bulk').reply(200, {})
await npm.exec('ci', [])
t.match(joinedOutput(), 'added 1 package, and audited 2 packages in')
const nmTest = path.join(npm.prefix, 'node_modules', 'test')
t.equal(fs.existsSync(nmTest), false, 'existing node_modules is removed')
const nmAbbrev = path.join(npm.prefix, 'node_modules', 'abbrev')
t.equal(fs.existsSync(nmAbbrev), true, 'installs abbrev')
})
t.test('reifies, audits, removes node_modules on repeat run', async t => {
const { npm, joinedOutput, registry } = await loadMockNpm(t, {
prefixDir: {
abbrev: abbrev,
'package.json': JSON.stringify(packageJson),
'package-lock.json': JSON.stringify(packageLock),
node_modules: { test: 'test file that will be removed' },
},
})
const manifest = registry.manifest({ name: 'abbrev' })
await registry.tarball({
times: 2,
manifest: manifest.versions['1.0.0'],
tarball: path.join(npm.prefix, 'abbrev'),
})
await registry.tarball({
manifest: manifest.versions['1.0.0'],
tarball: path.join(npm.prefix, 'abbrev'),
})
registry.nock.post('/-/npm/v1/security/advisories/bulk').reply(200, {})
registry.nock.post('/-/npm/v1/security/advisories/bulk').reply(200, {})
await npm.exec('ci', [])
await npm.exec('ci', [])
t.match(joinedOutput(), 'added 1 package, and audited 2 packages in')
const nmTest = path.join(npm.prefix, 'node_modules', 'test')
t.equal(fs.existsSync(nmTest), false, 'existing node_modules is removed')
const nmAbbrev = path.join(npm.prefix, 'node_modules', 'abbrev')
t.equal(fs.existsSync(nmAbbrev), true, 'installs abbrev')
})
t.test('--no-audit and --ignore-scripts', async t => {
const { npm, joinedOutput, registry } = await loadMockNpm(t, {
config: {
'ignore-scripts': true,
audit: false,
},
prefixDir: {
abbrev: {
'package.json': '{"name": "abbrev", "version": "1.0.0"}',
test: 'test-file',
},
'package.json': JSON.stringify({
...packageJson,
// Would make install fail
scripts: { install: 'echo "SHOULD NOT RUN" && exit 1' },
}),
'package-lock.json': JSON.stringify(packageLock),
},
})
const manifest = registry.manifest({ name: 'abbrev' })
await registry.tarball({
manifest: manifest.versions['1.0.0'],
tarball: path.join(npm.prefix, 'abbrev'),
})
await npm.exec('ci', [])
t.match(joinedOutput(), 'added 1 package in', 'would fail if install script ran')
})
t.test('lifecycle scripts', async t => {
const scripts = []
const { npm, registry } = await loadMockNpm(t, {
prefixDir: {
abbrev: abbrev,
'package.json': JSON.stringify(packageJson),
'package-lock.json': JSON.stringify(packageLock),
},
mocks: {
'@npmcli/run-script': (opts) => {
scripts.push(opts.event)
},
},
})
const manifest = registry.manifest({ name: 'abbrev' })
await registry.tarball({
manifest: manifest.versions['1.0.0'],
tarball: path.join(npm.prefix, 'abbrev'),
})
registry.nock.post('/-/npm/v1/security/advisories/bulk').reply(200, {})
await npm.exec('ci', [])
t.same(scripts, [
'preinstall',
'install',
'postinstall',
'prepublish',
'preprepare',
'prepare',
'postprepare',
], 'runs appropriate scripts, in order')
})
t.test('should throw if package-lock.json or npm-shrinkwrap missing', async t => {
const { npm } = await loadMockNpm(t, {
prefixDir: {
'package.json': JSON.stringify(packageJson),
node_modules: {
'test-file': 'should not be removed',
},
},
})
await t.rejects(npm.exec('ci', []), { code: 'EUSAGE', message: /package-lock.json/ })
const nmTestFile = path.join(npm.prefix, 'node_modules', 'test-file')
t.equal(fs.existsSync(nmTestFile), true, 'does not remove node_modules')
})
t.test('should throw ECIGLOBAL', async t => {
const { npm } = await loadMockNpm(t, {
config: { global: true },
})
await t.rejects(npm.exec('ci', []), { code: 'ECIGLOBAL' })
})
t.test('should throw error when ideal inventory mismatches virtual', async t => {
const { npm, registry } = await loadMockNpm(t, {
prefixDir: {
abbrev: abbrev,
'package.json': JSON.stringify({
...packageJson,
dependencies: { notabbrev: '^1.0.0' },
}),
'package-lock.json': JSON.stringify(packageLock),
node_modules: {
'test-file': 'should not be removed',
},
},
})
const manifest = registry.manifest({ name: 'notabbrev' })
await registry.package({ manifest })
await t.rejects(
npm.exec('ci', []),
{ code: 'EUSAGE', message: /in sync/ }
)
const nmTestFile = path.join(npm.prefix, 'node_modules', 'test-file')
t.equal(fs.existsSync(nmTestFile), true, 'does not remove node_modules')
})
t.test('should remove dirty node_modules with unhoisted workspace module', async t => {
const { npm, registry, assert } = await loadMockNpm(t, {
prefixDir: workspaceMock(t, {
clean: false,
workspaces: {
'workspace-a': {
'abbrev@1.1.0': { },
},
'workspace-b': {
'abbrev@1.1.1': { hoist: false },
},
},
}),
})
await registry.setup({
'abbrev@1.1.0': path.join(npm.prefix, 'tarballs/abbrev@1.1.0'),
'abbrev@1.1.1': path.join(npm.prefix, 'tarballs/abbrev@1.1.1'),
})
registry.nock.post('/-/npm/v1/security/advisories/bulk').reply(200, {})
assert.packageDirty('node_modules/abbrev@1.1.0')
assert.packageDirty('workspace-b/node_modules/abbrev@1.1.1')
await npm.exec('ci', [])
assert.packageInstalled('node_modules/abbrev@1.1.0')
assert.packageInstalled('workspace-b/node_modules/abbrev@1.1.1')
})
t.test('should remove dirty node_modules with hoisted workspace modules', async t => {
const { npm, registry, assert } = await loadMockNpm(t, {
prefixDir: workspaceMock(t, {
clean: false,
workspaces: {
'workspace-a': {
'abbrev@1.1.0': { },
},
'workspace-b': {
'lodash@1.1.1': { },
},
},
}),
})
await registry.setup({
'abbrev@1.1.0': path.join(npm.prefix, 'tarballs/abbrev@1.1.0'),
'lodash@1.1.1': path.join(npm.prefix, 'tarballs/lodash@1.1.1'),
})
registry.nock.post('/-/npm/v1/security/advisories/bulk').reply(200, {})
assert.packageDirty('node_modules/abbrev@1.1.0')
assert.packageDirty('node_modules/lodash@1.1.1')
await npm.exec('ci', [])
assert.packageInstalled('node_modules/abbrev@1.1.0')
assert.packageInstalled('node_modules/lodash@1.1.1')
})
/** this behaves the same way as install but will remove all workspace node_modules */
t.test('should use --workspace flag', async t => {
t.saveFixture = true
const { npm, registry, assert } = await loadMockNpm(t, {
config: {
workspace: 'workspace-b',
},
prefixDir: workspaceMock(t, {
clean: false,
workspaces: {
'workspace-a': {
'abbrev@1.1.0': { },
},
'workspace-b': {
'lodash@1.1.1': { },
},
},
}),
})
await registry.setup({
'lodash@1.1.1': path.join(npm.prefix, 'tarballs/lodash@1.1.1'),
})
registry.nock.post('/-/npm/v1/security/advisories/bulk').reply(200, {})
assert.packageDirty('node_modules/abbrev@1.1.0')
assert.packageDirty('node_modules/lodash@1.1.1')
await npm.exec('ci', [])
assert.packageMissing('node_modules/abbrev@1.1.0')
assert.packageInstalled('node_modules/lodash@1.1.1')
})