Fixes: https://github.com/nodejs/node/issues/47200 Co-authored-by: Luigi Pinca <luigipinca@gmail.com> PR-URL: https://github.com/nodejs/node/pull/55959 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Jason Zhang <xzha4350@gmail.com>
76 lines
2.1 KiB
JavaScript
76 lines
2.1 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
|
|
const net = require('net');
|
|
const http = require('http');
|
|
|
|
const server = http.createServer(function(request, response) {
|
|
// When the connection header is removed, for HTTP/1.1 the connection should still persist.
|
|
// For HTTP/1.0, the connection should be closed after the response automatically.
|
|
response.removeHeader('connection');
|
|
|
|
if (request.httpVersion === '1.0') {
|
|
const socket = request.socket;
|
|
response.on('finish', common.mustCall(function() {
|
|
assert.ok(socket.writableEnded);
|
|
}));
|
|
}
|
|
|
|
response.end('beep boop\n');
|
|
});
|
|
|
|
const agent = new http.Agent({ keepAlive: true });
|
|
|
|
function makeHttp11Request(cb) {
|
|
http.get({
|
|
port: server.address().port,
|
|
agent
|
|
}, function(res) {
|
|
const socket = res.socket;
|
|
|
|
assert.strictEqual(res.statusCode, 200);
|
|
assert.strictEqual(res.headers.connection, undefined);
|
|
|
|
res.setEncoding('ascii');
|
|
let response = '';
|
|
res.on('data', function(chunk) {
|
|
response += chunk;
|
|
});
|
|
res.on('end', function() {
|
|
assert.strictEqual(response, 'beep boop\n');
|
|
|
|
// Wait till next tick to ensure that the socket is returned to the agent before
|
|
// we continue to the next request
|
|
process.nextTick(function() {
|
|
cb(socket);
|
|
});
|
|
});
|
|
});
|
|
}
|
|
|
|
function makeHttp10Request(cb) {
|
|
// We have to manually make HTTP/1.0 requests since Node does not allow sending them:
|
|
const socket = net.connect({ port: server.address().port }, function() {
|
|
socket.write('GET / HTTP/1.0\r\n' +
|
|
'Host: localhost:' + server.address().port + '\r\n' +
|
|
'\r\n');
|
|
socket.resume(); // Ignore the response itself
|
|
|
|
socket.on('close', cb);
|
|
});
|
|
}
|
|
|
|
server.listen(0, function() {
|
|
makeHttp11Request(function(firstSocket) {
|
|
makeHttp11Request(function(secondSocket) {
|
|
// Both HTTP/1.1 requests should have used the same socket:
|
|
assert.strictEqual(firstSocket, secondSocket);
|
|
|
|
makeHttp10Request(function() {
|
|
server.close();
|
|
});
|
|
});
|
|
});
|
|
});
|