8caa1dcee6
There are several cleanups here that are not just style nits... 1. The `common.isMainThread` was just a passthrough to the `isMainThread` export on the worker_thread module. It's use was inconsistent and just obfuscated the fact that the test file depend on the `worker_threads` built-in. By eliminating it we simplify the test harness a bit and make it clearer which tests depend on the worker_threads check. 2. The `common.isDumbTerminal` is fairly unnecesary since that just wraps a public API check. 3. Several of the `common.skipIf....` checks were inconsistently used and really don't need to be separate utility functions. A key part of the motivation here is to work towards making more of the tests more self-contained and less reliant on the common test harness where possible. PR-URL: https://github.com/nodejs/node/pull/56712 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
56 lines
1.7 KiB
JavaScript
56 lines
1.7 KiB
JavaScript
// Flags: --inspect=0
|
|
'use strict';
|
|
const common = require('../common');
|
|
|
|
common.skipIfInspectorDisabled();
|
|
|
|
const { isMainThread } = require('worker_threads');
|
|
|
|
if (!isMainThread) {
|
|
common.skip('This test only works on a main thread');
|
|
}
|
|
|
|
// Assert that even when started with `--inspect=0` workers are assigned
|
|
// consecutive (i.e. deterministically predictable) debug ports
|
|
|
|
const assert = require('assert');
|
|
const cluster = require('cluster');
|
|
|
|
function serialFork() {
|
|
return new Promise((res) => {
|
|
const worker = cluster.fork();
|
|
worker.on('exit', common.mustCall((code, signal) => {
|
|
// code 0 is normal
|
|
// code 12 can happen if inspector could not bind because of a port clash
|
|
if (code !== 0 && code !== 12)
|
|
assert.fail(`code: ${code}, signal: ${signal}`);
|
|
const port = worker.process.spawnargs
|
|
.map((a) => (/=(?:.*:)?(\d{2,5})$/.exec(a) || [])[1])
|
|
.filter((p) => p)
|
|
.pop();
|
|
res(Number(port));
|
|
}));
|
|
});
|
|
}
|
|
|
|
if (cluster.isPrimary) {
|
|
Promise.all([serialFork(), serialFork(), serialFork()])
|
|
.then(common.mustCall((ports) => {
|
|
ports.splice(0, 0, process.debugPort);
|
|
// 4 = [primary, worker1, worker2, worker3].length()
|
|
assert.strictEqual(ports.length, 4);
|
|
assert(ports.every((port) => port > 0));
|
|
assert(ports.every((port) => port < 65536));
|
|
assert.strictEqual(ports[0] === 65535 ? 1024 : ports[0] + 1, ports[1]);
|
|
assert.strictEqual(ports[1] === 65535 ? 1024 : ports[1] + 1, ports[2]);
|
|
assert.strictEqual(ports[2] === 65535 ? 1024 : ports[2] + 1, ports[3]);
|
|
}))
|
|
.catch(
|
|
(err) => {
|
|
console.error(err);
|
|
process.exit(1);
|
|
});
|
|
} else {
|
|
process.exit(0);
|
|
}
|