8caa1dcee6
There are several cleanups here that are not just style nits... 1. The `common.isMainThread` was just a passthrough to the `isMainThread` export on the worker_thread module. It's use was inconsistent and just obfuscated the fact that the test file depend on the `worker_threads` built-in. By eliminating it we simplify the test harness a bit and make it clearer which tests depend on the worker_threads check. 2. The `common.isDumbTerminal` is fairly unnecesary since that just wraps a public API check. 3. Several of the `common.skipIf....` checks were inconsistently used and really don't need to be separate utility functions. A key part of the motivation here is to work towards making more of the tests more self-contained and less reliant on the common test harness where possible. PR-URL: https://github.com/nodejs/node/pull/56712 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
41 lines
1.1 KiB
JavaScript
41 lines
1.1 KiB
JavaScript
// Flags: --permission --allow-child-process --allow-fs-read=*
|
|
'use strict';
|
|
|
|
const common = require('../common');
|
|
|
|
const { isMainThread } = require('worker_threads');
|
|
|
|
if (!isMainThread) {
|
|
common.skip('This test only works on a main thread');
|
|
}
|
|
|
|
const assert = require('assert');
|
|
const childProcess = require('child_process');
|
|
const fs = require('fs');
|
|
|
|
if (process.argv[2] === 'child') {
|
|
assert.throws(() => {
|
|
fs.writeFileSync(__filename, 'should not write');
|
|
}, common.expectsError({
|
|
code: 'ERR_ACCESS_DENIED',
|
|
permission: 'FileSystemWrite',
|
|
}));
|
|
process.exit(0);
|
|
}
|
|
|
|
// Guarantee the initial state
|
|
{
|
|
assert.ok(process.permission.has('child'));
|
|
}
|
|
|
|
// When a permission is set by cli, the process shouldn't be able
|
|
// to spawn unless --allow-child-process is sent
|
|
{
|
|
// doesNotThrow
|
|
childProcess.spawnSync(process.execPath, ['--version']);
|
|
childProcess.execSync(...common.escapePOSIXShell`"${process.execPath}" --version`);
|
|
const child = childProcess.fork(__filename, ['child']);
|
|
child.on('close', common.mustCall());
|
|
childProcess.execFileSync(process.execPath, ['--version']);
|
|
}
|