8caa1dcee6
There are several cleanups here that are not just style nits... 1. The `common.isMainThread` was just a passthrough to the `isMainThread` export on the worker_thread module. It's use was inconsistent and just obfuscated the fact that the test file depend on the `worker_threads` built-in. By eliminating it we simplify the test harness a bit and make it clearer which tests depend on the worker_threads check. 2. The `common.isDumbTerminal` is fairly unnecesary since that just wraps a public API check. 3. Several of the `common.skipIf....` checks were inconsistently used and really don't need to be separate utility functions. A key part of the motivation here is to work towards making more of the tests more self-contained and less reliant on the common test harness where possible. PR-URL: https://github.com/nodejs/node/pull/56712 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
51 lines
1.5 KiB
JavaScript
51 lines
1.5 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const { isMainThread } = require('worker_threads');
|
|
|
|
if (!isMainThread) {
|
|
common.skip('process.env.TZ is not intercepted in Workers');
|
|
}
|
|
|
|
if (common.isWindows) { // Using a different TZ format.
|
|
common.skip('todo: test on Windows');
|
|
}
|
|
|
|
const date = new Date('2018-04-14T12:34:56.789Z');
|
|
|
|
process.env.TZ = 'Europe/Amsterdam';
|
|
|
|
if (date.toString().includes('(Europe)'))
|
|
common.skip('not using bundled ICU'); // Shared library or --with-intl=none.
|
|
|
|
if ('Sat Apr 14 2018 12:34:56 GMT+0000 (GMT)' === date.toString())
|
|
common.skip('missing tzdata'); // Alpine buildbots lack Europe/Amsterdam.
|
|
|
|
if (date.toString().includes('(Central European Time)') ||
|
|
date.toString().includes('(CET)')) {
|
|
// The AIX and SmartOS buildbots report 2018 CEST as CET
|
|
// because apparently for them that's still the deep future.
|
|
common.skip('tzdata too old');
|
|
}
|
|
|
|
// Text representation of timezone depends on locale in environment
|
|
assert.match(
|
|
date.toString(),
|
|
/^Sat Apr 14 2018 14:34:56 GMT\+0200 \(.+\)$/);
|
|
|
|
process.env.TZ = 'Europe/London';
|
|
assert.match(
|
|
date.toString(),
|
|
/^Sat Apr 14 2018 13:34:56 GMT\+0100 \(.+\)$/);
|
|
|
|
process.env.TZ = 'Etc/UTC';
|
|
assert.match(
|
|
date.toString(),
|
|
/^Sat Apr 14 2018 12:34:56 GMT\+0000 \(.+\)$/);
|
|
|
|
// Just check that deleting the environment variable doesn't crash the process.
|
|
// We can't really check the result of date.toString() because we don't know
|
|
// the default time zone.
|
|
delete process.env.TZ;
|
|
date.toString();
|