8caa1dcee6
There are several cleanups here that are not just style nits... 1. The `common.isMainThread` was just a passthrough to the `isMainThread` export on the worker_thread module. It's use was inconsistent and just obfuscated the fact that the test file depend on the `worker_threads` built-in. By eliminating it we simplify the test harness a bit and make it clearer which tests depend on the worker_threads check. 2. The `common.isDumbTerminal` is fairly unnecesary since that just wraps a public API check. 3. Several of the `common.skipIf....` checks were inconsistently used and really don't need to be separate utility functions. A key part of the motivation here is to work towards making more of the tests more self-contained and less reliant on the common test harness where possible. PR-URL: https://github.com/nodejs/node/pull/56712 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
65 lines
1.4 KiB
JavaScript
65 lines
1.4 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
|
|
common.skipIfInspectorDisabled();
|
|
const { isMainThread } = require('worker_threads');
|
|
|
|
if (!isMainThread) {
|
|
common.skip('This test only works on a main thread');
|
|
}
|
|
|
|
const assert = require('assert');
|
|
const kMinPort = 1024;
|
|
const kMaxPort = 65535;
|
|
|
|
function check(value, expected) {
|
|
process.debugPort = value;
|
|
assert.strictEqual(process.debugPort, expected);
|
|
}
|
|
|
|
// Expected usage with numbers.
|
|
check(0, 0);
|
|
check(kMinPort, kMinPort);
|
|
check(kMinPort + 1, kMinPort + 1);
|
|
check(kMaxPort - 1, kMaxPort - 1);
|
|
check(kMaxPort, kMaxPort);
|
|
|
|
// Numeric strings coerce.
|
|
check('0', 0);
|
|
check(`${kMinPort}`, kMinPort);
|
|
check(`${kMinPort + 1}`, kMinPort + 1);
|
|
check(`${kMaxPort - 1}`, kMaxPort - 1);
|
|
check(`${kMaxPort}`, kMaxPort);
|
|
|
|
// Most other values are coerced to 0.
|
|
check('', 0);
|
|
check(false, 0);
|
|
check(NaN, 0);
|
|
check(Infinity, 0);
|
|
check(-Infinity, 0);
|
|
check(function() {}, 0);
|
|
check({}, 0);
|
|
check([], 0);
|
|
|
|
// Symbols do not coerce.
|
|
assert.throws(() => {
|
|
process.debugPort = Symbol();
|
|
}, /^TypeError: Cannot convert a Symbol value to a number$/);
|
|
|
|
// Verify port bounds checking.
|
|
[
|
|
true,
|
|
-1,
|
|
1,
|
|
kMinPort - 1,
|
|
kMaxPort + 1,
|
|
'-1',
|
|
'1',
|
|
`${kMinPort - 1}`,
|
|
`${kMaxPort + 1}`,
|
|
].forEach((value) => {
|
|
assert.throws(() => {
|
|
process.debugPort = value;
|
|
}, /^RangeError: process\.debugPort must be 0 or in range 1024 to 65535$/);
|
|
});
|