The ncrypto move introduced regressions in cryptoErrorListToException() by passing in the size of the vector unnecessarily into the vector constructor and then use push_back() (which would result in a crash on dereferencing empty handles during later iteration) and having incorrect logic for checking the presence of an exception. This patch fixes it. PR-URL: https://github.com/nodejs/node/pull/56554 Fixes: https://github.com/nodejs/node/issues/56375 Refs: https://github.com/nodejs/node/pull/53803 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
19 lines
526 B
JavaScript
19 lines
526 B
JavaScript
'use strict';
|
|
|
|
// This tests that the crypto error stack can be correctly converted.
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
|
|
const assert = require('assert');
|
|
const tls = require('tls');
|
|
|
|
assert.throws(() => {
|
|
tls.createSecureContext({ clientCertEngine: 'x' });
|
|
}, (err) => {
|
|
return err.name === 'Error' &&
|
|
/could not load the shared library/.test(err.message) &&
|
|
Array.isArray(err.opensslErrorStack) &&
|
|
err.opensslErrorStack.length > 0;
|
|
});
|