e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
21 lines
532 B
JavaScript
21 lines
532 B
JavaScript
'use strict';
|
|
// Flags: --expose_internals
|
|
|
|
require('../common');
|
|
const { internalBinding } = require('internal/test/binding');
|
|
const assert = require('assert');
|
|
|
|
// Monkey patch the os binding before requiring any other modules, including
|
|
// common, which requires the os module.
|
|
internalBinding('os').getHomeDirectory = function(ctx) {
|
|
ctx.syscall = 'foo';
|
|
ctx.code = 'bar';
|
|
ctx.message = 'baz';
|
|
};
|
|
|
|
const os = require('os');
|
|
|
|
assert.throws(os.homedir, {
|
|
message: /^A system error occurred: foo returned bar \(baz\)$/
|
|
});
|