69e6c5a212
This update does several significant things: 1. It eliminates the base Nghttp2* classes and folds those in to node::http2::Http2Session and node::http2::Http2Stream 2. It makes node::http2::Http2Stream a StreamBase instance and sends that out to JS-land to act as the [kHandle] for the JavaScript Http2Stream class. 3. It shifts some of the callbacks from C++ off of the JavaScript Http2Session class to the Http2Stream class. 4. It refactors the data provider structure for FD and Stream based sending to help encapsulate those functions easier 5. It streamlines some of the functions at the C++ layer to eliminate now unnecessary redirections 6. It cleans up node_http2.cc for better readability and maintainability 7. It refactors some of the debug output 8. Because Http2Stream instances are now StreamBases, they are now also trackable using async-hooks 9. The Stream::OnRead algorithm has been simplified with a couple bugs fixed. 10. I've eliminated node_http2_core.h and node_http2_core-inl.h 11. Detect invalid handshake a report protocol error to session 12. Refactor out of memory error, improve other errors 13. Add Http2Session.prototype.ping PR-URL: https://github.com/nodejs/node/pull/17105 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sebastiaan Deckers <sebdeckers83@gmail.com>
104 lines
2.5 KiB
JavaScript
104 lines
2.5 KiB
JavaScript
'use strict';
|
|
|
|
const {
|
|
constants,
|
|
Http2Session,
|
|
nghttp2ErrorString
|
|
} = process.binding('http2');
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const http2 = require('http2');
|
|
|
|
// tests error handling within requestOnConnect
|
|
// - NGHTTP2_ERR_STREAM_ID_NOT_AVAILABLE (should emit session error)
|
|
// - NGHTTP2_ERR_INVALID_ARGUMENT (should emit stream error)
|
|
// - every other NGHTTP2 error from binding (should emit session error)
|
|
|
|
const specificTestKeys = [
|
|
'NGHTTP2_ERR_STREAM_ID_NOT_AVAILABLE',
|
|
'NGHTTP2_ERR_INVALID_ARGUMENT'
|
|
];
|
|
|
|
const specificTests = [
|
|
{
|
|
ngError: constants.NGHTTP2_ERR_STREAM_ID_NOT_AVAILABLE,
|
|
error: {
|
|
code: 'ERR_HTTP2_OUT_OF_STREAMS',
|
|
type: Error,
|
|
message: 'No stream ID is available because ' +
|
|
'maximum stream ID has been reached'
|
|
},
|
|
type: 'stream'
|
|
},
|
|
{
|
|
ngError: constants.NGHTTP2_ERR_INVALID_ARGUMENT,
|
|
error: {
|
|
code: 'ERR_HTTP2_STREAM_SELF_DEPENDENCY',
|
|
type: Error,
|
|
message: 'A stream cannot depend on itself'
|
|
},
|
|
type: 'stream'
|
|
},
|
|
];
|
|
|
|
const genericTests = Object.getOwnPropertyNames(constants)
|
|
.filter((key) => (
|
|
key.indexOf('NGHTTP2_ERR') === 0 && specificTestKeys.indexOf(key) < 0
|
|
))
|
|
.map((key) => ({
|
|
ngError: constants[key],
|
|
error: {
|
|
code: 'ERR_HTTP2_ERROR',
|
|
type: Error,
|
|
message: nghttp2ErrorString(constants[key])
|
|
},
|
|
type: 'session'
|
|
}));
|
|
|
|
const tests = specificTests.concat(genericTests);
|
|
|
|
let currentError;
|
|
|
|
// mock submitRequest because we only care about testing error handling
|
|
Http2Session.prototype.request = () => currentError;
|
|
|
|
const server = http2.createServer(common.mustNotCall());
|
|
|
|
server.listen(0, common.mustCall(() => runTest(tests.shift())));
|
|
|
|
function runTest(test) {
|
|
const client = http2.connect(`http://localhost:${server.address().port}`);
|
|
const req = client.request({ ':method': 'POST' });
|
|
|
|
currentError = test.ngError;
|
|
req.resume();
|
|
req.end();
|
|
|
|
const errorMustCall = common.expectsError(test.error);
|
|
const errorMustNotCall = common.mustNotCall(
|
|
`${test.error.code} should emit on ${test.type}`
|
|
);
|
|
|
|
if (test.type === 'stream') {
|
|
client.on('error', errorMustNotCall);
|
|
req.on('error', errorMustCall);
|
|
req.on('error', common.mustCall(() => {
|
|
client.destroy();
|
|
}));
|
|
} else {
|
|
client.on('error', errorMustCall);
|
|
req.on('error', errorMustNotCall);
|
|
}
|
|
|
|
req.on('end', common.mustCall(() => {
|
|
client.destroy();
|
|
|
|
if (!tests.length) {
|
|
server.close();
|
|
} else {
|
|
runTest(tests.shift());
|
|
}
|
|
}));
|
|
}
|