PR-URL: https://github.com/nodejs/node/pull/17406 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> This is a significant cleanup and refactoring of the cleanup/close/destroy logic for Http2Stream and Http2Session. There are significant changes here in the timing and ordering of cleanup logic, JS apis. and various related necessary edits.
97 lines
2.3 KiB
JavaScript
97 lines
2.3 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const http2 = require('http2');
|
|
const {
|
|
constants,
|
|
Http2Stream,
|
|
nghttp2ErrorString
|
|
} = process.binding('http2');
|
|
|
|
// tests error handling within respond
|
|
// - every other NGHTTP2 error from binding (should emit stream error)
|
|
|
|
const specificTestKeys = [];
|
|
|
|
const specificTests = [];
|
|
|
|
const genericTests = Object.getOwnPropertyNames(constants)
|
|
.filter((key) => (
|
|
key.indexOf('NGHTTP2_ERR') === 0 && specificTestKeys.indexOf(key) < 0
|
|
))
|
|
.map((key) => ({
|
|
ngError: constants[key],
|
|
error: {
|
|
code: 'ERR_HTTP2_ERROR',
|
|
type: Error,
|
|
message: nghttp2ErrorString(constants[key])
|
|
},
|
|
type: 'stream'
|
|
}));
|
|
|
|
|
|
const tests = specificTests.concat(genericTests);
|
|
|
|
let currentError;
|
|
|
|
// mock submitResponse because we only care about testing error handling
|
|
Http2Stream.prototype.respond = () => currentError.ngError;
|
|
|
|
const server = http2.createServer();
|
|
server.on('stream', common.mustCall((stream, headers) => {
|
|
const errorMustCall = common.expectsError(currentError.error);
|
|
const errorMustNotCall = common.mustNotCall(
|
|
`${currentError.error.code} should emit on ${currentError.type}`
|
|
);
|
|
|
|
if (currentError.type === 'stream') {
|
|
stream.session.on('error', errorMustNotCall);
|
|
stream.on('error', errorMustCall);
|
|
stream.on('error', common.mustCall(() => {
|
|
stream.destroy();
|
|
}));
|
|
} else {
|
|
stream.session.once('error', errorMustCall);
|
|
stream.on('error', errorMustNotCall);
|
|
}
|
|
|
|
stream.respond();
|
|
}, tests.length));
|
|
|
|
server.listen(0, common.mustCall(() => runTest(tests.shift())));
|
|
|
|
function runTest(test) {
|
|
const port = server.address().port;
|
|
const url = `http://localhost:${port}`;
|
|
const headers = {
|
|
':path': '/',
|
|
':method': 'POST',
|
|
':scheme': 'http',
|
|
':authority': `localhost:${port}`
|
|
};
|
|
|
|
const client = http2.connect(url);
|
|
const req = client.request(headers);
|
|
req.on('error', common.expectsError({
|
|
code: 'ERR_HTTP2_STREAM_ERROR',
|
|
type: Error,
|
|
message: 'Stream closed with error code 2'
|
|
}));
|
|
|
|
currentError = test;
|
|
req.resume();
|
|
req.end();
|
|
|
|
req.on('end', common.mustCall(() => {
|
|
client.close();
|
|
|
|
if (!tests.length) {
|
|
server.close();
|
|
} else {
|
|
runTest(tests.shift());
|
|
}
|
|
}));
|
|
}
|