35607f3a2d
This commit changes the default value of the rejectUnauthorized option from false to true. What that means is that tls.connect(), https.get() and https.request() will reject invalid server certificates from now on, including self-signed certificates. There is an escape hatch: if you set the NODE_TLS_REJECT_UNAUTHORIZED environment variable to the literal string "0", node.js reverts to its old behavior. Fixes #3949.
61 lines
2.2 KiB
JavaScript
61 lines
2.2 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
// disable strict server certificate validation by the client
|
|
process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
|
|
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
var https = require('https');
|
|
var url = require('url');
|
|
var fs = require('fs');
|
|
var clientRequest;
|
|
|
|
// https options
|
|
var httpsOptions = {
|
|
key: fs.readFileSync(common.fixturesDir + '/keys/agent1-key.pem'),
|
|
cert: fs.readFileSync(common.fixturesDir + '/keys/agent1-cert.pem')
|
|
};
|
|
|
|
var testURL = url.parse('https://localhost:' + common.PORT);
|
|
|
|
function check(request) {
|
|
// assert that I'm https
|
|
assert.ok(request.socket.encrypted);
|
|
}
|
|
|
|
var server = https.createServer(httpsOptions, function(request, response) {
|
|
// run the check function
|
|
check.call(this, request, response);
|
|
response.writeHead(200, {});
|
|
response.end('ok');
|
|
server.close();
|
|
});
|
|
|
|
server.listen(common.PORT, function() {
|
|
// make the request
|
|
var clientRequest = https.request(testURL);
|
|
// since there is a little magic with the agent
|
|
// make sure that the request uses the https.Agent
|
|
assert.ok(clientRequest.agent instanceof https.Agent);
|
|
clientRequest.end();
|
|
});
|