32ac3769f5
Do not emit `upgrade` if the server is just advertising its protocols
support as per RFC 7230 Section 6.7.
A server MAY send an Upgrade header field in any other response
to advertise that it implements support for upgrading to the
listed protocols, in order of descending preference, when
appropriate for a future request.
Fix: https://github.com/nodejs/node/issues/4334
PR-URL: https://github.com/nodejs/node/pull/4337
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
75 lines
1.8 KiB
JavaScript
75 lines
1.8 KiB
JavaScript
'use strict';
|
|
// Verify that the 'upgrade' header causes an 'upgrade' event to be emitted to
|
|
// the HTTP client. This test uses a raw TCP server to better control server
|
|
// behavior.
|
|
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
|
|
var http = require('http');
|
|
var net = require('net');
|
|
|
|
// Create a TCP server
|
|
var srv = net.createServer(function(c) {
|
|
var data = '';
|
|
c.on('data', function(d) {
|
|
data += d.toString('utf8');
|
|
|
|
c.write('HTTP/1.1 101\r\n');
|
|
c.write('hello: world\r\n');
|
|
c.write('connection: upgrade\r\n');
|
|
c.write('upgrade: websocket\r\n');
|
|
c.write('\r\n');
|
|
c.write('nurtzo');
|
|
});
|
|
|
|
c.on('end', function() {
|
|
c.end();
|
|
});
|
|
});
|
|
|
|
var gotUpgrade = false;
|
|
|
|
srv.listen(common.PORT, '127.0.0.1', function() {
|
|
|
|
var options = {
|
|
port: common.PORT,
|
|
host: '127.0.0.1',
|
|
headers: {
|
|
'connection': 'upgrade',
|
|
'upgrade': 'websocket'
|
|
}
|
|
};
|
|
var name = options.host + ':' + options.port;
|
|
|
|
var req = http.request(options);
|
|
req.end();
|
|
|
|
req.on('upgrade', function(res, socket, upgradeHead) {
|
|
// XXX: This test isn't fantastic, as it assumes that the entire response
|
|
// from the server will arrive in a single data callback
|
|
assert.equal(upgradeHead, 'nurtzo');
|
|
|
|
console.log(res.headers);
|
|
var expectedHeaders = { 'hello': 'world',
|
|
'connection': 'upgrade',
|
|
'upgrade': 'websocket' };
|
|
assert.deepEqual(expectedHeaders, res.headers);
|
|
|
|
// Make sure this request got removed from the pool.
|
|
assert(!http.globalAgent.sockets.hasOwnProperty(name));
|
|
|
|
req.on('close', function() {
|
|
socket.end();
|
|
srv.close();
|
|
|
|
gotUpgrade = true;
|
|
});
|
|
});
|
|
|
|
});
|
|
|
|
process.on('exit', function() {
|
|
assert.ok(gotUpgrade);
|
|
});
|