The `'timeout'` event is currently not emitted on the `ClientRequest` instance when the socket timeout expires if only the `timeout` option of the agent is set. This happens because, under these circumstances, `listenSocketTimeout()` is not called. This commit fixes the issue by calling it also when only the agent `timeout` option is set. PR-URL: https://github.com/nodejs/node/pull/25488 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
24 lines
605 B
JavaScript
24 lines
605 B
JavaScript
'use strict';
|
|
|
|
const { expectsError, mustCall } = require('../common');
|
|
const { Agent, get } = require('http');
|
|
|
|
// Test that the `'timeout'` event is emitted on the `ClientRequest` instance
|
|
// when the socket timeout set via the `timeout` option of the `Agent` expires.
|
|
|
|
const request = get({
|
|
agent: new Agent({ timeout: 500 }),
|
|
// Non-routable IP address to prevent the connection from being established.
|
|
host: '192.0.2.1'
|
|
});
|
|
|
|
request.on('error', expectsError({
|
|
type: Error,
|
|
code: 'ECONNRESET',
|
|
message: 'socket hang up'
|
|
}));
|
|
|
|
request.on('timeout', mustCall(() => {
|
|
request.abort();
|
|
}));
|