38998d8538
Since this property access is performed by generated code, and not used for accessing the actual exports of a module (and because transpilers generally define it as the first key of `module.exports` when it *is* present), it should be okay to allow it. Refs: https://github.com/nodejs/node/pull/29935 Fixes: https://github.com/nodejs/node/issues/33046 PR-URL: https://github.com/nodejs/node/pull/33048 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
41 lines
1.7 KiB
JavaScript
41 lines
1.7 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const fixtures = require('../common/fixtures');
|
|
|
|
common.expectWarning({
|
|
Warning: [
|
|
["Accessing non-existent property 'missingPropB' " +
|
|
'of module exports inside circular dependency'],
|
|
["Accessing non-existent property 'Symbol(someSymbol)' " +
|
|
'of module exports inside circular dependency'],
|
|
["Accessing non-existent property 'missingPropModuleExportsB' " +
|
|
'of module exports inside circular dependency']
|
|
]
|
|
});
|
|
const required = require(fixtures.path('cycles', 'warning-a.js'));
|
|
assert.strictEqual(Object.getPrototypeOf(required), Object.prototype);
|
|
|
|
const requiredWithModuleExportsOverridden =
|
|
require(fixtures.path('cycles', 'warning-moduleexports-a.js'));
|
|
assert.strictEqual(Object.getPrototypeOf(requiredWithModuleExportsOverridden),
|
|
Object.prototype);
|
|
|
|
// If module.exports is not a regular object, no warning should be emitted.
|
|
const classExport =
|
|
require(fixtures.path('cycles', 'warning-moduleexports-class-a.js'));
|
|
assert.strictEqual(Object.getPrototypeOf(classExport).name, 'Parent');
|
|
|
|
// If module.exports.__esModule is set, no warning should be emitted.
|
|
const esmTranspiledExport =
|
|
require(fixtures.path('cycles', 'warning-esm-transpiled-a.js'));
|
|
assert.strictEqual(esmTranspiledExport.__esModule, true);
|
|
|
|
// If module.exports.__esModule is being accessed but is not present, e.g.
|
|
// because only the one of the files is a transpiled ES module, no warning
|
|
// should be emitted.
|
|
const halfTranspiledExport =
|
|
require(fixtures.path('cycles', 'warning-esm-half-transpiled-a.js'));
|
|
assert.strictEqual(halfTranspiledExport.__esModule, undefined);
|