e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
60 lines
1.5 KiB
JavaScript
60 lines
1.5 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const http2 = require('http2');
|
|
|
|
const errCheck = common.expectsError({
|
|
name: 'Error',
|
|
code: 'ERR_STREAM_WRITE_AFTER_END',
|
|
message: 'write after end'
|
|
}, 2);
|
|
|
|
const {
|
|
HTTP2_HEADER_PATH,
|
|
HTTP2_HEADER_METHOD,
|
|
HTTP2_HEADER_STATUS,
|
|
HTTP2_METHOD_HEAD,
|
|
} = http2.constants;
|
|
|
|
const server = http2.createServer();
|
|
server.on('stream', (stream, headers) => {
|
|
|
|
assert.strictEqual(headers[HTTP2_HEADER_METHOD], HTTP2_METHOD_HEAD);
|
|
|
|
stream.respond({ [HTTP2_HEADER_STATUS]: 200 });
|
|
|
|
// Because this is a head request, the outbound stream is closed automatically
|
|
stream.on('error', errCheck);
|
|
stream.write('data');
|
|
});
|
|
|
|
|
|
server.listen(0, () => {
|
|
|
|
const client = http2.connect(`http://localhost:${server.address().port}`);
|
|
|
|
const req = client.request({
|
|
[HTTP2_HEADER_METHOD]: HTTP2_METHOD_HEAD,
|
|
[HTTP2_HEADER_PATH]: '/'
|
|
});
|
|
|
|
// Because it is a HEAD request, the payload is meaningless. The
|
|
// option.endStream flag is set automatically making the stream
|
|
// non-writable.
|
|
req.on('error', errCheck);
|
|
req.write('data');
|
|
|
|
req.on('response', common.mustCall((headers, flags) => {
|
|
assert.strictEqual(headers[HTTP2_HEADER_STATUS], 200);
|
|
assert.strictEqual(flags, 5); // The end of stream flag is set
|
|
}));
|
|
req.on('data', common.mustNotCall());
|
|
req.on('end', common.mustCall(() => {
|
|
server.close();
|
|
client.close();
|
|
}));
|
|
});
|