0babd181a0
PR-URL: https://github.com/nodejs/node/pull/17406 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> This is a significant cleanup and refactoring of the cleanup/close/destroy logic for Http2Stream and Http2Session. There are significant changes here in the timing and ordering of cleanup logic, JS apis. and various related necessary edits.
47 lines
1.2 KiB
JavaScript
47 lines
1.2 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const fixtures = require('../common/fixtures');
|
|
const assert = require('assert');
|
|
const http2 = require('http2');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
|
|
// piping should work as expected with createWriteStream
|
|
|
|
common.refreshTmpDir();
|
|
const loc = fixtures.path('url-tests.js');
|
|
const fn = path.join(common.tmpDir, 'http2-url-tests.js');
|
|
|
|
const server = http2.createServer();
|
|
|
|
server.on('stream', common.mustCall((stream) => {
|
|
const dest = stream.pipe(fs.createWriteStream(fn));
|
|
|
|
dest.on('finish', () => {
|
|
assert.strictEqual(fs.readFileSync(loc).length,
|
|
fs.readFileSync(fn).length);
|
|
});
|
|
stream.respond();
|
|
stream.end();
|
|
}));
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const client = http2.connect(`http://localhost:${server.address().port}`);
|
|
|
|
const req = client.request({ ':method': 'POST' });
|
|
req.on('response', common.mustCall());
|
|
req.resume();
|
|
|
|
req.on('close', common.mustCall(() => {
|
|
server.close();
|
|
client.close();
|
|
}));
|
|
|
|
const str = fs.createReadStream(loc);
|
|
str.on('end', common.mustCall());
|
|
str.pipe(req);
|
|
}));
|