8876ac5c35
Fix some issues introduced/not fixed via https://github.com/nodejs/node/pull/25094: * Init hook is not emitted for a reused HTTPParser * HTTPParser was still used as resource in init hook * type used in init hook was always HTTPINCOMINGMESSAGE even for client requests * some tests have not been adapted to new resource names With this change the async hooks init event is emitted during a call to Initialize() as the type and resource object is available at this time. As a result Initialize() must be called now which could be seen as breaking change even HTTPParser is not part of documented API. It was needed to put the ClientRequest instance into a wrapper object instead passing it directly as async resource otherwise test-domain-multi fails. I think this is because adding an EventEmitter to a Domain adds a property 'domain' and the presence of this changes the context propagation in domains. Besides that tests still refering to resource HTTPParser have been updated/improved. Fixes: https://github.com/nodejs/node/issues/27467 Fixes: https://github.com/nodejs/node/issues/26961 Refs: https://github.com/nodejs/node/pull/25094 PR-URL: https://github.com/nodejs/node/pull/27477 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
47 lines
1.3 KiB
JavaScript
47 lines
1.3 KiB
JavaScript
// Flags: --expose-internals
|
|
|
|
'use strict';
|
|
|
|
const { internalBinding } = require('internal/test/binding');
|
|
const { getOptionValue } = require('internal/options');
|
|
|
|
// Monkey patch before requiring anything
|
|
class DummyParser {
|
|
constructor() {
|
|
this.test_type = null;
|
|
}
|
|
initialize(type) {
|
|
this.test_type = type;
|
|
}
|
|
}
|
|
DummyParser.REQUEST = Symbol();
|
|
|
|
const binding =
|
|
getOptionValue('--http-parser') === 'legacy' ?
|
|
internalBinding('http_parser') : internalBinding('http_parser_llhttp');
|
|
binding.HTTPParser = DummyParser;
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const { spawn } = require('child_process');
|
|
const { parsers } = require('_http_common');
|
|
|
|
// Test _http_common was not loaded before monkey patching
|
|
const parser = parsers.alloc();
|
|
parser.initialize(DummyParser.REQUEST, {});
|
|
assert.strictEqual(parser instanceof DummyParser, true);
|
|
assert.strictEqual(parser.test_type, DummyParser.REQUEST);
|
|
|
|
if (process.argv[2] !== 'child') {
|
|
// Also test in a child process with IPC (specific case of https://github.com/nodejs/node/issues/23716)
|
|
const child = spawn(process.execPath, [
|
|
'--expose-internals', __filename, 'child'
|
|
], {
|
|
stdio: ['inherit', 'inherit', 'inherit', 'ipc']
|
|
});
|
|
child.on('exit', common.mustCall((code, signal) => {
|
|
assert.strictEqual(code, 0);
|
|
assert.strictEqual(signal, null);
|
|
}));
|
|
}
|