85ab4a5f12
Several changes:
* Soft-Deprecate Buffer() constructors
* Add `Buffer.from()`, `Buffer.alloc()`, and `Buffer.allocUnsafe()`
* Add `--zero-fill-buffers` command line option
* Add byteOffset and length to `new Buffer(arrayBuffer)` constructor
* buffer.fill('') previously had no effect, now zero-fills
* Update the docs
PR-URL: https://github.com/nodejs/node/pull/4682
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
57 lines
1.3 KiB
JavaScript
57 lines
1.3 KiB
JavaScript
'use strict';
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
|
|
if (!common.hasCrypto) {
|
|
console.log('1..0 # Skipped: missing crypto');
|
|
return;
|
|
}
|
|
var https = require('https');
|
|
|
|
var fs = require('fs');
|
|
|
|
var key = fs.readFileSync(common.fixturesDir + '/keys/agent1-key.pem');
|
|
var cert = fs.readFileSync(common.fixturesDir + '/keys/agent1-cert.pem');
|
|
|
|
var PORT = common.PORT;
|
|
|
|
// number of bytes discovered empirically to trigger the bug
|
|
var data = Buffer.allocUnsafe(1024 * 32 + 1);
|
|
|
|
httpsTest();
|
|
|
|
function httpsTest() {
|
|
var sopt = { key: key, cert: cert };
|
|
|
|
var server = https.createServer(sopt, function(req, res) {
|
|
res.setHeader('content-length', data.length);
|
|
res.end(data);
|
|
server.close();
|
|
});
|
|
|
|
server.listen(PORT, function() {
|
|
var opts = { port: PORT, rejectUnauthorized: false };
|
|
https.get(opts).on('response', function(res) {
|
|
test(res);
|
|
});
|
|
});
|
|
}
|
|
|
|
|
|
function test(res) {
|
|
res.on('end', function() {
|
|
assert.equal(res._readableState.length, 0);
|
|
assert.equal(bytes, data.length);
|
|
console.log('ok');
|
|
});
|
|
|
|
// Pause and then resume on each chunk, to ensure that there will be
|
|
// a lone byte hanging out at the very end.
|
|
var bytes = 0;
|
|
res.on('data', function(chunk) {
|
|
bytes += chunk.length;
|
|
this.pause();
|
|
setTimeout(this.resume.bind(this));
|
|
});
|
|
}
|