1fcb128771
We had a bunch of tests that would fail if run from an executable that contains any char that should be escaped when run from a shell. PR-URL: https://github.com/nodejs/node/pull/55028 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
46 lines
1.4 KiB
JavaScript
46 lines
1.4 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const { exec } = require('child_process');
|
|
const fixtures = require('../common/fixtures');
|
|
|
|
// The execPath might contain chars that should be escaped in a shell context.
|
|
// On non-Windows, we can pass the path via the env; `"` is not a valid char on
|
|
// Windows, so we can simply pass the path.
|
|
const execNode = (flag, file, callback) => exec(
|
|
`"${common.isWindows ? process.execPath : '$NODE'}" ${flag} "${common.isWindows ? file : '$FILE'}"`,
|
|
common.isWindows ? undefined : { env: { ...process.env, NODE: process.execPath, FILE: file } },
|
|
callback,
|
|
);
|
|
|
|
// Test both sets of arguments that check syntax
|
|
const syntaxArgs = [
|
|
'-c',
|
|
'--check',
|
|
];
|
|
|
|
const notFoundRE = /^Error: Cannot find module/m;
|
|
|
|
// test file not found
|
|
[
|
|
'syntax/file_not_found.js',
|
|
'syntax/file_not_found',
|
|
].forEach(function(file) {
|
|
file = fixtures.path(file);
|
|
|
|
// Loop each possible option, `-c` or `--check`
|
|
syntaxArgs.forEach(function(flag) {
|
|
execNode(flag, file, common.mustCall((err, stdout, stderr) => {
|
|
// No stdout should be produced
|
|
assert.strictEqual(stdout, '');
|
|
|
|
// `stderr` should have a module not found error message.
|
|
assert.match(stderr, notFoundRE);
|
|
|
|
assert.strictEqual(err.code, 1,
|
|
`code ${err.code} !== 1 for error:\n\n${err}`);
|
|
}));
|
|
});
|
|
});
|