e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
41 lines
774 B
JavaScript
41 lines
774 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
|
|
const { strictEqual } = require('assert');
|
|
const { Transform } = require('stream');
|
|
|
|
const t = new Transform();
|
|
|
|
t.on('error', common.expectsError({
|
|
name: 'Error',
|
|
code: 'ERR_METHOD_NOT_IMPLEMENTED',
|
|
message: 'The _transform() method is not implemented'
|
|
}));
|
|
|
|
t.end(Buffer.from('blerg'));
|
|
|
|
const _transform = common.mustCall((chunk, _, next) => {
|
|
next();
|
|
});
|
|
|
|
const _final = common.mustCall((next) => {
|
|
next();
|
|
});
|
|
|
|
const _flush = common.mustCall((next) => {
|
|
next();
|
|
});
|
|
|
|
const t2 = new Transform({
|
|
transform: _transform,
|
|
flush: _flush,
|
|
final: _final
|
|
});
|
|
|
|
strictEqual(t2._transform, _transform);
|
|
strictEqual(t2._flush, _flush);
|
|
strictEqual(t2._final, _final);
|
|
|
|
t2.end(Buffer.from('blerg'));
|
|
t2.resume();
|