There are several cleanups here that are not just style nits... 1. The `common.isMainThread` was just a passthrough to the `isMainThread` export on the worker_thread module. It's use was inconsistent and just obfuscated the fact that the test file depend on the `worker_threads` built-in. By eliminating it we simplify the test harness a bit and make it clearer which tests depend on the worker_threads check. 2. The `common.isDumbTerminal` is fairly unnecesary since that just wraps a public API check. 3. Several of the `common.skipIf....` checks were inconsistently used and really don't need to be separate utility functions. A key part of the motivation here is to work towards making more of the tests more self-contained and less reliant on the common test harness where possible. PR-URL: https://github.com/nodejs/node/pull/56712 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
48 lines
1.3 KiB
JavaScript
48 lines
1.3 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
common.skipIfInspectorDisabled();
|
|
|
|
const { isMainThread, workerData, Worker } = require('node:worker_threads');
|
|
if (!workerData && !isMainThread) {
|
|
common.skip('This test only works on a main thread');
|
|
}
|
|
|
|
const assert = require('node:assert');
|
|
|
|
let TIMEOUT = common.platformTimeout(5000);
|
|
if (common.isWindows) {
|
|
// Refs: https://github.com/nodejs/build/issues/3014
|
|
TIMEOUT = common.platformTimeout(15000);
|
|
}
|
|
|
|
// Refs: https://github.com/nodejs/node/issues/53648
|
|
|
|
(async () => {
|
|
if (!workerData) {
|
|
// worker.terminate() should terminate the worker created with execArgv:
|
|
// ["--inspect-brk"].
|
|
{
|
|
const worker = new Worker(__filename, {
|
|
execArgv: ['--inspect-brk=0'],
|
|
workerData: {},
|
|
});
|
|
await new Promise((r) => setTimeout(r, TIMEOUT));
|
|
worker.on('exit', common.mustCall());
|
|
await worker.terminate();
|
|
}
|
|
// process.exit() should kill the process.
|
|
{
|
|
new Worker(__filename, {
|
|
execArgv: ['--inspect-brk=0'],
|
|
workerData: {},
|
|
});
|
|
await new Promise((r) => setTimeout(r, TIMEOUT));
|
|
process.on('exit', (status) => assert.strictEqual(status, 0));
|
|
setImmediate(() => process.exit());
|
|
}
|
|
} else {
|
|
console.log('Worker running!');
|
|
}
|
|
})().then(common.mustCall());
|