e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
35 lines
1.0 KiB
JavaScript
35 lines
1.0 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const http = require('http');
|
|
const Countdown = require('../common/countdown');
|
|
|
|
const expectedSuccesses = [undefined, null, 'GET', 'post'];
|
|
const expectedFails = [-1, 1, 0, {}, true, false, [], Symbol()];
|
|
|
|
const countdown =
|
|
new Countdown(expectedSuccesses.length,
|
|
common.mustCall(() => server.close()));
|
|
|
|
const server = http.createServer(common.mustCall((req, res) => {
|
|
res.end();
|
|
countdown.dec();
|
|
}, expectedSuccesses.length));
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
expectedFails.forEach((method) => {
|
|
assert.throws(() => {
|
|
http.request({ method, path: '/' }, common.mustNotCall());
|
|
}, {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "method" argument must be of type string.' +
|
|
common.invalidArgTypeHelper(method)
|
|
});
|
|
});
|
|
|
|
expectedSuccesses.forEach((method) => {
|
|
http.request({ method, port: server.address().port }).end();
|
|
});
|
|
}));
|