e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
79 lines
1.7 KiB
JavaScript
79 lines
1.7 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
|
|
const options = 'test';
|
|
const expectedError = {
|
|
code: 'ERR_INVALID_OPT_VALUE_ENCODING',
|
|
name: 'TypeError',
|
|
};
|
|
|
|
assert.throws(() => {
|
|
fs.readFile('path', options, common.mustNotCall());
|
|
}, expectedError);
|
|
|
|
assert.throws(() => {
|
|
fs.readFileSync('path', options);
|
|
}, expectedError);
|
|
|
|
assert.throws(() => {
|
|
fs.readdir('path', options, common.mustNotCall());
|
|
}, expectedError);
|
|
|
|
assert.throws(() => {
|
|
fs.readdirSync('path', options);
|
|
}, expectedError);
|
|
|
|
assert.throws(() => {
|
|
fs.readlink('path', options, common.mustNotCall());
|
|
}, expectedError);
|
|
|
|
assert.throws(() => {
|
|
fs.readlinkSync('path', options);
|
|
}, expectedError);
|
|
|
|
assert.throws(() => {
|
|
fs.writeFile('path', 'data', options, common.mustNotCall());
|
|
}, expectedError);
|
|
|
|
assert.throws(() => {
|
|
fs.writeFileSync('path', 'data', options);
|
|
}, expectedError);
|
|
|
|
assert.throws(() => {
|
|
fs.appendFile('path', 'data', options, common.mustNotCall());
|
|
}, expectedError);
|
|
|
|
assert.throws(() => {
|
|
fs.appendFileSync('path', 'data', options);
|
|
}, expectedError);
|
|
|
|
assert.throws(() => {
|
|
fs.watch('path', options, common.mustNotCall());
|
|
}, expectedError);
|
|
|
|
assert.throws(() => {
|
|
fs.realpath('path', options, common.mustNotCall());
|
|
}, expectedError);
|
|
|
|
assert.throws(() => {
|
|
fs.realpathSync('path', options);
|
|
}, expectedError);
|
|
|
|
assert.throws(() => {
|
|
fs.mkdtemp('path', options, common.mustNotCall());
|
|
}, expectedError);
|
|
|
|
assert.throws(() => {
|
|
fs.mkdtempSync('path', options);
|
|
}, expectedError);
|
|
|
|
assert.throws(() => {
|
|
fs.ReadStream('path', options);
|
|
}, expectedError);
|
|
|
|
assert.throws(() => {
|
|
fs.WriteStream('path', options);
|
|
}, expectedError);
|