e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
55 lines
1.3 KiB
JavaScript
55 lines
1.3 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
|
|
const tmpdir = require('../common/tmpdir');
|
|
|
|
const readdirDir = tmpdir.path;
|
|
const files = ['empty', 'files', 'for', 'just', 'testing'];
|
|
|
|
// Make sure tmp directory is clean
|
|
tmpdir.refresh();
|
|
|
|
// Create the necessary files
|
|
files.forEach(function(currentFile) {
|
|
fs.closeSync(fs.openSync(`${readdirDir}/${currentFile}`, 'w'));
|
|
});
|
|
|
|
// Check the readdir Sync version
|
|
assert.deepStrictEqual(files, fs.readdirSync(readdirDir).sort());
|
|
|
|
// Check the readdir async version
|
|
fs.readdir(readdirDir, common.mustCall(function(err, f) {
|
|
assert.ifError(err);
|
|
assert.deepStrictEqual(files, f.sort());
|
|
}));
|
|
|
|
// readdir() on file should throw ENOTDIR
|
|
// https://github.com/joyent/node/issues/1869
|
|
assert.throws(function() {
|
|
fs.readdirSync(__filename);
|
|
}, /Error: ENOTDIR: not a directory/);
|
|
|
|
fs.readdir(__filename, common.mustCall(function(e) {
|
|
assert.strictEqual(e.code, 'ENOTDIR');
|
|
}));
|
|
|
|
[false, 1, [], {}, null, undefined].forEach((i) => {
|
|
assert.throws(
|
|
() => fs.readdir(i, common.mustNotCall()),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError'
|
|
}
|
|
);
|
|
assert.throws(
|
|
() => fs.readdirSync(i),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError'
|
|
}
|
|
);
|
|
});
|