8700d89306
Whether and when a socket is destroyed or not after a timeout is up to the user. This leaves an edge case where a socket that has emitted 'timeout' might be re-used from the free pool. Even if destroy is called on the socket, it won't be removed from the freelist until 'close' which can happen several ticks later. Sockets are removed from the free list on the 'close' event. However, there is a delay between calling destroy() and 'close' being emitted. This means that it possible for a socket that has been destroyed to be re-used from the free list, causing unexpected failures. PR-URL: https://github.com/nodejs/node/pull/32000 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
49 lines
1.1 KiB
JavaScript
49 lines
1.1 KiB
JavaScript
'use strict';
|
|
|
|
// Test that the `'timeout'` event is emitted exactly once if the `timeout`
|
|
// option and `request.setTimeout()` are used together.
|
|
|
|
const { expectsError, mustCall } = require('../common');
|
|
const { strictEqual } = require('assert');
|
|
const { createServer, get } = require('http');
|
|
|
|
const server = createServer(() => {
|
|
// Never respond.
|
|
});
|
|
|
|
server.listen(0, mustCall(() => {
|
|
const req = get({
|
|
port: server.address().port,
|
|
timeout: 2000,
|
|
});
|
|
|
|
req.setTimeout(1000);
|
|
|
|
req.on('socket', mustCall((socket) => {
|
|
strictEqual(socket.timeout, 2000);
|
|
|
|
socket.on('connect', mustCall(() => {
|
|
strictEqual(socket.timeout, 1000);
|
|
|
|
// Reschedule the timer to not wait 1 sec and make the test finish faster.
|
|
socket.setTimeout(10);
|
|
strictEqual(socket.timeout, 10);
|
|
}));
|
|
}));
|
|
|
|
req.on('error', expectsError({
|
|
name: 'Error',
|
|
code: 'ECONNRESET',
|
|
message: 'socket hang up'
|
|
}));
|
|
|
|
req.on('close', mustCall(() => {
|
|
server.close();
|
|
}));
|
|
|
|
req.on('timeout', mustCall(() => {
|
|
strictEqual(req.socket.listenerCount('timeout'), 1);
|
|
req.destroy();
|
|
}));
|
|
}));
|