e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
36 lines
902 B
JavaScript
36 lines
902 B
JavaScript
'use strict';
|
|
// Flags: --expose-internals
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
|
|
const http = require('http');
|
|
const http2 = require('http2');
|
|
const { NghttpError } = require('internal/http2/util');
|
|
|
|
// Creating an http1 server here...
|
|
const server = http.createServer(common.mustNotCall());
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const client = http2.connect(`http://localhost:${server.address().port}`);
|
|
|
|
const req = client.request();
|
|
req.on('close', common.mustCall());
|
|
|
|
req.on('error', common.expectsError({
|
|
code: 'ERR_HTTP2_ERROR',
|
|
constructor: NghttpError,
|
|
message: 'Protocol error'
|
|
}));
|
|
|
|
client.on('error', common.expectsError({
|
|
code: 'ERR_HTTP2_ERROR',
|
|
constructor: NghttpError,
|
|
name: 'Error',
|
|
message: 'Protocol error'
|
|
}));
|
|
|
|
client.on('close', common.mustCall(() => server.close()));
|
|
}));
|