e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
110 lines
3.0 KiB
JavaScript
110 lines
3.0 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const net = require('net');
|
|
const http2 = require('http2');
|
|
const { URL } = require('url');
|
|
|
|
const {
|
|
HTTP2_HEADER_METHOD,
|
|
HTTP2_HEADER_AUTHORITY,
|
|
HTTP2_HEADER_SCHEME,
|
|
HTTP2_HEADER_PATH,
|
|
NGHTTP2_CONNECT_ERROR,
|
|
NGHTTP2_REFUSED_STREAM
|
|
} = http2.constants;
|
|
|
|
const server = net.createServer(common.mustCall((socket) => {
|
|
let data = '';
|
|
socket.setEncoding('utf8');
|
|
socket.on('data', (chunk) => data += chunk);
|
|
socket.on('end', common.mustCall(() => {
|
|
assert.strictEqual(data, 'hello');
|
|
}));
|
|
socket.on('close', common.mustCall());
|
|
socket.end('hello');
|
|
}));
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
|
|
const port = server.address().port;
|
|
|
|
const proxy = http2.createServer();
|
|
proxy.on('stream', common.mustCall((stream, headers) => {
|
|
if (headers[HTTP2_HEADER_METHOD] !== 'CONNECT') {
|
|
stream.close(NGHTTP2_REFUSED_STREAM);
|
|
return;
|
|
}
|
|
const auth = new URL(`tcp://${headers[HTTP2_HEADER_AUTHORITY]}`);
|
|
assert.strictEqual(auth.hostname, 'localhost');
|
|
assert.strictEqual(+auth.port, port);
|
|
const socket = net.connect(auth.port, auth.hostname, () => {
|
|
stream.respond();
|
|
socket.pipe(stream);
|
|
stream.pipe(socket);
|
|
});
|
|
socket.on('close', common.mustCall());
|
|
socket.on('error', (error) => {
|
|
stream.close(NGHTTP2_CONNECT_ERROR);
|
|
});
|
|
}));
|
|
|
|
proxy.listen(0, () => {
|
|
const client = http2.connect(`http://localhost:${proxy.address().port}`);
|
|
|
|
// Confirm that :authority is required and :scheme & :path are forbidden
|
|
assert.throws(
|
|
() => client.request({
|
|
[HTTP2_HEADER_METHOD]: 'CONNECT'
|
|
}),
|
|
{
|
|
code: 'ERR_HTTP2_CONNECT_AUTHORITY',
|
|
message: ':authority header is required for CONNECT requests'
|
|
}
|
|
);
|
|
assert.throws(
|
|
() => client.request({
|
|
[HTTP2_HEADER_METHOD]: 'CONNECT',
|
|
[HTTP2_HEADER_AUTHORITY]: `localhost:${port}`,
|
|
[HTTP2_HEADER_SCHEME]: 'http'
|
|
}),
|
|
{
|
|
code: 'ERR_HTTP2_CONNECT_SCHEME',
|
|
message: 'The :scheme header is forbidden for CONNECT requests'
|
|
}
|
|
);
|
|
assert.throws(
|
|
() => client.request({
|
|
[HTTP2_HEADER_METHOD]: 'CONNECT',
|
|
[HTTP2_HEADER_AUTHORITY]: `localhost:${port}`,
|
|
[HTTP2_HEADER_PATH]: '/'
|
|
}),
|
|
{
|
|
code: 'ERR_HTTP2_CONNECT_PATH',
|
|
message: 'The :path header is forbidden for CONNECT requests'
|
|
}
|
|
);
|
|
|
|
// valid CONNECT request
|
|
const req = client.request({
|
|
[HTTP2_HEADER_METHOD]: 'CONNECT',
|
|
[HTTP2_HEADER_AUTHORITY]: `localhost:${port}`,
|
|
});
|
|
|
|
req.on('response', common.mustCall());
|
|
let data = '';
|
|
req.setEncoding('utf8');
|
|
req.on('data', (chunk) => data += chunk);
|
|
req.on('end', common.mustCall(() => {
|
|
assert.strictEqual(data, 'hello');
|
|
client.close();
|
|
proxy.close();
|
|
server.close();
|
|
}));
|
|
req.end('hello');
|
|
});
|
|
}));
|