e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
47 lines
856 B
JavaScript
47 lines
856 B
JavaScript
'use strict';
|
|
require('../common');
|
|
|
|
// This test ensures that the escapeCodeTimeout option set correctly
|
|
|
|
const assert = require('assert');
|
|
const readline = require('readline');
|
|
const EventEmitter = require('events').EventEmitter;
|
|
|
|
class FakeInput extends EventEmitter {
|
|
resume() {}
|
|
pause() {}
|
|
write() {}
|
|
end() {}
|
|
}
|
|
|
|
{
|
|
const fi = new FakeInput();
|
|
const rli = new readline.Interface({
|
|
input: fi,
|
|
output: fi,
|
|
escapeCodeTimeout: 50
|
|
});
|
|
assert.strictEqual(rli.escapeCodeTimeout, 50);
|
|
rli.close();
|
|
}
|
|
|
|
[
|
|
null,
|
|
{},
|
|
NaN,
|
|
'50'
|
|
].forEach((invalidInput) => {
|
|
assert.throws(() => {
|
|
const fi = new FakeInput();
|
|
const rli = new readline.Interface({
|
|
input: fi,
|
|
output: fi,
|
|
escapeCodeTimeout: invalidInput
|
|
});
|
|
rli.close();
|
|
}, {
|
|
name: 'TypeError',
|
|
code: 'ERR_INVALID_OPT_VALUE'
|
|
});
|
|
});
|