e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
91 lines
2.5 KiB
JavaScript
91 lines
2.5 KiB
JavaScript
'use strict';
|
|
require('../common');
|
|
const assert = require('assert');
|
|
|
|
const { Transform, Readable, Writable } = require('stream');
|
|
|
|
const DEFAULT = 16 * 1024;
|
|
|
|
function testTransform(expectedReadableHwm, expectedWritableHwm, options) {
|
|
const t = new Transform(options);
|
|
assert.strictEqual(t._readableState.highWaterMark, expectedReadableHwm);
|
|
assert.strictEqual(t._writableState.highWaterMark, expectedWritableHwm);
|
|
}
|
|
|
|
// Test overriding defaultHwm
|
|
testTransform(666, DEFAULT, { readableHighWaterMark: 666 });
|
|
testTransform(DEFAULT, 777, { writableHighWaterMark: 777 });
|
|
testTransform(666, 777, {
|
|
readableHighWaterMark: 666,
|
|
writableHighWaterMark: 777,
|
|
});
|
|
|
|
// test 0 overriding defaultHwm
|
|
testTransform(0, DEFAULT, { readableHighWaterMark: 0 });
|
|
testTransform(DEFAULT, 0, { writableHighWaterMark: 0 });
|
|
|
|
// Test highWaterMark overriding
|
|
testTransform(555, 555, {
|
|
highWaterMark: 555,
|
|
readableHighWaterMark: 666,
|
|
});
|
|
testTransform(555, 555, {
|
|
highWaterMark: 555,
|
|
writableHighWaterMark: 777,
|
|
});
|
|
testTransform(555, 555, {
|
|
highWaterMark: 555,
|
|
readableHighWaterMark: 666,
|
|
writableHighWaterMark: 777,
|
|
});
|
|
|
|
// Test highWaterMark = 0 overriding
|
|
testTransform(0, 0, {
|
|
highWaterMark: 0,
|
|
readableHighWaterMark: 666,
|
|
});
|
|
testTransform(0, 0, {
|
|
highWaterMark: 0,
|
|
writableHighWaterMark: 777,
|
|
});
|
|
testTransform(0, 0, {
|
|
highWaterMark: 0,
|
|
readableHighWaterMark: 666,
|
|
writableHighWaterMark: 777,
|
|
});
|
|
|
|
// Test undefined, null
|
|
[undefined, null].forEach((v) => {
|
|
testTransform(DEFAULT, DEFAULT, { readableHighWaterMark: v });
|
|
testTransform(DEFAULT, DEFAULT, { writableHighWaterMark: v });
|
|
testTransform(666, DEFAULT, { highWaterMark: v, readableHighWaterMark: 666 });
|
|
testTransform(DEFAULT, 777, { highWaterMark: v, writableHighWaterMark: 777 });
|
|
});
|
|
|
|
// test NaN
|
|
{
|
|
assert.throws(() => {
|
|
new Transform({ readableHighWaterMark: NaN });
|
|
}, {
|
|
name: 'TypeError',
|
|
code: 'ERR_INVALID_OPT_VALUE',
|
|
message: 'The value "NaN" is invalid for option "readableHighWaterMark"'
|
|
});
|
|
|
|
assert.throws(() => {
|
|
new Transform({ writableHighWaterMark: NaN });
|
|
}, {
|
|
name: 'TypeError',
|
|
code: 'ERR_INVALID_OPT_VALUE',
|
|
message: 'The value "NaN" is invalid for option "writableHighWaterMark"'
|
|
});
|
|
}
|
|
|
|
// Test non Duplex streams ignore the options
|
|
{
|
|
const r = new Readable({ readableHighWaterMark: 666 });
|
|
assert.strictEqual(r._readableState.highWaterMark, DEFAULT);
|
|
const w = new Writable({ writableHighWaterMark: 777 });
|
|
assert.strictEqual(w._writableState.highWaterMark, DEFAULT);
|
|
}
|