e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
43 lines
1.0 KiB
JavaScript
43 lines
1.0 KiB
JavaScript
'use strict';
|
|
|
|
// Flags: --experimental-vm-modules
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const { SourceTextModule } = require('vm');
|
|
|
|
async function testBasic() {
|
|
const m = new SourceTextModule('import.meta;', {
|
|
initializeImportMeta: common.mustCall((meta, module) => {
|
|
assert.strictEqual(module, m);
|
|
meta.prop = 42;
|
|
})
|
|
});
|
|
await m.link(common.mustNotCall());
|
|
const { result } = await m.evaluate();
|
|
assert.strictEqual(typeof result, 'object');
|
|
assert.strictEqual(Object.getPrototypeOf(result), null);
|
|
assert.strictEqual(result.prop, 42);
|
|
assert.deepStrictEqual(Reflect.ownKeys(result), ['prop']);
|
|
}
|
|
|
|
async function testInvalid() {
|
|
for (const invalidValue of [
|
|
null, {}, 0, Symbol.iterator, [], 'string', false
|
|
]) {
|
|
assert.throws(() => {
|
|
new SourceTextModule('', {
|
|
initializeImportMeta: invalidValue
|
|
});
|
|
}, {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError'
|
|
});
|
|
}
|
|
}
|
|
|
|
(async () => {
|
|
await testBasic();
|
|
await testInvalid();
|
|
})();
|