e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
70 lines
2.3 KiB
JavaScript
70 lines
2.3 KiB
JavaScript
'use strict';
|
|
|
|
// Tests below are not from WPT.
|
|
|
|
require('../common');
|
|
const assert = require('assert');
|
|
const URLSearchParams = require('url').URLSearchParams;
|
|
|
|
function makeIterableFunc(array) {
|
|
return Object.assign(() => {}, {
|
|
[Symbol.iterator]() {
|
|
return array[Symbol.iterator]();
|
|
}
|
|
});
|
|
}
|
|
|
|
{
|
|
const iterableError = {
|
|
code: 'ERR_ARG_NOT_ITERABLE',
|
|
name: 'TypeError',
|
|
message: 'Query pairs must be iterable'
|
|
};
|
|
const tupleError = {
|
|
code: 'ERR_INVALID_TUPLE',
|
|
name: 'TypeError',
|
|
message: 'Each query pair must be an iterable [name, value] tuple'
|
|
};
|
|
|
|
let params;
|
|
params = new URLSearchParams(undefined);
|
|
assert.strictEqual(params.toString(), '');
|
|
params = new URLSearchParams(null);
|
|
assert.strictEqual(params.toString(), '');
|
|
params = new URLSearchParams(
|
|
makeIterableFunc([['key', 'val'], ['key2', 'val2']])
|
|
);
|
|
assert.strictEqual(params.toString(), 'key=val&key2=val2');
|
|
params = new URLSearchParams(
|
|
makeIterableFunc([['key', 'val'], ['key2', 'val2']].map(makeIterableFunc))
|
|
);
|
|
assert.strictEqual(params.toString(), 'key=val&key2=val2');
|
|
assert.throws(() => new URLSearchParams([[1]]), tupleError);
|
|
assert.throws(() => new URLSearchParams([[1, 2, 3]]), tupleError);
|
|
assert.throws(() => new URLSearchParams({ [Symbol.iterator]: 42 }),
|
|
iterableError);
|
|
assert.throws(() => new URLSearchParams([{}]), tupleError);
|
|
assert.throws(() => new URLSearchParams(['a']), tupleError);
|
|
assert.throws(() => new URLSearchParams([null]), tupleError);
|
|
assert.throws(() => new URLSearchParams([{ [Symbol.iterator]: 42 }]),
|
|
tupleError);
|
|
}
|
|
|
|
{
|
|
const obj = {
|
|
toString() { throw new Error('toString'); },
|
|
valueOf() { throw new Error('valueOf'); }
|
|
};
|
|
const sym = Symbol();
|
|
const toStringError = /^Error: toString$/;
|
|
const symbolError = /^TypeError: Cannot convert a Symbol value to a string$/;
|
|
|
|
assert.throws(() => new URLSearchParams({ a: obj }), toStringError);
|
|
assert.throws(() => new URLSearchParams([['a', obj]]), toStringError);
|
|
assert.throws(() => new URLSearchParams(sym), symbolError);
|
|
assert.throws(() => new URLSearchParams({ [sym]: 'a' }), symbolError);
|
|
assert.throws(() => new URLSearchParams({ a: sym }), symbolError);
|
|
assert.throws(() => new URLSearchParams([[sym, 'a']]), symbolError);
|
|
assert.throws(() => new URLSearchParams([['a', sym]]), symbolError);
|
|
}
|