92e95f17b6
- Remove `NativeModule._source` - the compilation is now entirely
done in C++ and `process.binding('natives')` is implemented
directly in the binding loader so there is no need to store
additional source code strings.
- Instead of using an object as `NativeModule._cached` and insert
into it after compilation of each native module, simply prebuild
a JS map filled with all the native modules and infer the
state of compilation through `mod.loading`/`mod.loaded`.
- Rename `NativeModule.nonInternalExists` to
`NativeModule.canBeRequiredByUsers` and precompute that
property for all the native modules during bootstrap instead
of branching in every require call during runtime. This also fixes
the bug where `worker_threads` can be made available with
`--expose-internals`.
- Rename `NativeModule.requireForDeps` to
`NativeModule.requireWithFallbackInDeps`.
- Add a test to make sure we do not accidentally leak any module
to the global namespace.
PR-URL: https://github.com/nodejs/node/pull/25352
Reviewed-By: Anna Henningsen <anna@addaleax.net>
72 lines
2.2 KiB
JavaScript
72 lines
2.2 KiB
JavaScript
'use strict';
|
|
|
|
// Flags: --expose-internals
|
|
// This test verifies that if the binary is compiled with code cache,
|
|
// and the cache is used when built in modules are compiled.
|
|
// Otherwise, verifies that no cache is used when compiling builtins.
|
|
|
|
const { isMainThread } = require('../common');
|
|
const assert = require('assert');
|
|
const {
|
|
cachableBuiltins,
|
|
cannotUseCache
|
|
} = require('internal/bootstrap/cache');
|
|
|
|
const {
|
|
internalBinding
|
|
} = require('internal/test/binding');
|
|
const {
|
|
getCacheUsage
|
|
} = internalBinding('native_module');
|
|
|
|
for (const key of cachableBuiltins) {
|
|
if (!isMainThread && key === 'trace_events') {
|
|
continue; // Cannot load trace_events in workers
|
|
}
|
|
require(key);
|
|
}
|
|
|
|
// The computation has to be delayed until we have done loading modules
|
|
const {
|
|
compiledWithoutCache,
|
|
compiledWithCache
|
|
} = getCacheUsage();
|
|
|
|
const loadedModules = process.moduleLoadList
|
|
.filter((m) => m.startsWith('NativeModule'))
|
|
.map((m) => m.replace('NativeModule ', ''));
|
|
|
|
// The binary is not configured with code cache, verifies that the builtins
|
|
// are all compiled without cache and we are doing the bookkeeping right.
|
|
if (process.config.variables.node_code_cache_path === undefined) {
|
|
console.log('The binary is not configured with code cache');
|
|
if (isMainThread) {
|
|
assert.deepStrictEqual(compiledWithCache, new Set());
|
|
for (const key of loadedModules) {
|
|
assert(compiledWithoutCache.has(key),
|
|
`"${key}" should've been compiled without code cache`);
|
|
}
|
|
} else {
|
|
// TODO(joyeecheung): create a list of modules whose cache can be shared
|
|
// from the main thread to the worker thread and check that their
|
|
// cache are hit
|
|
assert.notDeepStrictEqual(compiledWithCache, new Set());
|
|
}
|
|
} else {
|
|
console.log('The binary is configured with code cache');
|
|
assert.strictEqual(
|
|
typeof process.config.variables.node_code_cache_path,
|
|
'string'
|
|
);
|
|
|
|
for (const key of loadedModules) {
|
|
if (cannotUseCache.includes(key)) {
|
|
assert(compiledWithoutCache.has(key),
|
|
`"${key}" should've been compiled without code cache`);
|
|
} else {
|
|
assert(compiledWithCache.has(key),
|
|
`"${key}" should've been compiled with code cache`);
|
|
}
|
|
}
|
|
}
|