1berry/obs-studio
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

libobs/callback: Catch fail cases with missing error data

Browse Source 
In `parse_decl_string`, it jumps to `fail` label if an error occurs.
However, if the lexer encountered an error for example, `cfp.error_list`
may be empty.
This commit is contained in:
Norihiro Kamae 2025-04-01 13:45:29 +09:00 committed by Ryan Foster
parent a19945b53a
commit 220b0ec649
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libobs/callback/decl.c
View File

@ -182,7 +182,7 @@ bool parse_decl_string(struct decl_info *decl, const char *decl_string)
struct strref ret_type;
struct decl_param ret_param = {0};
int code;
bool success;
bool success = false;
decl->decl_string = decl_string;
ret_param.flags = CALL_PARAM_OUT;
@ -210,9 +210,11 @@ bool parse_decl_string(struct decl_info *decl, const char *decl_string)
goto fail;
parse_params(&cfp, decl);
success = true;
fail:
success = !error_data_has_errors(&cfp.error_list);
if (error_data_has_errors(&cfp.error_list))
success = false;
if (success && ret_param.type != CALL_PARAM_TYPE_VOID) {
ret_param.name = bstrdup("return");