This commit is contained in:
J. Duke 2017-07-05 16:45:00 +02:00
commit 00ae5656cd
66 changed files with 1543 additions and 545 deletions

View File

@ -16,3 +16,4 @@ cc47a76899ed33a2c513cb688348244c9b5a1288 jdk7-b38
ab523b49de1fc73fefe6855ce1e0349bdbd7af29 jdk7-b39 ab523b49de1fc73fefe6855ce1e0349bdbd7af29 jdk7-b39
44be42de6693063fb191989bf0e188de2fa51e7c jdk7-b40 44be42de6693063fb191989bf0e188de2fa51e7c jdk7-b40
541bdc5ad32fc33255944d0a044ad992f3d915e8 jdk7-b41 541bdc5ad32fc33255944d0a044ad992f3d915e8 jdk7-b41
94052b87287303527125026fe4b2698cf867ea83 jdk7-b42

View File

@ -16,3 +16,4 @@ d9bc824aa078573829bb66572af847e26e1bd12e jdk7-b38
49ca90d77f34571b0757ebfcb8a7848ef2696b88 jdk7-b39 49ca90d77f34571b0757ebfcb8a7848ef2696b88 jdk7-b39
81a0cbe3b28460ce836109934ece03db7afaf9cc jdk7-b40 81a0cbe3b28460ce836109934ece03db7afaf9cc jdk7-b40
f9d938ede1960d18cb7cf23c645b026519c1a678 jdk7-b41 f9d938ede1960d18cb7cf23c645b026519c1a678 jdk7-b41
ad8c8ca4ab0f4c86e74c061958f44a8f4a930f2c jdk7-b42

View File

@ -35,7 +35,7 @@ HOTSPOT_VM_COPYRIGHT=Copyright 2008
HS_MAJOR_VER=14 HS_MAJOR_VER=14
HS_MINOR_VER=0 HS_MINOR_VER=0
HS_BUILD_NUMBER=09 HS_BUILD_NUMBER=10
JDK_MAJOR_VER=1 JDK_MAJOR_VER=1
JDK_MINOR_VER=7 JDK_MINOR_VER=7

View File

@ -7,5 +7,13 @@
# #
# adlc-updater <file> <source-dir> <target-dir> # adlc-updater <file> <source-dir> <target-dir>
# #
[ -f $3/$1 ] && cmp -s $2/$1 $3/$1 || \ fix_lines() {
( [ -f $3/$1 ]; echo Updating $3/$1 ; touch $2/made-change ; mv $2/$1 $3/$1 ) # repair bare #line directives in $1 to refer to $2
awk < $1 > $1+ '
/^#line 999999$/ {print "#line " (NR+1) " \"" F2 "\""; next}
{print}
' F2=$2
mv $1+ $1
}
[ -f $3/$1 ] && (fix_lines $2/$1 $3/$1; cmp -s $2/$1 $3/$1) || \
( [ -f $3/$1 ] && echo Updating $3/$1 ; touch $2/made-change ; mv $2/$1 $3/$1 )

View File

@ -54,10 +54,12 @@ VPATH += $(Src_Dirs_V:%=%:)
Src_Dirs_I = ${Src_Dirs} $(GENERATED) Src_Dirs_I = ${Src_Dirs} $(GENERATED)
INCLUDES += $(Src_Dirs_I:%=-I%) INCLUDES += $(Src_Dirs_I:%=-I%)
# Force assertions on. # set flags for adlc compilation
SYSDEFS += -DASSERT
CPPFLAGS = $(SYSDEFS) $(INCLUDES) CPPFLAGS = $(SYSDEFS) $(INCLUDES)
# Force assertions on.
CPPFLAGS += -DASSERT
# CFLAGS_WARN holds compiler options to suppress/enable warnings. # CFLAGS_WARN holds compiler options to suppress/enable warnings.
# Suppress warnings (for now) # Suppress warnings (for now)
CFLAGS_WARN = -w CFLAGS_WARN = -w
@ -125,7 +127,15 @@ $(GENERATEDFILES): refresh_adfiles
# Note that product files are updated via "mv", which is atomic. # Note that product files are updated via "mv", which is atomic.
TEMPDIR := $(OUTDIR)/mktmp$(shell echo $$$$) TEMPDIR := $(OUTDIR)/mktmp$(shell echo $$$$)
ADLCFLAGS = -q -T # Pass -D flags into ADLC.
ADLCFLAGS += $(SYSDEFS)
# Note "+="; it is a hook so flags.make can add more flags, like -g or -DFOO.
ADLCFLAGS += -q -T
# Normally, debugging is done directly on the ad_<arch>*.cpp files.
# But -g will put #line directives in those files pointing back to <arch>.ad.
#ADLCFLAGS += -g
ifdef LP64 ifdef LP64
ADLCFLAGS += -D_LP64 ADLCFLAGS += -D_LP64
@ -140,6 +150,8 @@ endif
# #
ADLC_UPDATER_DIRECTORY = $(GAMMADIR)/make/$(OS) ADLC_UPDATER_DIRECTORY = $(GAMMADIR)/make/$(OS)
ADLC_UPDATER = adlc_updater ADLC_UPDATER = adlc_updater
$(ADLC_UPDATER): $(ADLC_UPDATER_DIRECTORY)/$(ADLC_UPDATER)
$(QUIETLY) cp $< $@; chmod +x $@
# This action refreshes all generated adlc files simultaneously. # This action refreshes all generated adlc files simultaneously.
# The way it works is this: # The way it works is this:
@ -149,9 +161,8 @@ ADLC_UPDATER = adlc_updater
# 4) call $(ADLC_UPDATER) on each generated adlc file. It will selectively update changed or missing files. # 4) call $(ADLC_UPDATER) on each generated adlc file. It will selectively update changed or missing files.
# 5) If we actually updated any files, echo a notice. # 5) If we actually updated any files, echo a notice.
# #
refresh_adfiles: $(EXEC) $(SOURCE.AD) refresh_adfiles: $(EXEC) $(SOURCE.AD) $(ADLC_UPDATER)
@rm -rf $(TEMPDIR); mkdir $(TEMPDIR) @rm -rf $(TEMPDIR); mkdir $(TEMPDIR)
$(QUIETLY) [ -f $(ADLC_UPDATER) ] || ( cp $(ADLC_UPDATER_DIRECTORY)/$(ADLC_UPDATER) . ; chmod +x $(ADLC_UPDATER) )
$(QUIETLY) $(EXEC) $(ADLCFLAGS) $(SOURCE.AD) \ $(QUIETLY) $(EXEC) $(ADLCFLAGS) $(SOURCE.AD) \
-c$(TEMPDIR)/ad_$(Platform_arch_model).cpp -h$(TEMPDIR)/ad_$(Platform_arch_model).hpp -a$(TEMPDIR)/dfa_$(Platform_arch_model).cpp -v$(TEMPDIR)/adGlobals_$(Platform_arch_model).hpp \ -c$(TEMPDIR)/ad_$(Platform_arch_model).cpp -h$(TEMPDIR)/ad_$(Platform_arch_model).hpp -a$(TEMPDIR)/dfa_$(Platform_arch_model).cpp -v$(TEMPDIR)/adGlobals_$(Platform_arch_model).hpp \
|| { rm -rf $(TEMPDIR); exit 1; } || { rm -rf $(TEMPDIR); exit 1; }
@ -174,7 +185,15 @@ refresh_adfiles: $(EXEC) $(SOURCE.AD)
# ######################################################################### # #########################################################################
$(SOURCE.AD): $(SOURCES.AD) $(SOURCE.AD): $(SOURCES.AD)
$(QUIETLY) cat $(SOURCES.AD) > $(SOURCE.AD) $(QUIETLY) $(PROCESS_AD_FILES) $(SOURCES.AD) > $(SOURCE.AD)
#PROCESS_AD_FILES = cat
# Pass through #line directives, in case user enables -g option above:
PROCESS_AD_FILES = awk '{ \
if (CUR_FN != FILENAME) { CUR_FN=FILENAME; NR_BASE=NR-1; need_lineno=1 } \
if (need_lineno && $$0 !~ /\/\//) \
{ print "\n\n\#line " (NR-NR_BASE) " \"" FILENAME "\""; need_lineno=0 }; \
print }'
$(OUTDIR)/%.o: %.cpp $(OUTDIR)/%.o: %.cpp
@echo Compiling $< @echo Compiling $<

View File

@ -7,5 +7,13 @@
# #
# adlc-updater <file> <source-dir> <target-dir> # adlc-updater <file> <source-dir> <target-dir>
# #
[ -f $3/$1 ] && cmp -s $2/$1 $3/$1 || \ fix_lines() {
( [ -f $3/$1 ]; echo Updating $3/$1 ; touch $2/made-change ; mv $2/$1 $3/$1 ) # repair bare #line directives in $1 to refer to $2
awk < $1 > $1+ '
/^#line 999999$/ {print "#line " (NR+1) " \"" F2 "\""; next}
{print}
' F2=$2
mv $1+ $1
}
[ -f $3/$1 ] && (fix_lines $2/$1 $3/$1; cmp -s $2/$1 $3/$1) || \
( [ -f $3/$1 ] && echo Updating $3/$1 ; touch $2/made-change ; mv $2/$1 $3/$1 )

View File

@ -54,10 +54,12 @@ VPATH += $(Src_Dirs_V:%=%:)
Src_Dirs_I = ${Src_Dirs} $(GENERATED) Src_Dirs_I = ${Src_Dirs} $(GENERATED)
INCLUDES += $(Src_Dirs_I:%=-I%) INCLUDES += $(Src_Dirs_I:%=-I%)
# Force assertions on. # set flags for adlc compilation
SYSDEFS += -DASSERT
CPPFLAGS = $(SYSDEFS) $(INCLUDES) CPPFLAGS = $(SYSDEFS) $(INCLUDES)
# Force assertions on.
CPPFLAGS += -DASSERT
ifndef USE_GCC ifndef USE_GCC
# We need libCstd.so for adlc # We need libCstd.so for adlc
CFLAGS += -library=Cstd -g CFLAGS += -library=Cstd -g
@ -141,7 +143,15 @@ $(GENERATEDFILES): refresh_adfiles
# Note that product files are updated via "mv", which is atomic. # Note that product files are updated via "mv", which is atomic.
TEMPDIR := $(OUTDIR)/mktmp$(shell echo $$$$) TEMPDIR := $(OUTDIR)/mktmp$(shell echo $$$$)
ADLCFLAGS = -q -T # Pass -D flags into ADLC.
ADLCFLAGS += $(SYSDEFS)
# Note "+="; it is a hook so flags.make can add more flags, like -g or -DFOO.
ADLCFLAGS += -q -T
# Normally, debugging is done directly on the ad_<arch>*.cpp files.
# But -g will put #line directives in those files pointing back to <arch>.ad.
#ADLCFLAGS += -g
ifdef LP64 ifdef LP64
ADLCFLAGS += -D_LP64 ADLCFLAGS += -D_LP64
@ -156,6 +166,8 @@ endif
# #
ADLC_UPDATER_DIRECTORY = $(GAMMADIR)/make/$(OS) ADLC_UPDATER_DIRECTORY = $(GAMMADIR)/make/$(OS)
ADLC_UPDATER = adlc_updater ADLC_UPDATER = adlc_updater
$(ADLC_UPDATER): $(ADLC_UPDATER_DIRECTORY)/$(ADLC_UPDATER)
$(QUIETLY) cp $< $@; chmod +x $@
# This action refreshes all generated adlc files simultaneously. # This action refreshes all generated adlc files simultaneously.
# The way it works is this: # The way it works is this:
@ -165,9 +177,8 @@ ADLC_UPDATER = adlc_updater
# 4) call $(ADLC_UPDATER) on each generated adlc file. It will selectively update changed or missing files. # 4) call $(ADLC_UPDATER) on each generated adlc file. It will selectively update changed or missing files.
# 5) If we actually updated any files, echo a notice. # 5) If we actually updated any files, echo a notice.
# #
refresh_adfiles: $(EXEC) $(SOURCE.AD) refresh_adfiles: $(EXEC) $(SOURCE.AD) $(ADLC_UPDATER)
@rm -rf $(TEMPDIR); mkdir $(TEMPDIR) @rm -rf $(TEMPDIR); mkdir $(TEMPDIR)
$(QUIETLY) [ -f $(ADLC_UPDATER) ] || ( cp $(ADLC_UPDATER_DIRECTORY)/$(ADLC_UPDATER) . ; chmod +x $(ADLC_UPDATER) )
$(QUIETLY) $(EXEC) $(ADLCFLAGS) $(SOURCE.AD) \ $(QUIETLY) $(EXEC) $(ADLCFLAGS) $(SOURCE.AD) \
-c$(TEMPDIR)/ad_$(Platform_arch_model).cpp -h$(TEMPDIR)/ad_$(Platform_arch_model).hpp -a$(TEMPDIR)/dfa_$(Platform_arch_model).cpp -v$(TEMPDIR)/adGlobals_$(Platform_arch_model).hpp \ -c$(TEMPDIR)/ad_$(Platform_arch_model).cpp -h$(TEMPDIR)/ad_$(Platform_arch_model).hpp -a$(TEMPDIR)/dfa_$(Platform_arch_model).cpp -v$(TEMPDIR)/adGlobals_$(Platform_arch_model).hpp \
|| { rm -rf $(TEMPDIR); exit 1; } || { rm -rf $(TEMPDIR); exit 1; }
@ -190,7 +201,15 @@ refresh_adfiles: $(EXEC) $(SOURCE.AD)
# ######################################################################### # #########################################################################
$(SOURCE.AD): $(SOURCES.AD) $(SOURCE.AD): $(SOURCES.AD)
$(QUIETLY) cat $(SOURCES.AD) > $(SOURCE.AD) $(QUIETLY) $(PROCESS_AD_FILES) $(SOURCES.AD) > $(SOURCE.AD)
#PROCESS_AD_FILES = cat
# Pass through #line directives, in case user enables -g option above:
PROCESS_AD_FILES = awk '{ \
if (CUR_FN != FILENAME) { CUR_FN=FILENAME; NR_BASE=NR-1; need_lineno=1 } \
if (need_lineno && $$0 !~ /\/\//) \
{ print "\n\n\#line " (NR-NR_BASE) " \"" FILENAME "\""; need_lineno=0 }; \
print }'
$(OUTDIR)/%.o: %.cpp $(OUTDIR)/%.o: %.cpp
@echo Compiling $< @echo Compiling $<

View File

@ -2500,7 +2500,7 @@ bool os::guard_memory(char* addr, size_t size) {
} }
bool os::unguard_memory(char* addr, size_t size) { bool os::unguard_memory(char* addr, size_t size) {
return linux_mprotect(addr, size, PROT_READ|PROT_WRITE|PROT_EXEC); return linux_mprotect(addr, size, PROT_READ|PROT_WRITE);
} }
// Large page support // Large page support

View File

@ -1638,16 +1638,24 @@ inline hrtime_t oldgetTimeNanos() {
// getTimeNanos is guaranteed to not move backward on Solaris // getTimeNanos is guaranteed to not move backward on Solaris
inline hrtime_t getTimeNanos() { inline hrtime_t getTimeNanos() {
if (VM_Version::supports_cx8()) { if (VM_Version::supports_cx8()) {
bool retry = false; const hrtime_t now = gethrtime();
hrtime_t newtime = gethrtime(); const hrtime_t prev = max_hrtime;
hrtime_t oldmaxtime = max_hrtime; if (now <= prev) return prev; // same or retrograde time;
hrtime_t retmaxtime = oldmaxtime; const hrtime_t obsv = Atomic::cmpxchg(now, (volatile jlong*)&max_hrtime, prev);
while ((newtime > retmaxtime) && (retry == false || retmaxtime != oldmaxtime)) { assert(obsv >= prev, "invariant"); // Monotonicity
oldmaxtime = retmaxtime; // If the CAS succeeded then we're done and return "now".
retmaxtime = Atomic::cmpxchg(newtime, (volatile jlong *)&max_hrtime, oldmaxtime); // If the CAS failed and the observed value "obs" is >= now then
retry = true; // we should return "obs". If the CAS failed and now > obs > prv then
} // some other thread raced this thread and installed a new value, in which case
return (newtime > retmaxtime) ? newtime : retmaxtime; // we could either (a) retry the entire operation, (b) retry trying to install now
// or (c) just return obs. We use (c). No loop is required although in some cases
// we might discard a higher "now" value in deference to a slightly lower but freshly
// installed obs value. That's entirely benign -- it admits no new orderings compared
// to (a) or (b) -- and greatly reduces coherence traffic.
// We might also condition (c) on the magnitude of the delta between obs and now.
// Avoiding excessive CAS operations to hot RW locations is critical.
// See http://blogs.sun.com/dave/entry/cas_and_cache_trivia_invalidate
return (prev == obsv) ? now : obsv ;
} else { } else {
return oldgetTimeNanos(); return oldgetTimeNanos();
} }
@ -3026,6 +3034,8 @@ static bool solaris_mprotect(char* addr, size_t bytes, int prot) {
// Protect memory (Used to pass readonly pages through // Protect memory (Used to pass readonly pages through
// JNI GetArray<type>Elements with empty arrays.) // JNI GetArray<type>Elements with empty arrays.)
// Also, used for serialization page and for compressed oops null pointer
// checking.
bool os::protect_memory(char* addr, size_t bytes, ProtType prot, bool os::protect_memory(char* addr, size_t bytes, ProtType prot,
bool is_committed) { bool is_committed) {
unsigned int p = 0; unsigned int p = 0;
@ -3049,7 +3059,7 @@ bool os::guard_memory(char* addr, size_t bytes) {
} }
bool os::unguard_memory(char* addr, size_t bytes) { bool os::unguard_memory(char* addr, size_t bytes) {
return solaris_mprotect(addr, bytes, PROT_READ|PROT_WRITE|PROT_EXEC); return solaris_mprotect(addr, bytes, PROT_READ|PROT_WRITE);
} }
// Large page support // Large page support

View File

@ -2020,10 +2020,11 @@ LONG WINAPI topLevelExceptionFilter(struct _EXCEPTION_POINTERS* exceptionInfo) {
if (UnguardOnExecutionViolation > 0 && addr != last_addr && if (UnguardOnExecutionViolation > 0 && addr != last_addr &&
(UnguardOnExecutionViolation > 1 || os::address_is_in_vm(addr))) { (UnguardOnExecutionViolation > 1 || os::address_is_in_vm(addr))) {
// Unguard and retry // Set memory to RWX and retry
address page_start = address page_start =
(address) align_size_down((intptr_t) addr, (intptr_t) page_size); (address) align_size_down((intptr_t) addr, (intptr_t) page_size);
bool res = os::unguard_memory((char*) page_start, page_size); bool res = os::protect_memory((char*) page_start, page_size,
os::MEM_PROT_RWX);
if (PrintMiscellaneous && Verbose) { if (PrintMiscellaneous && Verbose) {
char buf[256]; char buf[256];
@ -2755,12 +2756,12 @@ bool os::protect_memory(char* addr, size_t bytes, ProtType prot,
bool os::guard_memory(char* addr, size_t bytes) { bool os::guard_memory(char* addr, size_t bytes) {
DWORD old_status; DWORD old_status;
return VirtualProtect(addr, bytes, PAGE_EXECUTE_READWRITE | PAGE_GUARD, &old_status) != 0; return VirtualProtect(addr, bytes, PAGE_READWRITE | PAGE_GUARD, &old_status) != 0;
} }
bool os::unguard_memory(char* addr, size_t bytes) { bool os::unguard_memory(char* addr, size_t bytes) {
DWORD old_status; DWORD old_status;
return VirtualProtect(addr, bytes, PAGE_EXECUTE_READWRITE, &old_status) != 0; return VirtualProtect(addr, bytes, PAGE_READWRITE, &old_status) != 0;
} }
void os::realign_memory(char *addr, size_t bytes, size_t alignment_hint) { } void os::realign_memory(char *addr, size_t bytes, size_t alignment_hint) { }

View File

@ -422,10 +422,11 @@ JVM_handle_linux_signal(int sig,
if (addr != last_addr && if (addr != last_addr &&
(UnguardOnExecutionViolation > 1 || os::address_is_in_vm(addr))) { (UnguardOnExecutionViolation > 1 || os::address_is_in_vm(addr))) {
// Unguard and retry // Set memory to RWX and retry
address page_start = address page_start =
(address) align_size_down((intptr_t) addr, (intptr_t) page_size); (address) align_size_down((intptr_t) addr, (intptr_t) page_size);
bool res = os::unguard_memory((char*) page_start, page_size); bool res = os::protect_memory((char*) page_start, page_size,
os::MEM_PROT_RWX);
if (PrintMiscellaneous && Verbose) { if (PrintMiscellaneous && Verbose) {
char buf[256]; char buf[256];

View File

@ -203,10 +203,10 @@ frame os::get_sender_for_C_frame(frame* fr) {
return frame(fr->sender_sp(), fr->link(), fr->sender_pc()); return frame(fr->sender_sp(), fr->link(), fr->sender_pc());
} }
extern "C" intptr_t *_get_previous_fp(); // in .il file. extern "C" intptr_t *_get_current_fp(); // in .il file
frame os::current_frame() { frame os::current_frame() {
intptr_t* fp = _get_previous_fp(); intptr_t* fp = _get_current_fp(); // it's inlined so want current fp
frame myframe((intptr_t*)os::current_stack_pointer(), frame myframe((intptr_t*)os::current_stack_pointer(),
(intptr_t*)fp, (intptr_t*)fp,
CAST_FROM_FN_PTR(address, os::current_frame)); CAST_FROM_FN_PTR(address, os::current_frame));
@ -576,10 +576,11 @@ int JVM_handle_solaris_signal(int sig, siginfo_t* info, void* ucVoid, int abort_
if (addr != last_addr && if (addr != last_addr &&
(UnguardOnExecutionViolation > 1 || os::address_is_in_vm(addr))) { (UnguardOnExecutionViolation > 1 || os::address_is_in_vm(addr))) {
// Unguard and retry // Make memory rwx and retry
address page_start = address page_start =
(address) align_size_down((intptr_t) addr, (intptr_t) page_size); (address) align_size_down((intptr_t) addr, (intptr_t) page_size);
bool res = os::unguard_memory((char*) page_start, page_size); bool res = os::protect_memory((char*) page_start, page_size,
os::MEM_PROT_RWX);
if (PrintMiscellaneous && Verbose) { if (PrintMiscellaneous && Verbose) {
char buf[256]; char buf[256];

View File

@ -37,10 +37,10 @@
movl %gs:0, %eax movl %gs:0, %eax
.end .end
// Get callers fp // Get current fp
.inline _get_previous_fp,0 .inline _get_current_fp,0
.volatile
movl %ebp, %eax movl %ebp, %eax
movl %eax, %eax
.end .end
// Support for jint Atomic::add(jint inc, volatile jint* dest) // Support for jint Atomic::add(jint inc, volatile jint* dest)

View File

@ -30,10 +30,10 @@
movq %fs:0, %rax movq %fs:0, %rax
.end .end
// Get the frame pointer from previous frame. // Get the frame pointer from current frame.
.inline _get_previous_fp,0 .inline _get_current_fp,0
.volatile
movq %rbp, %rax movq %rbp, %rax
movq %rax, %rax
.end .end
// Support for jint Atomic::add(jint add_value, volatile jint* dest) // Support for jint Atomic::add(jint add_value, volatile jint* dest)

View File

@ -108,6 +108,7 @@ void ADLParser::parse() {
else if (!strcmp(ident, "pipeline")) pipe_parse(); else if (!strcmp(ident, "pipeline")) pipe_parse();
else if (!strcmp(ident, "definitions")) definitions_parse(); else if (!strcmp(ident, "definitions")) definitions_parse();
else if (!strcmp(ident, "peephole")) peep_parse(); else if (!strcmp(ident, "peephole")) peep_parse();
else if (!strcmp(ident, "#line")) preproc_line();
else if (!strcmp(ident, "#define")) preproc_define(); else if (!strcmp(ident, "#define")) preproc_define();
else if (!strcmp(ident, "#undef")) preproc_undef(); else if (!strcmp(ident, "#undef")) preproc_undef();
else { else {
@ -787,8 +788,10 @@ void ADLParser::reg_parse(void) {
return; return;
} }
if (strcmp(token,"reg_def")==0) { reg_def_parse(); } if (strcmp(token,"reg_def")==0) { reg_def_parse(); }
if (strcmp(token,"reg_class")==0) { reg_class_parse(); } else if (strcmp(token,"reg_class")==0) { reg_class_parse(); }
if (strcmp(token,"alloc_class")==0) { alloc_class_parse(); } else if (strcmp(token,"alloc_class")==0) { alloc_class_parse(); }
else if (strcmp(token,"#define")==0) { preproc_define(); }
else { parse_err(SYNERR, "bad token %s inside register block.\n", token); break; }
skipws(); skipws();
} }
} }
@ -903,11 +906,7 @@ void ADLParser::enc_class_parse_block(EncClass* encoding, char* ec_name) {
skipws_no_preproc(); // Skip leading whitespace skipws_no_preproc(); // Skip leading whitespace
// Prepend location descriptor, for debugging; cf. ADLParser::find_cpp_block // Prepend location descriptor, for debugging; cf. ADLParser::find_cpp_block
if (_AD._adlocation_debug) { if (_AD._adlocation_debug) {
const char* file = _AD._ADL_file._name; encoding->add_code(get_line_string());
int line = linenum();
char* location = (char *)malloc(strlen(file) + 100);
sprintf(location, "#line %d \"%s\"\n", line, file);
encoding->add_code(location);
} }
// Collect the parts of the encode description // Collect the parts of the encode description
@ -948,6 +947,10 @@ void ADLParser::enc_class_parse_block(EncClass* encoding, char* ec_name) {
skipws(); skipws();
if (_AD._adlocation_debug) {
encoding->add_code(end_line_marker());
}
// Debug Stuff // Debug Stuff
if (_AD._adl_debug > 1) fprintf(stderr,"EncodingClass Form: %s\n", ec_name); if (_AD._adl_debug > 1) fprintf(stderr,"EncodingClass Form: %s\n", ec_name);
} }
@ -2349,7 +2352,11 @@ void ADLParser::reg_class_parse(void) {
return; return;
} }
RegDef *regDef = _AD._register->getRegDef(rname); RegDef *regDef = _AD._register->getRegDef(rname);
if (!regDef) {
parse_err(SEMERR, "unknown identifier %s inside reg_class list.\n", rname);
} else {
reg_class->addReg(regDef); // add regDef to regClass reg_class->addReg(regDef); // add regDef to regClass
}
// Check for ',' and position to next token. // Check for ',' and position to next token.
skipws(); skipws();
@ -2746,7 +2753,8 @@ Predicate *ADLParser::pred_parse(void) {
char *rule = NULL; // String representation of predicate char *rule = NULL; // String representation of predicate
skipws(); // Skip leading whitespace skipws(); // Skip leading whitespace
if ( (rule = get_paren_expr("pred expression")) == NULL ) { int line = linenum();
if ( (rule = get_paren_expr("pred expression", true)) == NULL ) {
parse_err(SYNERR, "incorrect or missing expression for 'predicate'\n"); parse_err(SYNERR, "incorrect or missing expression for 'predicate'\n");
return NULL; return NULL;
} }
@ -3407,7 +3415,12 @@ FormatRule* ADLParser::format_parse(void) {
// Check if there is a string to pass through to output // Check if there is a string to pass through to output
char *start = _ptr; // Record start of the next string char *start = _ptr; // Record start of the next string
while ((_curchar != '$') && (_curchar != '"') && (_curchar != '%') && (_curchar != '\n')) { while ((_curchar != '$') && (_curchar != '"') && (_curchar != '%') && (_curchar != '\n')) {
if (_curchar == '\\') next_char(); // superquote if (_curchar == '\\') {
next_char(); // superquote
if ((_curchar == '$') || (_curchar == '%'))
// hack to avoid % escapes and warnings about undefined \ escapes
*(_ptr-1) = _curchar;
}
if (_curchar == '\n') parse_err(SYNERR, "newline in string"); // unimplemented! if (_curchar == '\n') parse_err(SYNERR, "newline in string"); // unimplemented!
next_char(); next_char();
} }
@ -3942,7 +3955,6 @@ char* ADLParser::find_cpp_block(const char* description) {
next_char(); // Skip block delimiter next_char(); // Skip block delimiter
skipws_no_preproc(); // Skip leading whitespace skipws_no_preproc(); // Skip leading whitespace
cppBlock = _ptr; // Point to start of expression cppBlock = _ptr; // Point to start of expression
const char* file = _AD._ADL_file._name;
int line = linenum(); int line = linenum();
next = _ptr + 1; next = _ptr + 1;
while(((_curchar != '%') || (*next != '}')) && (_curchar != '\0')) { while(((_curchar != '%') || (*next != '}')) && (_curchar != '\0')) {
@ -3958,16 +3970,17 @@ char* ADLParser::find_cpp_block(const char* description) {
_curchar = *_ptr; // Maintain invariant _curchar = *_ptr; // Maintain invariant
// Prepend location descriptor, for debugging. // Prepend location descriptor, for debugging.
char* location = (char *)malloc(strlen(file) + 100); if (_AD._adlocation_debug) {
*location = '\0'; char* location = get_line_string(line);
if (_AD._adlocation_debug) char* end_loc = end_line_marker();
sprintf(location, "#line %d \"%s\"\n", line, file); char* result = (char *)malloc(strlen(location) + strlen(cppBlock) + strlen(end_loc) + 1);
char* result = (char *)malloc(strlen(location) + strlen(cppBlock) + 1);
strcpy(result, location); strcpy(result, location);
strcat(result, cppBlock); strcat(result, cppBlock);
strcat(result, end_loc);
cppBlock = result; cppBlock = result;
free(location); free(location);
} }
}
return cppBlock; return cppBlock;
} }
@ -4036,13 +4049,26 @@ char* ADLParser::get_expr(const char *desc, const char *stop_chars) {
// Helper function around get_expr // Helper function around get_expr
// Sets _curchar to '(' so that get_paren_expr will search for a matching ')' // Sets _curchar to '(' so that get_paren_expr will search for a matching ')'
char *ADLParser::get_paren_expr(const char *description) { char *ADLParser::get_paren_expr(const char *description, bool include_location) {
int line = linenum();
if (_curchar != '(') // Escape if not valid starting position if (_curchar != '(') // Escape if not valid starting position
return NULL; return NULL;
next_char(); // Skip the required initial paren. next_char(); // Skip the required initial paren.
char *token2 = get_expr(description, ")"); char *token2 = get_expr(description, ")");
if (_curchar == ')') if (_curchar == ')')
next_char(); // Skip required final paren. next_char(); // Skip required final paren.
int junk = 0;
if (include_location && _AD._adlocation_debug && !is_int_token(token2, junk)) {
// Prepend location descriptor, for debugging.
char* location = get_line_string(line);
char* end_loc = end_line_marker();
char* result = (char *)malloc(strlen(location) + strlen(token2) + strlen(end_loc) + 1);
strcpy(result, location);
strcat(result, token2);
strcat(result, end_loc);
token2 = result;
free(location);
}
return token2; return token2;
} }
@ -4082,10 +4108,16 @@ char *ADLParser::get_ident_common(bool do_preproc) {
if (do_preproc && start != NULL) { if (do_preproc && start != NULL) {
const char* def = _AD.get_preproc_def(start); const char* def = _AD.get_preproc_def(start);
if (def != NULL && strcmp(def, start)) { if (def != NULL && strcmp(def, start)) {
const char* def2 = _AD.get_preproc_def(def); const char* def1 = def;
if (def2 != NULL && strcmp(def2, def)) { const char* def2 = _AD.get_preproc_def(def1);
parse_err(SYNERR, "unimplemented: using %s defined as %s => %s", // implement up to 2 levels of #define
start, def, def2); if (def2 != NULL && strcmp(def2, def1)) {
def = def2;
const char* def3 = _AD.get_preproc_def(def2);
if (def3 != NULL && strcmp(def3, def2) && strcmp(def3, def1)) {
parse_err(SYNERR, "unimplemented: using %s defined as %s => %s => %s",
start, def1, def2, def3);
}
} }
start = strdup(def); start = strdup(def);
} }
@ -4431,6 +4463,35 @@ void ADLParser::get_effectlist(FormDict &effects, FormDict &operands) {
} }
//-------------------------------preproc_line----------------------------------
// A "#line" keyword has been seen, so parse the rest of the line.
void ADLParser::preproc_line(void) {
int line = get_int();
skipws_no_preproc();
const char* file = NULL;
if (_curchar == '"') {
next_char(); // Move past the initial '"'
file = _ptr;
while (true) {
if (_curchar == '\n') {
parse_err(SYNERR, "missing '\"' at end of #line directive");
return;
}
if (_curchar == '"') {
*_ptr = '\0'; // Terminate the string
next_char();
skipws_no_preproc();
break;
}
next_char();
}
}
ensure_end_of_line();
if (file != NULL)
_AD._ADL_file._name = file;
_buf.set_linenum(line);
}
//------------------------------preproc_define--------------------------------- //------------------------------preproc_define---------------------------------
// A "#define" keyword has been seen, so parse the rest of the line. // A "#define" keyword has been seen, so parse the rest of the line.
void ADLParser::preproc_define(void) { void ADLParser::preproc_define(void) {
@ -4494,6 +4555,7 @@ void ADLParser::parse_err(int flag, const char *fmt, ...) {
// A preprocessor directive has been encountered. Be sure it has fallen at // A preprocessor directive has been encountered. Be sure it has fallen at
// the begining of a line, or else report an error. // the begining of a line, or else report an error.
void ADLParser::ensure_start_of_line(void) { void ADLParser::ensure_start_of_line(void) {
if (_curchar == '\n') { next_line(); return; }
assert( _ptr >= _curline && _ptr < _curline+strlen(_curline), assert( _ptr >= _curline && _ptr < _curline+strlen(_curline),
"Must be able to find which line we are in" ); "Must be able to find which line we are in" );
@ -4662,6 +4724,7 @@ char ADLParser::cur_char() {
//---------------------------next_char----------------------------------------- //---------------------------next_char-----------------------------------------
void ADLParser::next_char() { void ADLParser::next_char() {
if (_curchar == '\n') parse_err(WARN, "must call next_line!");
_curchar = *++_ptr; _curchar = *++_ptr;
// if ( _curchar == '\n' ) { // if ( _curchar == '\n' ) {
// next_line(); // next_line();
@ -4682,6 +4745,18 @@ void ADLParser::next_char_or_line() {
//---------------------------next_line----------------------------------------- //---------------------------next_line-----------------------------------------
void ADLParser::next_line() { void ADLParser::next_line() {
_curline = _buf.get_line(); _curline = _buf.get_line();
_curchar = ' ';
}
//------------------------get_line_string--------------------------------------
// Prepended location descriptor, for debugging.
// Must return a malloced string (that can be freed if desired).
char* ADLParser::get_line_string(int linenum) {
const char* file = _AD._ADL_file._name;
int line = linenum ? linenum : this->linenum();
char* location = (char *)malloc(strlen(file) + 100);
sprintf(location, "\n#line %d \"%s\"\n", line, file);
return location;
} }
//-------------------------is_literal_constant--------------------------------- //-------------------------is_literal_constant---------------------------------
@ -4722,6 +4797,66 @@ bool ADLParser::is_int_token(const char* token, int& intval) {
return true; return true;
} }
static const char* skip_expr_ws(const char* str) {
const char * cp = str;
while (cp[0]) {
if (cp[0] <= ' ') {
++cp;
} else if (cp[0] == '#') {
++cp;
while (cp[0] == ' ') ++cp;
assert(0 == strncmp(cp, "line", 4), "must be a #line directive");
const char* eol = strchr(cp, '\n');
assert(eol != NULL, "must find end of line");
if (eol == NULL) eol = cp + strlen(cp);
cp = eol;
} else {
break;
}
}
return cp;
}
//-----------------------equivalent_expressions--------------------------------
bool ADLParser::equivalent_expressions(const char* str1, const char* str2) {
if (str1 == str2)
return true;
else if (str1 == NULL || str2 == NULL)
return false;
const char* cp1 = str1;
const char* cp2 = str2;
char in_quote = '\0';
while (cp1[0] && cp2[0]) {
if (!in_quote) {
// skip spaces and/or cpp directives
const char* cp1a = skip_expr_ws(cp1);
const char* cp2a = skip_expr_ws(cp2);
if (cp1a > cp1 && cp2a > cp2) {
cp1 = cp1a; cp2 = cp2a;
continue;
}
if (cp1a > cp1 || cp2a > cp2) break; // fail
}
// match one non-space char
if (cp1[0] != cp2[0]) break; // fail
char ch = cp1[0];
cp1++; cp2++;
// watch for quotes
if (in_quote && ch == '\\') {
if (cp1[0] != cp2[0]) break; // fail
if (!cp1[0]) break;
cp1++; cp2++;
}
if (in_quote && ch == in_quote) {
in_quote = '\0';
} else if (!in_quote && (ch == '"' || ch == '\'')) {
in_quote = ch;
}
}
return (!cp1[0] && !cp2[0]);
}
//-------------------------------trim------------------------------------------ //-------------------------------trim------------------------------------------
void ADLParser::trim(char* &token) { void ADLParser::trim(char* &token) {
while (*token <= ' ') token++; while (*token <= ' ') token++;

View File

@ -93,6 +93,7 @@ protected:
void pipe_parse(void); // Parse pipeline section void pipe_parse(void); // Parse pipeline section
void definitions_parse(void); // Parse definitions section void definitions_parse(void); // Parse definitions section
void peep_parse(void); // Parse peephole rule definitions void peep_parse(void); // Parse peephole rule definitions
void preproc_line(void); // Parse a #line statement
void preproc_define(void); // Parse a #define statement void preproc_define(void); // Parse a #define statement
void preproc_undef(void); // Parse an #undef statement void preproc_undef(void); // Parse an #undef statement
@ -226,7 +227,7 @@ protected:
void get_effectlist(FormDict &effects, FormDict &operands); // Parse effect-operand pairs void get_effectlist(FormDict &effects, FormDict &operands); // Parse effect-operand pairs
// Return the contents of a parenthesized expression. // Return the contents of a parenthesized expression.
// Requires initial '(' and consumes final ')', which is replaced by '\0'. // Requires initial '(' and consumes final ')', which is replaced by '\0'.
char *get_paren_expr(const char *description); char *get_paren_expr(const char *description, bool include_location = false);
// Return expression up to next stop-char, which terminator replaces. // Return expression up to next stop-char, which terminator replaces.
// Does not require initial '('. Does not consume final stop-char. // Does not require initial '('. Does not consume final stop-char.
// Final stop-char is left in _curchar, but is also is replaced by '\0'. // Final stop-char is left in _curchar, but is also is replaced by '\0'.
@ -234,6 +235,11 @@ protected:
char *find_cpp_block(const char *description); // Parse a C++ code block char *find_cpp_block(const char *description); // Parse a C++ code block
// Issue parser error message & go to EOL // Issue parser error message & go to EOL
void parse_err(int flag, const char *fmt, ...); void parse_err(int flag, const char *fmt, ...);
// Create a location marker for this file and line.
char *get_line_string(int linenum = 0);
// Return a location marker which tells the C preprocessor to
// forget the previous location marker. (Requires awk postprocessing.)
char *end_line_marker() { return (char*)"\n#line 999999\n"; }
// Return pointer to current character // Return pointer to current character
inline char cur_char(void); inline char cur_char(void);
@ -268,5 +274,6 @@ public:
static bool is_literal_constant(const char *hex_string); static bool is_literal_constant(const char *hex_string);
static bool is_hex_digit(char digit); static bool is_hex_digit(char digit);
static bool is_int_token(const char* token, int& intval); static bool is_int_token(const char* token, int& intval);
static bool equivalent_expressions(const char* str1, const char* str2);
static void trim(char* &token); // trim leading & trailing spaces static void trim(char* &token); // trim leading & trailing spaces
}; };

View File

@ -140,7 +140,7 @@ bool MatchList::search(const char *opc, const char *res, const char *lch,
if ((rch == _rchild) || (rch && _rchild && !strcmp(rch, _rchild))) { if ((rch == _rchild) || (rch && _rchild && !strcmp(rch, _rchild))) {
char * predStr = get_pred(); char * predStr = get_pred();
char * prStr = pr?pr->_pred:NULL; char * prStr = pr?pr->_pred:NULL;
if ((prStr == predStr) || (prStr && predStr && !strcmp(prStr, predStr))) { if (ADLParser::equivalent_expressions(prStr, predStr)) {
return true; return true;
} }
} }

View File

@ -458,7 +458,7 @@ void ArchDesc::buildDFA(FILE* fp) {
class dfa_shared_preds { class dfa_shared_preds {
enum { count = 2 }; enum { count = 4 };
static bool _found[count]; static bool _found[count];
static const char* _type [count]; static const char* _type [count];
@ -479,12 +479,15 @@ class dfa_shared_preds {
char c = *prev; char c = *prev;
switch( c ) { switch( c ) {
case ' ': case ' ':
case '\n':
return dfa_shared_preds::valid_loc(pred, prev); return dfa_shared_preds::valid_loc(pred, prev);
case '!': case '!':
case '(': case '(':
case '<': case '<':
case '=': case '=':
return true; return true;
case '"': // such as: #line 10 "myfile.ad"\n mypredicate
return true;
case '|': case '|':
if( prev != pred && *(prev-1) == '|' ) return true; if( prev != pred && *(prev-1) == '|' ) return true;
case '&': case '&':
@ -564,10 +567,14 @@ public:
} }
}; };
// shared predicates, _var and _pred entry should be the same length // shared predicates, _var and _pred entry should be the same length
bool dfa_shared_preds::_found[dfa_shared_preds::count] = { false, false }; bool dfa_shared_preds::_found[dfa_shared_preds::count]
const char* dfa_shared_preds::_type[dfa_shared_preds::count] = { "int", "bool" }; = { false, false, false, false };
const char* dfa_shared_preds::_var [dfa_shared_preds::count] = { "_n_get_int__", "Compile__current____select_24_bit_instr__" }; const char* dfa_shared_preds::_type[dfa_shared_preds::count]
const char* dfa_shared_preds::_pred[dfa_shared_preds::count] = { "n->get_int()", "Compile::current()->select_24_bit_instr()" }; = { "int", "jlong", "intptr_t", "bool" };
const char* dfa_shared_preds::_var [dfa_shared_preds::count]
= { "_n_get_int__", "_n_get_long__", "_n_get_intptr_t__", "Compile__current____select_24_bit_instr__" };
const char* dfa_shared_preds::_pred[dfa_shared_preds::count]
= { "n->get_int()", "n->get_long()", "n->get_intptr_t()", "Compile::current()->select_24_bit_instr()" };
void ArchDesc::gen_dfa_state_body(FILE* fp, Dict &minimize, ProductionState &status, Dict &operands_chained_from, int i) { void ArchDesc::gen_dfa_state_body(FILE* fp, Dict &minimize, ProductionState &status, Dict &operands_chained_from, int i) {

View File

@ -68,6 +68,7 @@ class FileBuff {
// and increments bufeol and filepos to point at the end of that line. // and increments bufeol and filepos to point at the end of that line.
char *get_line(void); char *get_line(void);
int linenum() const { return _linenum; } int linenum() const { return _linenum; }
void set_linenum(int line) { _linenum = line; }
// This converts a pointer into the buffer to a file offset. It only works // This converts a pointer into the buffer to a file offset. It only works
// when the pointer is valid (i.e. just obtained from getline()). // when the pointer is valid (i.e. just obtained from getline()).

View File

@ -1102,10 +1102,7 @@ bool equivalent_predicates( const InstructForm *instr1, const InstructForm *inst
} }
if( pred1 != NULL && pred2 != NULL ) { if( pred1 != NULL && pred2 != NULL ) {
// compare the predicates // compare the predicates
const char *str1 = pred1->_pred; if (ADLParser::equivalent_expressions(pred1->_pred, pred2->_pred)) {
const char *str2 = pred2->_pred;
if( (str1 == NULL && str2 == NULL)
|| (str1 != NULL && str2 != NULL && strcmp(str1,str2) == 0) ) {
return true; return true;
} }
} }

View File

@ -1210,8 +1210,8 @@ LIR_Opr LIRGenerator::load_constant(LIR_Const* c) {
break; break;
case T_LONG: case T_LONG:
case T_DOUBLE: case T_DOUBLE:
if (c->as_jint_hi_bits() != other->as_jint_lo_bits()) continue; if (c->as_jint_hi_bits() != other->as_jint_hi_bits()) continue;
if (c->as_jint_lo_bits() != other->as_jint_hi_bits()) continue; if (c->as_jint_lo_bits() != other->as_jint_lo_bits()) continue;
break; break;
case T_OBJECT: case T_OBJECT:
if (c->as_jobject() != other->as_jobject()) continue; if (c->as_jobject() != other->as_jobject()) continue;

View File

@ -327,8 +327,6 @@ class BlockMerger: public BlockClosure {
BlockBegin* fsux = if_->fsux(); BlockBegin* fsux = if_->fsux();
if (swapped) { if (swapped) {
cond = Instruction::mirror(cond); cond = Instruction::mirror(cond);
tsux = if_->fsux();
fsux = if_->tsux();
} }
BlockBegin* tblock = tval->compare(cond, con, tsux, fsux); BlockBegin* tblock = tval->compare(cond, con, tsux, fsux);

View File

@ -842,6 +842,13 @@ JRT_ENTRY(void, Runtime1::patch_code(JavaThread* thread, Runtime1::StubID stub_i
if (TracePatching) { if (TracePatching) {
tty->print_cr("Deoptimizing for patching volatile field reference"); tty->print_cr("Deoptimizing for patching volatile field reference");
} }
// It's possible the nmethod was invalidated in the last
// safepoint, but if it's still alive then make it not_entrant.
nmethod* nm = CodeCache::find_nmethod(caller_frame.pc());
if (nm != NULL) {
nm->make_not_entrant();
}
VM_DeoptimizeFrame deopt(thread, caller_frame.id()); VM_DeoptimizeFrame deopt(thread, caller_frame.id());
VMThread::execute(&deopt); VMThread::execute(&deopt);

View File

@ -581,6 +581,7 @@ objArrayHandle ClassFileParser::parse_interfaces(constantPoolHandle cp,
interf = KlassHandle(THREAD, k); interf = KlassHandle(THREAD, k);
vmtimer->resume(); vmtimer->resume();
if (LinkWellKnownClasses) // my super type is well known to me
cp->klass_at_put(interface_index, interf()); // eagerly resolve cp->klass_at_put(interface_index, interf()); // eagerly resolve
} }
@ -2699,6 +2700,7 @@ instanceKlassHandle ClassFileParser::parseClassFile(symbolHandle name,
CHECK_(nullHandle)); CHECK_(nullHandle));
KlassHandle kh (THREAD, k); KlassHandle kh (THREAD, k);
super_klass = instanceKlassHandle(THREAD, kh()); super_klass = instanceKlassHandle(THREAD, kh());
if (LinkWellKnownClasses) // my super class is well known to me
cp->klass_at_put(super_class_index, super_klass()); // eagerly resolve cp->klass_at_put(super_class_index, super_klass()); // eagerly resolve
} }
if (super_klass.not_null()) { if (super_klass.not_null()) {
@ -3128,6 +3130,7 @@ instanceKlassHandle ClassFileParser::parseClassFile(symbolHandle name,
this_klass->set_method_ordering(method_ordering()); this_klass->set_method_ordering(method_ordering());
this_klass->set_initial_method_idnum(methods->length()); this_klass->set_initial_method_idnum(methods->length());
this_klass->set_name(cp->klass_name_at(this_class_index)); this_klass->set_name(cp->klass_name_at(this_class_index));
if (LinkWellKnownClasses) // I am well known to myself
cp->klass_at_put(this_class_index, this_klass()); // eagerly resolve cp->klass_at_put(this_class_index, this_klass()); // eagerly resolve
this_klass->set_protection_domain(protection_domain()); this_klass->set_protection_domain(protection_domain());
this_klass->set_fields_annotations(fields_annotations()); this_klass->set_fields_annotations(fields_annotations());

View File

@ -2954,7 +2954,7 @@ public:
// The object has been either evacuated or is dead. Fill it with a // The object has been either evacuated or is dead. Fill it with a
// dummy object. // dummy object.
MemRegion mr((HeapWord*)obj, obj->size()); MemRegion mr((HeapWord*)obj, obj->size());
SharedHeap::fill_region_with_object(mr); CollectedHeap::fill_with_object(mr);
_cm->clearRangeBothMaps(mr); _cm->clearRangeBothMaps(mr);
} }
} }
@ -3225,7 +3225,7 @@ void G1CollectedHeap::par_allocate_remaining_space(HeapRegion* r) {
// Otherwise, try to claim it. // Otherwise, try to claim it.
block = r->par_allocate(free_words); block = r->par_allocate(free_words);
} while (block == NULL); } while (block == NULL);
SharedHeap::fill_region_with_object(MemRegion(block, free_words)); fill_with_object(block, free_words);
} }
#define use_local_bitmaps 1 #define use_local_bitmaps 1
@ -3619,9 +3619,8 @@ public:
guarantee(alloc_buffer(purpose)->contains(obj + word_sz - 1), guarantee(alloc_buffer(purpose)->contains(obj + word_sz - 1),
"should contain whole object"); "should contain whole object");
alloc_buffer(purpose)->undo_allocation(obj, word_sz); alloc_buffer(purpose)->undo_allocation(obj, word_sz);
} } else {
else { CollectedHeap::fill_with_object(obj, word_sz);
SharedHeap::fill_region_with_object(MemRegion(obj, word_sz));
add_to_undo_waste(word_sz); add_to_undo_waste(word_sz);
} }
} }

View File

@ -181,7 +181,7 @@ public:
void scrub(CardTableModRefBS* ctbs, BitMap* card_bm) { void scrub(CardTableModRefBS* ctbs, BitMap* card_bm) {
HeapWord* hr_bot = hr()->bottom(); HeapWord* hr_bot = hr()->bottom();
int hr_first_card_index = ctbs->index_for(hr_bot); size_t hr_first_card_index = ctbs->index_for(hr_bot);
bm()->set_intersection_at_offset(*card_bm, hr_first_card_index); bm()->set_intersection_at_offset(*card_bm, hr_first_card_index);
#if PRT_COUNT_OCCUPIED #if PRT_COUNT_OCCUPIED
recount_occupied(); recount_occupied();

View File

@ -102,7 +102,7 @@ HeapRegionSeq::alloc_obj_from_region_index(int ind, size_t word_size) {
HeapWord* tmp = hr->allocate(sz); HeapWord* tmp = hr->allocate(sz);
assert(tmp != NULL, "Humongous allocation failure"); assert(tmp != NULL, "Humongous allocation failure");
MemRegion mr = MemRegion(tmp, sz); MemRegion mr = MemRegion(tmp, sz);
SharedHeap::fill_region_with_object(mr); CollectedHeap::fill_with_object(mr);
hr->declare_filled_region_to_BOT(mr); hr->declare_filled_region_to_BOT(mr);
if (i == first) { if (i == first) {
first_hr->set_startsHumongous(); first_hr->set_startsHumongous();

View File

@ -51,14 +51,14 @@ void ParGCAllocBuffer::retire(bool end_of_gc, bool retain) {
if (_retained) { if (_retained) {
// If the buffer had been retained shorten the previous filler object. // If the buffer had been retained shorten the previous filler object.
assert(_retained_filler.end() <= _top, "INVARIANT"); assert(_retained_filler.end() <= _top, "INVARIANT");
SharedHeap::fill_region_with_object(_retained_filler); CollectedHeap::fill_with_object(_retained_filler);
// Wasted space book-keeping, otherwise (normally) done in invalidate() // Wasted space book-keeping, otherwise (normally) done in invalidate()
_wasted += _retained_filler.word_size(); _wasted += _retained_filler.word_size();
_retained = false; _retained = false;
} }
assert(!end_of_gc || !_retained, "At this point, end_of_gc ==> !_retained."); assert(!end_of_gc || !_retained, "At this point, end_of_gc ==> !_retained.");
if (_top < _hard_end) { if (_top < _hard_end) {
SharedHeap::fill_region_with_object(MemRegion(_top, _hard_end)); CollectedHeap::fill_with_object(_top, _hard_end);
if (!retain) { if (!retain) {
invalidate(); invalidate();
} else { } else {
@ -155,7 +155,7 @@ ParGCAllocBufferWithBOT::ParGCAllocBufferWithBOT(size_t word_sz,
// modifying the _next_threshold state in the BOT. // modifying the _next_threshold state in the BOT.
void ParGCAllocBufferWithBOT::fill_region_with_block(MemRegion mr, void ParGCAllocBufferWithBOT::fill_region_with_block(MemRegion mr,
bool contig) { bool contig) {
SharedHeap::fill_region_with_object(mr); CollectedHeap::fill_with_object(mr);
if (contig) { if (contig) {
_bt.alloc_block(mr.start(), mr.end()); _bt.alloc_block(mr.start(), mr.end());
} else { } else {
@ -171,7 +171,7 @@ HeapWord* ParGCAllocBufferWithBOT::allocate_slow(size_t word_sz) {
"or else _true_end should be equal to _hard_end"); "or else _true_end should be equal to _hard_end");
assert(_retained, "or else _true_end should be equal to _hard_end"); assert(_retained, "or else _true_end should be equal to _hard_end");
assert(_retained_filler.end() <= _top, "INVARIANT"); assert(_retained_filler.end() <= _top, "INVARIANT");
SharedHeap::fill_region_with_object(_retained_filler); CollectedHeap::fill_with_object(_retained_filler);
if (_top < _hard_end) { if (_top < _hard_end) {
fill_region_with_block(MemRegion(_top, _hard_end), true); fill_region_with_block(MemRegion(_top, _hard_end), true);
} }
@ -316,11 +316,9 @@ void ParGCAllocBufferWithBOT::retire(bool end_of_gc, bool retain) {
while (_top <= chunk_boundary) { while (_top <= chunk_boundary) {
assert(pointer_delta(_hard_end, chunk_boundary) >= AlignmentReserve, assert(pointer_delta(_hard_end, chunk_boundary) >= AlignmentReserve,
"Consequence of last card handling above."); "Consequence of last card handling above.");
MemRegion chunk_portion(chunk_boundary, _hard_end); _bt.BlockOffsetArray::alloc_block(chunk_boundary, _hard_end);
_bt.BlockOffsetArray::alloc_block(chunk_portion.start(), CollectedHeap::fill_with_object(chunk_boundary, _hard_end);
chunk_portion.end()); _hard_end = chunk_boundary;
SharedHeap::fill_region_with_object(chunk_portion);
_hard_end = chunk_portion.start();
chunk_boundary -= ChunkSizeInWords; chunk_boundary -= ChunkSizeInWords;
} }
_end = _hard_end - AlignmentReserve; _end = _hard_end - AlignmentReserve;

View File

@ -201,7 +201,7 @@ void ParScanThreadState::undo_alloc_in_to_space(HeapWord* obj,
"Should contain whole object."); "Should contain whole object.");
to_space_alloc_buffer()->undo_allocation(obj, word_sz); to_space_alloc_buffer()->undo_allocation(obj, word_sz);
} else { } else {
SharedHeap::fill_region_with_object(MemRegion(obj, word_sz)); CollectedHeap::fill_with_object(obj, word_sz);
} }
} }

View File

@ -389,7 +389,7 @@ bool PSMarkSweep::absorb_live_data_from_eden(PSAdaptiveSizePolicy* size_policy,
// full GC. // full GC.
const size_t alignment = old_gen->virtual_space()->alignment(); const size_t alignment = old_gen->virtual_space()->alignment();
const size_t eden_used = eden_space->used_in_bytes(); const size_t eden_used = eden_space->used_in_bytes();
const size_t promoted = (size_t)(size_policy->avg_promoted()->padded_average()); const size_t promoted = (size_t)size_policy->avg_promoted()->padded_average();
const size_t absorb_size = align_size_up(eden_used + promoted, alignment); const size_t absorb_size = align_size_up(eden_used + promoted, alignment);
const size_t eden_capacity = eden_space->capacity_in_bytes(); const size_t eden_capacity = eden_space->capacity_in_bytes();
@ -416,16 +416,14 @@ bool PSMarkSweep::absorb_live_data_from_eden(PSAdaptiveSizePolicy* size_policy,
// Fill the unused part of the old gen. // Fill the unused part of the old gen.
MutableSpace* const old_space = old_gen->object_space(); MutableSpace* const old_space = old_gen->object_space();
MemRegion old_gen_unused(old_space->top(), old_space->end()); HeapWord* const unused_start = old_space->top();
size_t const unused_words = pointer_delta(old_space->end(), unused_start);
// If the unused part of the old gen cannot be filled, skip if (unused_words > 0) {
// absorbing eden. if (unused_words < CollectedHeap::min_fill_size()) {
if (old_gen_unused.word_size() < SharedHeap::min_fill_size()) { return false; // If the old gen cannot be filled, must give up.
return false;
} }
CollectedHeap::fill_with_objects(unused_start, unused_words);
if (!old_gen_unused.is_empty()) {
SharedHeap::fill_region_with_object(old_gen_unused);
} }
// Take the live data from eden and set both top and end in the old gen to // Take the live data from eden and set both top and end in the old gen to
@ -441,9 +439,8 @@ bool PSMarkSweep::absorb_live_data_from_eden(PSAdaptiveSizePolicy* size_policy,
// Update the object start array for the filler object and the data from eden. // Update the object start array for the filler object and the data from eden.
ObjectStartArray* const start_array = old_gen->start_array(); ObjectStartArray* const start_array = old_gen->start_array();
HeapWord* const start = old_gen_unused.start(); for (HeapWord* p = unused_start; p < new_top; p += oop(p)->size()) {
for (HeapWord* addr = start; addr < new_top; addr += oop(addr)->size()) { start_array->allocate_block(p);
start_array->allocate_block(addr);
} }
// Could update the promoted average here, but it is not typically updated at // Could update the promoted average here, but it is not typically updated at

View File

@ -275,22 +275,9 @@ bool PSMarkSweepDecorator::insert_deadspace(size_t& allowed_deadspace_words,
HeapWord* q, size_t deadlength) { HeapWord* q, size_t deadlength) {
if (allowed_deadspace_words >= deadlength) { if (allowed_deadspace_words >= deadlength) {
allowed_deadspace_words -= deadlength; allowed_deadspace_words -= deadlength;
oop(q)->set_mark(markOopDesc::prototype()->set_marked()); CollectedHeap::fill_with_object(q, deadlength);
const size_t aligned_min_int_array_size = oop(q)->set_mark(oop(q)->mark()->set_marked());
align_object_size(typeArrayOopDesc::header_size(T_INT)); assert((int) deadlength == oop(q)->size(), "bad filler object size");
if (deadlength >= aligned_min_int_array_size) {
oop(q)->set_klass(Universe::intArrayKlassObj());
assert(((deadlength - aligned_min_int_array_size) * (HeapWordSize/sizeof(jint))) < (size_t)max_jint,
"deadspace too big for Arrayoop");
typeArrayOop(q)->set_length((int)((deadlength - aligned_min_int_array_size)
* (HeapWordSize/sizeof(jint))));
} else {
assert((int) deadlength == instanceOopDesc::header_size(),
"size for smallest fake dead object doesn't match");
oop(q)->set_klass(SystemDictionary::object_klass());
}
assert((int) deadlength == oop(q)->size(),
"make sure size for fake dead object match");
// Recall that we required "q == compaction_top". // Recall that we required "q == compaction_top".
return true; return true;
} else { } else {

View File

@ -36,6 +36,123 @@ class PreGCValues;
class MoveAndUpdateClosure; class MoveAndUpdateClosure;
class RefProcTaskExecutor; class RefProcTaskExecutor;
// The SplitInfo class holds the information needed to 'split' a source region
// so that the live data can be copied to two destination *spaces*. Normally,
// all the live data in a region is copied to a single destination space (e.g.,
// everything live in a region in eden is copied entirely into the old gen).
// However, when the heap is nearly full, all the live data in eden may not fit
// into the old gen. Copying only some of the regions from eden to old gen
// requires finding a region that does not contain a partial object (i.e., no
// live object crosses the region boundary) somewhere near the last object that
// does fit into the old gen. Since it's not always possible to find such a
// region, splitting is necessary for predictable behavior.
//
// A region is always split at the end of the partial object. This avoids
// additional tests when calculating the new location of a pointer, which is a
// very hot code path. The partial object and everything to its left will be
// copied to another space (call it dest_space_1). The live data to the right
// of the partial object will be copied either within the space itself, or to a
// different destination space (distinct from dest_space_1).
//
// Split points are identified during the summary phase, when region
// destinations are computed: data about the split, including the
// partial_object_size, is recorded in a SplitInfo record and the
// partial_object_size field in the summary data is set to zero. The zeroing is
// possible (and necessary) since the partial object will move to a different
// destination space than anything to its right, thus the partial object should
// not affect the locations of any objects to its right.
//
// The recorded data is used during the compaction phase, but only rarely: when
// the partial object on the split region will be copied across a destination
// region boundary. This test is made once each time a region is filled, and is
// a simple address comparison, so the overhead is negligible (see
// PSParallelCompact::first_src_addr()).
//
// Notes:
//
// Only regions with partial objects are split; a region without a partial
// object does not need any extra bookkeeping.
//
// At most one region is split per space, so the amount of data required is
// constant.
//
// A region is split only when the destination space would overflow. Once that
// happens, the destination space is abandoned and no other data (even from
// other source spaces) is targeted to that destination space. Abandoning the
// destination space may leave a somewhat large unused area at the end, if a
// large object caused the overflow.
//
// Future work:
//
// More bookkeeping would be required to continue to use the destination space.
// The most general solution would allow data from regions in two different
// source spaces to be "joined" in a single destination region. At the very
// least, additional code would be required in next_src_region() to detect the
// join and skip to an out-of-order source region. If the join region was also
// the last destination region to which a split region was copied (the most
// likely case), then additional work would be needed to get fill_region() to
// stop iteration and switch to a new source region at the right point. Basic
// idea would be to use a fake value for the top of the source space. It is
// doable, if a bit tricky.
//
// A simpler (but less general) solution would fill the remainder of the
// destination region with a dummy object and continue filling the next
// destination region.
class SplitInfo
{
public:
// Return true if this split info is valid (i.e., if a split has been
// recorded). The very first region cannot have a partial object and thus is
// never split, so 0 is the 'invalid' value.
bool is_valid() const { return _src_region_idx > 0; }
// Return true if this split holds data for the specified source region.
inline bool is_split(size_t source_region) const;
// The index of the split region, the size of the partial object on that
// region and the destination of the partial object.
size_t src_region_idx() const { return _src_region_idx; }
size_t partial_obj_size() const { return _partial_obj_size; }
HeapWord* destination() const { return _destination; }
// The destination count of the partial object referenced by this split
// (either 1 or 2). This must be added to the destination count of the
// remainder of the source region.
unsigned int destination_count() const { return _destination_count; }
// If a word within the partial object will be written to the first word of a
// destination region, this is the address of the destination region;
// otherwise this is NULL.
HeapWord* dest_region_addr() const { return _dest_region_addr; }
// If a word within the partial object will be written to the first word of a
// destination region, this is the address of that word within the partial
// object; otherwise this is NULL.
HeapWord* first_src_addr() const { return _first_src_addr; }
// Record the data necessary to split the region src_region_idx.
void record(size_t src_region_idx, size_t partial_obj_size,
HeapWord* destination);
void clear();
DEBUG_ONLY(void verify_clear();)
private:
size_t _src_region_idx;
size_t _partial_obj_size;
HeapWord* _destination;
unsigned int _destination_count;
HeapWord* _dest_region_addr;
HeapWord* _first_src_addr;
};
inline bool SplitInfo::is_split(size_t region_idx) const
{
return _src_region_idx == region_idx && is_valid();
}
class SpaceInfo class SpaceInfo
{ {
public: public:
@ -58,18 +175,23 @@ class SpaceInfo
// is no start array. // is no start array.
ObjectStartArray* start_array() const { return _start_array; } ObjectStartArray* start_array() const { return _start_array; }
SplitInfo& split_info() { return _split_info; }
void set_space(MutableSpace* s) { _space = s; } void set_space(MutableSpace* s) { _space = s; }
void set_new_top(HeapWord* addr) { _new_top = addr; } void set_new_top(HeapWord* addr) { _new_top = addr; }
void set_min_dense_prefix(HeapWord* addr) { _min_dense_prefix = addr; } void set_min_dense_prefix(HeapWord* addr) { _min_dense_prefix = addr; }
void set_dense_prefix(HeapWord* addr) { _dense_prefix = addr; } void set_dense_prefix(HeapWord* addr) { _dense_prefix = addr; }
void set_start_array(ObjectStartArray* s) { _start_array = s; } void set_start_array(ObjectStartArray* s) { _start_array = s; }
void publish_new_top() const { _space->set_top(_new_top); }
private: private:
MutableSpace* _space; MutableSpace* _space;
HeapWord* _new_top; HeapWord* _new_top;
HeapWord* _min_dense_prefix; HeapWord* _min_dense_prefix;
HeapWord* _dense_prefix; HeapWord* _dense_prefix;
ObjectStartArray* _start_array; ObjectStartArray* _start_array;
SplitInfo _split_info;
}; };
class ParallelCompactData class ParallelCompactData
@ -230,9 +352,14 @@ public:
// must be region-aligned; end need not be. // must be region-aligned; end need not be.
void summarize_dense_prefix(HeapWord* beg, HeapWord* end); void summarize_dense_prefix(HeapWord* beg, HeapWord* end);
bool summarize(HeapWord* target_beg, HeapWord* target_end, HeapWord* summarize_split_space(size_t src_region, SplitInfo& split_info,
HeapWord* destination, HeapWord* target_end,
HeapWord** target_next);
bool summarize(SplitInfo& split_info,
HeapWord* source_beg, HeapWord* source_end, HeapWord* source_beg, HeapWord* source_end,
HeapWord** target_next, HeapWord** source_next = 0); HeapWord** source_next,
HeapWord* target_beg, HeapWord* target_end,
HeapWord** target_next);
void clear(); void clear();
void clear_range(size_t beg_region, size_t end_region); void clear_range(size_t beg_region, size_t end_region);
@ -838,13 +965,31 @@ class PSParallelCompact : AllStatic {
// non-empty. // non-empty.
static void fill_dense_prefix_end(SpaceId id); static void fill_dense_prefix_end(SpaceId id);
// Clear the summary data source_region field for the specified addresses.
static void clear_source_region(HeapWord* beg_addr, HeapWord* end_addr);
#ifndef PRODUCT
// Routines to provoke splitting a young gen space (ParallelOldGCSplitALot).
// Fill the region [start, start + words) with live object(s). Only usable
// for the old and permanent generations.
static void fill_with_live_objects(SpaceId id, HeapWord* const start,
size_t words);
// Include the new objects in the summary data.
static void summarize_new_objects(SpaceId id, HeapWord* start);
// Add live objects to a survivor space since it's rare that both survivors
// are non-empty.
static void provoke_split_fill_survivor(SpaceId id);
// Add live objects and/or choose the dense prefix to provoke splitting.
static void provoke_split(bool & maximum_compaction);
#endif
static void summarize_spaces_quick(); static void summarize_spaces_quick();
static void summarize_space(SpaceId id, bool maximum_compaction); static void summarize_space(SpaceId id, bool maximum_compaction);
static void summary_phase(ParCompactionManager* cm, bool maximum_compaction); static void summary_phase(ParCompactionManager* cm, bool maximum_compaction);
// The space that is compacted after space_id.
static SpaceId next_compaction_space_id(SpaceId space_id);
// Adjust addresses in roots. Does not adjust addresses in heap. // Adjust addresses in roots. Does not adjust addresses in heap.
static void adjust_roots(); static void adjust_roots();
@ -999,6 +1144,7 @@ class PSParallelCompact : AllStatic {
// Return the address of the word to be copied to dest_addr, which must be // Return the address of the word to be copied to dest_addr, which must be
// aligned to a region boundary. // aligned to a region boundary.
static HeapWord* first_src_addr(HeapWord* const dest_addr, static HeapWord* first_src_addr(HeapWord* const dest_addr,
SpaceId src_space_id,
size_t src_region_idx); size_t src_region_idx);
// Determine the next source region, set closure.source() to the start of the // Determine the next source region, set closure.source() to the start of the
@ -1012,8 +1158,10 @@ class PSParallelCompact : AllStatic {
HeapWord* end_addr); HeapWord* end_addr);
// Decrement the destination count for each non-empty source region in the // Decrement the destination count for each non-empty source region in the
// range [beg_region, region(region_align_up(end_addr))). // range [beg_region, region(region_align_up(end_addr))). If the destination
// count for a region goes to 0 and it needs to be filled, enqueue it.
static void decrement_destination_counts(ParCompactionManager* cm, static void decrement_destination_counts(ParCompactionManager* cm,
SpaceId src_space_id,
size_t beg_region, size_t beg_region,
HeapWord* end_addr); HeapWord* end_addr);
@ -1081,9 +1229,15 @@ class PSParallelCompact : AllStatic {
const SpaceId id, const SpaceId id,
const bool maximum_compaction, const bool maximum_compaction,
HeapWord* const addr); HeapWord* const addr);
static void summary_phase_msg(SpaceId dst_space_id,
HeapWord* dst_beg, HeapWord* dst_end,
SpaceId src_space_id,
HeapWord* src_beg, HeapWord* src_end);
#endif // #ifndef PRODUCT #endif // #ifndef PRODUCT
#ifdef ASSERT #ifdef ASSERT
// Sanity check the new location of a word in the heap.
static inline void check_new_location(HeapWord* old_addr, HeapWord* new_addr);
// Verify that all the regions have been emptied. // Verify that all the regions have been emptied.
static void verify_complete(SpaceId space_id); static void verify_complete(SpaceId space_id);
#endif // #ifdef ASSERT #endif // #ifdef ASSERT
@ -1251,6 +1405,15 @@ inline void PSParallelCompact::adjust_pointer(T* p,
} }
} }
#ifdef ASSERT
inline void
PSParallelCompact::check_new_location(HeapWord* old_addr, HeapWord* new_addr)
{
assert(old_addr >= new_addr || space_id(old_addr) != space_id(new_addr),
"must move left or to a different space");
}
#endif // ASSERT
class MoveAndUpdateClosure: public ParMarkBitMapClosure { class MoveAndUpdateClosure: public ParMarkBitMapClosure {
public: public:
inline MoveAndUpdateClosure(ParMarkBitMap* bitmap, ParCompactionManager* cm, inline MoveAndUpdateClosure(ParMarkBitMap* bitmap, ParCompactionManager* cm,
@ -1324,31 +1487,28 @@ inline void UpdateOnlyClosure::do_addr(HeapWord* addr)
oop(addr)->update_contents(compaction_manager()); oop(addr)->update_contents(compaction_manager());
} }
class FillClosure: public ParMarkBitMapClosure { class FillClosure: public ParMarkBitMapClosure
public: {
public:
FillClosure(ParCompactionManager* cm, PSParallelCompact::SpaceId space_id) : FillClosure(ParCompactionManager* cm, PSParallelCompact::SpaceId space_id) :
ParMarkBitMapClosure(PSParallelCompact::mark_bitmap(), cm), ParMarkBitMapClosure(PSParallelCompact::mark_bitmap(), cm),
_space_id(space_id), _start_array(PSParallelCompact::start_array(space_id))
_start_array(PSParallelCompact::start_array(space_id)) { {
assert(_space_id == PSParallelCompact::perm_space_id || assert(space_id == PSParallelCompact::perm_space_id ||
_space_id == PSParallelCompact::old_space_id, space_id == PSParallelCompact::old_space_id,
"cannot use FillClosure in the young gen"); "cannot use FillClosure in the young gen");
assert(bitmap() != NULL, "need a bitmap");
assert(_start_array != NULL, "need a start array");
}
void fill_region(HeapWord* addr, size_t size) {
MemRegion region(addr, size);
SharedHeap::fill_region_with_object(region);
_start_array->allocate_block(addr);
} }
virtual IterationStatus do_addr(HeapWord* addr, size_t size) { virtual IterationStatus do_addr(HeapWord* addr, size_t size) {
fill_region(addr, size); CollectedHeap::fill_with_objects(addr, size);
HeapWord* const end = addr + size;
do {
_start_array->allocate_block(addr);
addr += oop(addr)->size();
} while (addr < end);
return ParMarkBitMap::incomplete; return ParMarkBitMap::incomplete;
} }
private: private:
const PSParallelCompact::SpaceId _space_id;
ObjectStartArray* const _start_array; ObjectStartArray* const _start_array;
}; };

View File

@ -499,26 +499,15 @@ oop PSPromotionManager::copy_to_survivor_space(oop o, bool depth_first) {
// We lost, someone else "owns" this object // We lost, someone else "owns" this object
guarantee(o->is_forwarded(), "Object must be forwarded if the cas failed."); guarantee(o->is_forwarded(), "Object must be forwarded if the cas failed.");
// Unallocate the space used. NOTE! We may have directly allocated // Try to deallocate the space. If it was directly allocated we cannot
// the object. If so, we cannot deallocate it, so we have to test! // deallocate it, so we have to test. If the deallocation fails,
// overwrite with a filler object.
if (new_obj_is_tenured) { if (new_obj_is_tenured) {
if (!_old_lab.unallocate_object(new_obj)) { if (!_old_lab.unallocate_object(new_obj)) {
// The promotion lab failed to unallocate the object. CollectedHeap::fill_with_object((HeapWord*) new_obj, new_obj_size);
// We need to overwrite the object with a filler that
// contains no interior pointers.
MemRegion mr((HeapWord*)new_obj, new_obj_size);
// Clean this up and move to oopFactory (see bug 4718422)
SharedHeap::fill_region_with_object(mr);
}
} else {
if (!_young_lab.unallocate_object(new_obj)) {
// The promotion lab failed to unallocate the object.
// We need to overwrite the object with a filler that
// contains no interior pointers.
MemRegion mr((HeapWord*)new_obj, new_obj_size);
// Clean this up and move to oopFactory (see bug 4718422)
SharedHeap::fill_region_with_object(mr);
} }
} else if (!_young_lab.unallocate_object(new_obj)) {
CollectedHeap::fill_with_object((HeapWord*) new_obj, new_obj_size);
} }
// don't update this before the unallocation! // don't update this before the unallocation!

View File

@ -76,8 +76,8 @@ void MutableNUMASpace::ensure_parsability() {
MutableSpace *s = ls->space(); MutableSpace *s = ls->space();
if (s->top() < top()) { // For all spaces preceeding the one containing top() if (s->top() < top()) { // For all spaces preceeding the one containing top()
if (s->free_in_words() > 0) { if (s->free_in_words() > 0) {
SharedHeap::fill_region_with_object(MemRegion(s->top(), s->end()));
size_t area_touched_words = pointer_delta(s->end(), s->top()); size_t area_touched_words = pointer_delta(s->end(), s->top());
CollectedHeap::fill_with_object(s->top(), area_touched_words);
#ifndef ASSERT #ifndef ASSERT
if (!ZapUnusedHeapArea) { if (!ZapUnusedHeapArea) {
area_touched_words = MIN2((size_t)align_object_size(typeArrayOopDesc::header_size(T_INT)), area_touched_words = MIN2((size_t)align_object_size(typeArrayOopDesc::header_size(T_INT)),
@ -686,11 +686,11 @@ void MutableNUMASpace::set_top(HeapWord* value) {
// a minimal object; assuming that's not the last chunk in which case we don't care. // a minimal object; assuming that's not the last chunk in which case we don't care.
if (i < lgrp_spaces()->length() - 1) { if (i < lgrp_spaces()->length() - 1) {
size_t remainder = pointer_delta(s->end(), value); size_t remainder = pointer_delta(s->end(), value);
const size_t minimal_object_size = oopDesc::header_size(); const size_t min_fill_size = CollectedHeap::min_fill_size();
if (remainder < minimal_object_size && remainder > 0) { if (remainder < min_fill_size && remainder > 0) {
// Add a filler object of a minimal size, it will cross the chunk boundary. // Add a minimum size filler object; it will cross the chunk boundary.
SharedHeap::fill_region_with_object(MemRegion(value, minimal_object_size)); CollectedHeap::fill_with_object(value, min_fill_size);
value += minimal_object_size; value += min_fill_size;
assert(!s->contains(value), "Should be in the next chunk"); assert(!s->contains(value), "Should be in the next chunk");
// Restart the loop from the same chunk, since the value has moved // Restart the loop from the same chunk, since the value has moved
// to the next one. // to the next one.

View File

@ -30,12 +30,21 @@
int CollectedHeap::_fire_out_of_memory_count = 0; int CollectedHeap::_fire_out_of_memory_count = 0;
#endif #endif
size_t CollectedHeap::_filler_array_max_size = 0;
// Memory state functions. // Memory state functions.
CollectedHeap::CollectedHeap() : CollectedHeap::CollectedHeap()
_reserved(), _barrier_set(NULL), _is_gc_active(false), {
_total_collections(0), _total_full_collections(0), const size_t max_len = size_t(arrayOopDesc::max_array_length(T_INT));
_gc_cause(GCCause::_no_gc), _gc_lastcause(GCCause::_no_gc) { const size_t elements_per_word = HeapWordSize / sizeof(jint);
_filler_array_max_size = align_object_size(filler_array_hdr_size() +
max_len * elements_per_word);
_barrier_set = NULL;
_is_gc_active = false;
_total_collections = _total_full_collections = 0;
_gc_cause = _gc_lastcause = GCCause::_no_gc;
NOT_PRODUCT(_promotion_failure_alot_count = 0;) NOT_PRODUCT(_promotion_failure_alot_count = 0;)
NOT_PRODUCT(_promotion_failure_alot_gc_number = 0;) NOT_PRODUCT(_promotion_failure_alot_gc_number = 0;)
@ -128,6 +137,94 @@ HeapWord* CollectedHeap::allocate_from_tlab_slow(Thread* thread, size_t size) {
return obj; return obj;
} }
size_t CollectedHeap::filler_array_hdr_size() {
return size_t(arrayOopDesc::header_size(T_INT));
}
size_t CollectedHeap::filler_array_min_size() {
return align_object_size(filler_array_hdr_size());
}
size_t CollectedHeap::filler_array_max_size() {
return _filler_array_max_size;
}
#ifdef ASSERT
void CollectedHeap::fill_args_check(HeapWord* start, size_t words)
{
assert(words >= min_fill_size(), "too small to fill");
assert(words % MinObjAlignment == 0, "unaligned size");
assert(Universe::heap()->is_in_reserved(start), "not in heap");
assert(Universe::heap()->is_in_reserved(start + words - 1), "not in heap");
}
void CollectedHeap::zap_filler_array(HeapWord* start, size_t words)
{
if (ZapFillerObjects) {
Copy::fill_to_words(start + filler_array_hdr_size(),
words - filler_array_hdr_size(), 0XDEAFBABE);
}
}
#endif // ASSERT
void
CollectedHeap::fill_with_array(HeapWord* start, size_t words)
{
assert(words >= filler_array_min_size(), "too small for an array");
assert(words <= filler_array_max_size(), "too big for a single object");
const size_t payload_size = words - filler_array_hdr_size();
const size_t len = payload_size * HeapWordSize / sizeof(jint);
// Set the length first for concurrent GC.
((arrayOop)start)->set_length((int)len);
post_allocation_setup_common(Universe::intArrayKlassObj(), start, words);
DEBUG_ONLY(zap_filler_array(start, words);)
}
void
CollectedHeap::fill_with_object_impl(HeapWord* start, size_t words)
{
assert(words <= filler_array_max_size(), "too big for a single object");
if (words >= filler_array_min_size()) {
fill_with_array(start, words);
} else if (words > 0) {
assert(words == min_fill_size(), "unaligned size");
post_allocation_setup_common(SystemDictionary::object_klass(), start,
words);
}
}
void CollectedHeap::fill_with_object(HeapWord* start, size_t words)
{
DEBUG_ONLY(fill_args_check(start, words);)
HandleMark hm; // Free handles before leaving.
fill_with_object_impl(start, words);
}
void CollectedHeap::fill_with_objects(HeapWord* start, size_t words)
{
DEBUG_ONLY(fill_args_check(start, words);)
HandleMark hm; // Free handles before leaving.
#ifdef LP64
// A single array can fill ~8G, so multiple objects are needed only in 64-bit.
// First fill with arrays, ensuring that any remaining space is big enough to
// fill. The remainder is filled with a single object.
const size_t min = min_fill_size();
const size_t max = filler_array_max_size();
while (words > max) {
const size_t cur = words - max >= min ? max : max - min;
fill_with_array(start, cur);
start += cur;
words -= cur;
}
#endif
fill_with_object_impl(start, words);
}
oop CollectedHeap::new_store_barrier(oop new_obj) { oop CollectedHeap::new_store_barrier(oop new_obj) {
// %%% This needs refactoring. (It was imported from the server compiler.) // %%% This needs refactoring. (It was imported from the server compiler.)
guarantee(can_elide_tlab_store_barriers(), "store barrier elision not supported"); guarantee(can_elide_tlab_store_barriers(), "store barrier elision not supported");

View File

@ -47,6 +47,9 @@ class CollectedHeap : public CHeapObj {
static int _fire_out_of_memory_count; static int _fire_out_of_memory_count;
#endif #endif
// Used for filler objects (static, but initialized in ctor).
static size_t _filler_array_max_size;
protected: protected:
MemRegion _reserved; MemRegion _reserved;
BarrierSet* _barrier_set; BarrierSet* _barrier_set;
@ -119,6 +122,21 @@ class CollectedHeap : public CHeapObj {
// Clears an allocated object. // Clears an allocated object.
inline static void init_obj(HeapWord* obj, size_t size); inline static void init_obj(HeapWord* obj, size_t size);
// Filler object utilities.
static inline size_t filler_array_hdr_size();
static inline size_t filler_array_min_size();
static inline size_t filler_array_max_size();
DEBUG_ONLY(static void fill_args_check(HeapWord* start, size_t words);)
DEBUG_ONLY(static void zap_filler_array(HeapWord* start, size_t words);)
// Fill with a single array; caller must ensure filler_array_min_size() <=
// words <= filler_array_max_size().
static inline void fill_with_array(HeapWord* start, size_t words);
// Fill with a single object (either an int array or a java.lang.Object).
static inline void fill_with_object_impl(HeapWord* start, size_t words);
// Verification functions // Verification functions
virtual void check_for_bad_heap_word_value(HeapWord* addr, size_t size) virtual void check_for_bad_heap_word_value(HeapWord* addr, size_t size)
PRODUCT_RETURN; PRODUCT_RETURN;
@ -294,6 +312,27 @@ class CollectedHeap : public CHeapObj {
// The boundary between a "large" and "small" array of primitives, in words. // The boundary between a "large" and "small" array of primitives, in words.
virtual size_t large_typearray_limit() = 0; virtual size_t large_typearray_limit() = 0;
// Utilities for turning raw memory into filler objects.
//
// min_fill_size() is the smallest region that can be filled.
// fill_with_objects() can fill arbitrary-sized regions of the heap using
// multiple objects. fill_with_object() is for regions known to be smaller
// than the largest array of integers; it uses a single object to fill the
// region and has slightly less overhead.
static size_t min_fill_size() {
return size_t(align_object_size(oopDesc::header_size()));
}
static void fill_with_objects(HeapWord* start, size_t words);
static void fill_with_object(HeapWord* start, size_t words);
static void fill_with_object(MemRegion region) {
fill_with_object(region.start(), region.word_size());
}
static void fill_with_object(HeapWord* start, HeapWord* end) {
fill_with_object(start, pointer_delta(end, start));
}
// Some heaps may offer a contiguous region for shared non-blocking // Some heaps may offer a contiguous region for shared non-blocking
// allocation, via inlined code (by exporting the address of the top and // allocation, via inlined code (by exporting the address of the top and
// end fields defining the extent of the contiguous allocation region.) // end fields defining the extent of the contiguous allocation region.)

View File

@ -34,7 +34,6 @@ void CollectedHeap::post_allocation_setup_common(KlassHandle klass,
void CollectedHeap::post_allocation_setup_no_klass_install(KlassHandle klass, void CollectedHeap::post_allocation_setup_no_klass_install(KlassHandle klass,
HeapWord* objPtr, HeapWord* objPtr,
size_t size) { size_t size) {
oop obj = (oop)objPtr; oop obj = (oop)objPtr;
assert(obj != NULL, "NULL object pointer"); assert(obj != NULL, "NULL object pointer");
@ -44,9 +43,6 @@ void CollectedHeap::post_allocation_setup_no_klass_install(KlassHandle klass,
// May be bootstrapping // May be bootstrapping
obj->set_mark(markOopDesc::prototype()); obj->set_mark(markOopDesc::prototype());
} }
// support low memory notifications (no-op if not enabled)
LowMemoryDetector::detect_low_memory_for_collected_pools();
} }
void CollectedHeap::post_allocation_install_obj_klass(KlassHandle klass, void CollectedHeap::post_allocation_install_obj_klass(KlassHandle klass,
@ -65,6 +61,9 @@ void CollectedHeap::post_allocation_install_obj_klass(KlassHandle klass,
// Support for jvmti and dtrace // Support for jvmti and dtrace
inline void post_allocation_notify(KlassHandle klass, oop obj) { inline void post_allocation_notify(KlassHandle klass, oop obj) {
// support low memory notifications (no-op if not enabled)
LowMemoryDetector::detect_low_memory_for_collected_pools();
// support for JVMTI VMObjectAlloc event (no-op if not enabled) // support for JVMTI VMObjectAlloc event (no-op if not enabled)
JvmtiExport::vm_object_alloc_event_collector(obj); JvmtiExport::vm_object_alloc_event_collector(obj);

View File

@ -28,6 +28,7 @@ collectedHeap.cpp collectedHeap.hpp
collectedHeap.cpp collectedHeap.inline.hpp collectedHeap.cpp collectedHeap.inline.hpp
collectedHeap.cpp init.hpp collectedHeap.cpp init.hpp
collectedHeap.cpp oop.inline.hpp collectedHeap.cpp oop.inline.hpp
collectedHeap.cpp systemDictionary.hpp
collectedHeap.cpp thread_<os_family>.inline.hpp collectedHeap.cpp thread_<os_family>.inline.hpp
collectedHeap.hpp allocation.hpp collectedHeap.hpp allocation.hpp

View File

@ -283,7 +283,7 @@ void CardTableModRefBS::resize_covered_region(MemRegion new_region) {
} else { } else {
entry = byte_after(old_region.last()); entry = byte_after(old_region.last());
} }
assert(index_for(new_region.last()) < (int) _guard_index, assert(index_for(new_region.last()) < _guard_index,
"The guard card will be overwritten"); "The guard card will be overwritten");
// This line commented out cleans the newly expanded region and // This line commented out cleans the newly expanded region and
// not the aligned up expanded region. // not the aligned up expanded region.

View File

@ -428,7 +428,7 @@ public:
} }
// Mapping from address to card marking array index. // Mapping from address to card marking array index.
int index_for(void* p) { size_t index_for(void* p) {
assert(_whole_heap.contains(p), assert(_whole_heap.contains(p),
"out of bounds access to card marking array"); "out of bounds access to card marking array");
return byte_for(p) - _byte_map; return byte_for(p) - _byte_map;

View File

@ -26,20 +26,24 @@
#include "incls/_permGen.cpp.incl" #include "incls/_permGen.cpp.incl"
HeapWord* PermGen::mem_allocate_in_gen(size_t size, Generation* gen) { HeapWord* PermGen::mem_allocate_in_gen(size_t size, Generation* gen) {
MutexLocker ml(Heap_lock);
GCCause::Cause next_cause = GCCause::_permanent_generation_full; GCCause::Cause next_cause = GCCause::_permanent_generation_full;
GCCause::Cause prev_cause = GCCause::_no_gc; GCCause::Cause prev_cause = GCCause::_no_gc;
unsigned int gc_count_before, full_gc_count_before;
HeapWord* obj;
for (;;) { for (;;) {
HeapWord* obj = gen->allocate(size, false); {
if (obj != NULL) { MutexLocker ml(Heap_lock);
if ((obj = gen->allocate(size, false)) != NULL) {
return obj; return obj;
} }
if (gen->capacity() < _capacity_expansion_limit || if (gen->capacity() < _capacity_expansion_limit ||
prev_cause != GCCause::_no_gc) { prev_cause != GCCause::_no_gc) {
obj = gen->expand_and_allocate(size, false); obj = gen->expand_and_allocate(size, false);
} }
if (obj == NULL && prev_cause != GCCause::_last_ditch_collection) { if (obj != NULL || prev_cause == GCCause::_last_ditch_collection) {
return obj;
}
if (GC_locker::is_active_and_needs_gc()) { if (GC_locker::is_active_and_needs_gc()) {
// If this thread is not in a jni critical section, we stall // If this thread is not in a jni critical section, we stall
// the requestor until the critical section has cleared and // the requestor until the critical section has cleared and
@ -61,12 +65,12 @@ HeapWord* PermGen::mem_allocate_in_gen(size_t size, Generation* gen) {
return NULL; return NULL;
} }
} }
// Read the GC count while holding the Heap_lock // Read the GC count while holding the Heap_lock
unsigned int gc_count_before = SharedHeap::heap()->total_collections(); gc_count_before = SharedHeap::heap()->total_collections();
unsigned int full_gc_count_before = SharedHeap::heap()->total_full_collections(); full_gc_count_before = SharedHeap::heap()->total_full_collections();
{ }
MutexUnlocker mu(Heap_lock); // give up heap lock, execute gets it back
// Give up heap lock above, VMThread::execute below gets it back
VM_GenCollectForPermanentAllocation op(size, gc_count_before, full_gc_count_before, VM_GenCollectForPermanentAllocation op(size, gc_count_before, full_gc_count_before,
next_cause); next_cause);
VMThread::execute(&op); VMThread::execute(&op);
@ -80,12 +84,8 @@ HeapWord* PermGen::mem_allocate_in_gen(size_t size, Generation* gen) {
if (obj != NULL) { if (obj != NULL) {
return obj; return obj;
} }
}
prev_cause = next_cause; prev_cause = next_cause;
next_cause = GCCause::_last_ditch_collection; next_cause = GCCause::_last_ditch_collection;
} else {
return obj;
}
} }
} }

View File

@ -248,46 +248,6 @@ void SharedHeap::ref_processing_init() {
perm_gen()->ref_processor_init(); perm_gen()->ref_processor_init();
} }
void SharedHeap::fill_region_with_object(MemRegion mr) {
// Disable the posting of JVMTI VMObjectAlloc events as we
// don't want the filling of tlabs with filler arrays to be
// reported to the profiler.
NoJvmtiVMObjectAllocMark njm;
// Disable low memory detector because there is no real allocation.
LowMemoryDetectorDisabler lmd_dis;
// It turns out that post_allocation_setup_array takes a handle, so the
// call below contains an implicit conversion. Best to free that handle
// as soon as possible.
HandleMark hm;
size_t word_size = mr.word_size();
size_t aligned_array_header_size =
align_object_size(typeArrayOopDesc::header_size(T_INT));
if (word_size >= aligned_array_header_size) {
const size_t array_length =
pointer_delta(mr.end(), mr.start()) -
typeArrayOopDesc::header_size(T_INT);
const size_t array_length_words =
array_length * (HeapWordSize/sizeof(jint));
post_allocation_setup_array(Universe::intArrayKlassObj(),
mr.start(),
mr.word_size(),
(int)array_length_words);
#ifdef ASSERT
HeapWord* elt_words = (mr.start() + typeArrayOopDesc::header_size(T_INT));
Copy::fill_to_words(elt_words, array_length, 0xDEAFBABE);
#endif
} else {
assert(word_size == (size_t)oopDesc::header_size(), "Unaligned?");
post_allocation_setup_obj(SystemDictionary::object_klass(),
mr.start(),
mr.word_size());
}
}
// Some utilities. // Some utilities.
void SharedHeap::print_size_transition(outputStream* out, void SharedHeap::print_size_transition(outputStream* out,
size_t bytes_before, size_t bytes_before,

View File

@ -108,14 +108,6 @@ public:
void set_perm(PermGen* perm_gen) { _perm_gen = perm_gen; } void set_perm(PermGen* perm_gen) { _perm_gen = perm_gen; }
// A helper function that fills a region of the heap with
// with a single object.
static void fill_region_with_object(MemRegion mr);
// Minimum garbage fill object size
static size_t min_fill_size() { return (size_t)align_object_size(oopDesc::header_size()); }
static size_t min_fill_size_in_bytes() { return min_fill_size() * HeapWordSize; }
// This function returns the "GenRemSet" object that allows us to scan // This function returns the "GenRemSet" object that allows us to scan
// generations; at least the perm gen, possibly more in a fully // generations; at least the perm gen, possibly more in a fully
// generational heap. // generational heap.

View File

@ -409,19 +409,9 @@ bool CompactibleSpace::insert_deadspace(size_t& allowed_deadspace_words,
HeapWord* q, size_t deadlength) { HeapWord* q, size_t deadlength) {
if (allowed_deadspace_words >= deadlength) { if (allowed_deadspace_words >= deadlength) {
allowed_deadspace_words -= deadlength; allowed_deadspace_words -= deadlength;
oop(q)->set_mark(markOopDesc::prototype()->set_marked()); CollectedHeap::fill_with_object(q, deadlength);
const size_t min_int_array_size = typeArrayOopDesc::header_size(T_INT); oop(q)->set_mark(oop(q)->mark()->set_marked());
if (deadlength >= min_int_array_size) { assert((int) deadlength == oop(q)->size(), "bad filler object size");
oop(q)->set_klass(Universe::intArrayKlassObj());
typeArrayOop(q)->set_length((int)((deadlength - min_int_array_size)
* (HeapWordSize/sizeof(jint))));
} else {
assert((int) deadlength == instanceOopDesc::header_size(),
"size for smallest fake dead object doesn't match");
oop(q)->set_klass(SystemDictionary::object_klass());
}
assert((int) deadlength == oop(q)->size(),
"make sure size for fake dead object match");
// Recall that we required "q == compaction_top". // Recall that we required "q == compaction_top".
return true; return true;
} else { } else {

View File

@ -387,7 +387,7 @@ void TenuredGeneration::par_promote_alloc_undo(int thread_num,
"should contain whole object"); "should contain whole object");
buf->undo_allocation(obj, word_sz); buf->undo_allocation(obj, word_sz);
} else { } else {
SharedHeap::fill_region_with_object(MemRegion(obj, word_sz)); CollectedHeap::fill_with_object(obj, word_sz);
} }
} }

View File

@ -100,8 +100,7 @@ void ThreadLocalAllocBuffer::accumulate_statistics() {
void ThreadLocalAllocBuffer::make_parsable(bool retire) { void ThreadLocalAllocBuffer::make_parsable(bool retire) {
if (end() != NULL) { if (end() != NULL) {
invariants(); invariants();
MemRegion mr(top(), hard_end()); CollectedHeap::fill_with_object(top(), hard_end());
SharedHeap::fill_region_with_object(mr);
if (retire || ZeroTLAB) { // "Reset" the TLAB if (retire || ZeroTLAB) { // "Reset" the TLAB
set_start(NULL); set_start(NULL);

View File

@ -274,7 +274,6 @@ void Universe::genesis(TRAPS) {
_the_array_interfaces_array = oopFactory::new_system_objArray(2, CHECK); _the_array_interfaces_array = oopFactory::new_system_objArray(2, CHECK);
_vm_exception = oopFactory::new_symbol("vm exception holder", CHECK); _vm_exception = oopFactory::new_symbol("vm exception holder", CHECK);
} else { } else {
FileMapInfo *mapinfo = FileMapInfo::current_info(); FileMapInfo *mapinfo = FileMapInfo::current_info();
char* buffer = mapinfo->region_base(CompactingPermGenGen::md); char* buffer = mapinfo->region_base(CompactingPermGenGen::md);
void** vtbl_list = (void**)buffer; void** vtbl_list = (void**)buffer;

View File

@ -92,6 +92,7 @@ class LatestMethodOopCache : public CommonMethodOopCache {
class Universe: AllStatic { class Universe: AllStatic {
// Ugh. Universe is much too friendly.
friend class MarkSweep; friend class MarkSweep;
friend class oopDesc; friend class oopDesc;
friend class ClassLoader; friend class ClassLoader;

View File

@ -96,19 +96,20 @@ class arrayOopDesc : public oopDesc {
: typesize_in_bytes/HeapWordSize); : typesize_in_bytes/HeapWordSize);
} }
// This method returns the maximum length that can passed into // Return the maximum length of an array of BasicType. The length can passed
// typeArrayOop::object_size(scale, length, header_size) without causing an // to typeArrayOop::object_size(scale, length, header_size) without causing an
// overflow. We substract an extra 2*wordSize to guard against double word // overflow.
// alignments. It gets the scale from the type2aelembytes array.
static int32_t max_array_length(BasicType type) { static int32_t max_array_length(BasicType type) {
assert(type >= 0 && type < T_CONFLICT, "wrong type"); assert(type >= 0 && type < T_CONFLICT, "wrong type");
assert(type2aelembytes(type) != 0, "wrong type"); assert(type2aelembytes(type) != 0, "wrong type");
// We use max_jint, since object_size is internally represented by an 'int' const int bytes_per_element = type2aelembytes(type);
// This gives us an upper bound of max_jint words for the size of the oop. if (bytes_per_element < HeapWordSize) {
int32_t max_words = (max_jint - header_size(type) - 2); return max_jint;
int elembytes = type2aelembytes(type);
jlong len = ((jlong)max_words * HeapWordSize) / elembytes;
return (len > max_jint) ? max_jint : (int32_t)len;
} }
const int32_t max_words = align_size_down(max_jint, MinObjAlignment);
const int32_t max_element_words = max_words - header_size(type);
const int32_t words_per_element = bytes_per_element >> LogHeapWordSize;
return max_element_words / words_per_element;
}
}; };

View File

@ -36,13 +36,14 @@ bool typeArrayKlass::compute_is_subtype_of(klassOop k) {
return element_type() == tak->element_type(); return element_type() == tak->element_type();
} }
klassOop typeArrayKlass::create_klass(BasicType type, int scale, TRAPS) { klassOop typeArrayKlass::create_klass(BasicType type, int scale,
const char* name_str, TRAPS) {
typeArrayKlass o; typeArrayKlass o;
symbolHandle sym(symbolOop(NULL)); symbolHandle sym(symbolOop(NULL));
// bootstrapping: don't create sym if symbolKlass not created yet // bootstrapping: don't create sym if symbolKlass not created yet
if (Universe::symbolKlassObj() != NULL) { if (Universe::symbolKlassObj() != NULL && name_str != NULL) {
sym = oopFactory::new_symbol_handle(external_name(type), CHECK_NULL); sym = oopFactory::new_symbol_handle(name_str, CHECK_NULL);
} }
KlassHandle klassklass (THREAD, Universe::typeArrayKlassKlassObj()); KlassHandle klassklass (THREAD, Universe::typeArrayKlassKlassObj());

View File

@ -39,7 +39,11 @@ class typeArrayKlass : public arrayKlass {
// klass allocation // klass allocation
DEFINE_ALLOCATE_PERMANENT(typeArrayKlass); DEFINE_ALLOCATE_PERMANENT(typeArrayKlass);
static klassOop create_klass(BasicType type, int scale, TRAPS); static klassOop create_klass(BasicType type, int scale, const char* name_str,
TRAPS);
static inline klassOop create_klass(BasicType type, int scale, TRAPS) {
return create_klass(type, scale, external_name(type), CHECK_NULL);
}
int oop_size(oop obj) const; int oop_size(oop obj) const;
int klass_oop_size() const { return object_size(); } int klass_oop_size() const { return object_size(); }

View File

@ -2192,6 +2192,9 @@ static void final_graph_reshaping_impl( Node *n, Final_Reshape_Counts &fpu ) {
case Op_DecodeN: case Op_DecodeN:
assert(!n->in(1)->is_EncodeP(), "should be optimized out"); assert(!n->in(1)->is_EncodeP(), "should be optimized out");
// DecodeN could be pinned on Sparc where it can't be fold into
// an address expression, see the code for Op_CastPP above.
assert(n->in(0) == NULL || !Matcher::clone_shift_expressions, "no control except on sparc");
break; break;
case Op_EncodeP: { case Op_EncodeP: {

View File

@ -1724,6 +1724,13 @@ void PhaseMacroExpand::expand_lock_node(LockNode *lock) {
if (klass_node == NULL) { if (klass_node == NULL) {
Node* k_adr = basic_plus_adr(obj, oopDesc::klass_offset_in_bytes()); Node* k_adr = basic_plus_adr(obj, oopDesc::klass_offset_in_bytes());
klass_node = transform_later( LoadKlassNode::make(_igvn, mem, k_adr, _igvn.type(k_adr)->is_ptr()) ); klass_node = transform_later( LoadKlassNode::make(_igvn, mem, k_adr, _igvn.type(k_adr)->is_ptr()) );
#ifdef _LP64
if (UseCompressedOops && klass_node->is_DecodeN()) {
assert(klass_node->in(1)->Opcode() == Op_LoadNKlass, "sanity");
klass_node->in(1)->init_req(0, ctrl);
} else
#endif
klass_node->init_req(0, ctrl);
} }
Node *proto_node = make_load(ctrl, mem, klass_node, Klass::prototype_header_offset_in_bytes() + sizeof(oopDesc), TypeX_X, TypeX_X->basic_type()); Node *proto_node = make_load(ctrl, mem, klass_node, Klass::prototype_header_offset_in_bytes() + sizeof(oopDesc), TypeX_X, TypeX_X->basic_type());

View File

@ -2173,7 +2173,8 @@ static char* get_bad_address() {
size_t size = os::vm_allocation_granularity(); size_t size = os::vm_allocation_granularity();
bad_address = os::reserve_memory(size); bad_address = os::reserve_memory(size);
if (bad_address != NULL) { if (bad_address != NULL) {
os::protect_memory(bad_address, size, os::MEM_PROT_READ); os::protect_memory(bad_address, size, os::MEM_PROT_READ,
/*is_committed*/false);
} }
} }
return bad_address; return bad_address;

View File

@ -444,9 +444,9 @@ char* SysClassPath::add_jars_to_path(char* path, const char* directory) {
} }
// Parses a memory size specification string. // Parses a memory size specification string.
static bool atomll(const char *s, jlong* result) { static bool atomull(const char *s, julong* result) {
jlong n = 0; julong n = 0;
int args_read = sscanf(s, os::jlong_format_specifier(), &n); int args_read = sscanf(s, os::julong_format_specifier(), &n);
if (args_read != 1) { if (args_read != 1) {
return false; return false;
} }
@ -460,15 +460,20 @@ static bool atomll(const char *s, jlong* result) {
switch (*s) { switch (*s) {
case 'T': case 't': case 'T': case 't':
*result = n * G * K; *result = n * G * K;
// Check for overflow.
if (*result/((julong)G * K) != n) return false;
return true; return true;
case 'G': case 'g': case 'G': case 'g':
*result = n * G; *result = n * G;
if (*result/G != n) return false;
return true; return true;
case 'M': case 'm': case 'M': case 'm':
*result = n * M; *result = n * M;
if (*result/M != n) return false;
return true; return true;
case 'K': case 'k': case 'K': case 'k':
*result = n * K; *result = n * K;
if (*result/K != n) return false;
return true; return true;
case '\0': case '\0':
*result = n; *result = n;
@ -478,10 +483,10 @@ static bool atomll(const char *s, jlong* result) {
} }
} }
Arguments::ArgsRange Arguments::check_memory_size(jlong size, jlong min_size) { Arguments::ArgsRange Arguments::check_memory_size(julong size, julong min_size) {
if (size < min_size) return arg_too_small; if (size < min_size) return arg_too_small;
// Check that size will fit in a size_t (only relevant on 32-bit) // Check that size will fit in a size_t (only relevant on 32-bit)
if ((julong) size > max_uintx) return arg_too_big; if (size > max_uintx) return arg_too_big;
return arg_in_range; return arg_in_range;
} }
@ -522,10 +527,10 @@ static bool set_fp_numeric_flag(char* name, char* value, FlagValueOrigin origin)
static bool set_numeric_flag(char* name, char* value, FlagValueOrigin origin) { static bool set_numeric_flag(char* name, char* value, FlagValueOrigin origin) {
jlong v; julong v;
intx intx_v; intx intx_v;
bool is_neg = false; bool is_neg = false;
// Check the sign first since atomll() parses only unsigned values. // Check the sign first since atomull() parses only unsigned values.
if (*value == '-') { if (*value == '-') {
if (!CommandLineFlags::intxAt(name, &intx_v)) { if (!CommandLineFlags::intxAt(name, &intx_v)) {
return false; return false;
@ -533,7 +538,7 @@ static bool set_numeric_flag(char* name, char* value, FlagValueOrigin origin) {
value++; value++;
is_neg = true; is_neg = true;
} }
if (!atomll(value, &v)) { if (!atomull(value, &v)) {
return false; return false;
} }
intx_v = (intx) v; intx_v = (intx) v;
@ -1517,6 +1522,16 @@ bool Arguments::check_vm_args_consistency() {
MarkSweepAlwaysCompactCount = 1; // Move objects every gc. MarkSweepAlwaysCompactCount = 1; // Move objects every gc.
} }
if (UseParallelOldGC && ParallelOldGCSplitALot) {
// Settings to encourage splitting.
if (!FLAG_IS_CMDLINE(NewRatio)) {
FLAG_SET_CMDLINE(intx, NewRatio, 2);
}
if (!FLAG_IS_CMDLINE(ScavengeBeforeFullGC)) {
FLAG_SET_CMDLINE(bool, ScavengeBeforeFullGC, false);
}
}
status = status && verify_percentage(GCHeapFreeLimit, "GCHeapFreeLimit"); status = status && verify_percentage(GCHeapFreeLimit, "GCHeapFreeLimit");
status = status && verify_percentage(GCTimeLimit, "GCTimeLimit"); status = status && verify_percentage(GCTimeLimit, "GCTimeLimit");
if (GCTimeLimit == 100) { if (GCTimeLimit == 100) {
@ -1667,9 +1682,9 @@ static bool match_option(const JavaVMOption* option, const char** names, const c
} }
Arguments::ArgsRange Arguments::parse_memory_size(const char* s, Arguments::ArgsRange Arguments::parse_memory_size(const char* s,
jlong* long_arg, julong* long_arg,
jlong min_size) { julong min_size) {
if (!atomll(s, long_arg)) return arg_unreadable; if (!atomull(s, long_arg)) return arg_unreadable;
return check_memory_size(*long_arg, min_size); return check_memory_size(*long_arg, min_size);
} }
@ -1847,7 +1862,7 @@ jint Arguments::parse_each_vm_init_arg(const JavaVMInitArgs* args,
FLAG_SET_CMDLINE(bool, BackgroundCompilation, false); FLAG_SET_CMDLINE(bool, BackgroundCompilation, false);
// -Xmn for compatibility with other JVM vendors // -Xmn for compatibility with other JVM vendors
} else if (match_option(option, "-Xmn", &tail)) { } else if (match_option(option, "-Xmn", &tail)) {
jlong long_initial_eden_size = 0; julong long_initial_eden_size = 0;
ArgsRange errcode = parse_memory_size(tail, &long_initial_eden_size, 1); ArgsRange errcode = parse_memory_size(tail, &long_initial_eden_size, 1);
if (errcode != arg_in_range) { if (errcode != arg_in_range) {
jio_fprintf(defaultStream::error_stream(), jio_fprintf(defaultStream::error_stream(),
@ -1859,7 +1874,7 @@ jint Arguments::parse_each_vm_init_arg(const JavaVMInitArgs* args,
FLAG_SET_CMDLINE(uintx, NewSize, (size_t) long_initial_eden_size); FLAG_SET_CMDLINE(uintx, NewSize, (size_t) long_initial_eden_size);
// -Xms // -Xms
} else if (match_option(option, "-Xms", &tail)) { } else if (match_option(option, "-Xms", &tail)) {
jlong long_initial_heap_size = 0; julong long_initial_heap_size = 0;
ArgsRange errcode = parse_memory_size(tail, &long_initial_heap_size, 1); ArgsRange errcode = parse_memory_size(tail, &long_initial_heap_size, 1);
if (errcode != arg_in_range) { if (errcode != arg_in_range) {
jio_fprintf(defaultStream::error_stream(), jio_fprintf(defaultStream::error_stream(),
@ -1872,7 +1887,7 @@ jint Arguments::parse_each_vm_init_arg(const JavaVMInitArgs* args,
set_min_heap_size(initial_heap_size()); set_min_heap_size(initial_heap_size());
// -Xmx // -Xmx
} else if (match_option(option, "-Xmx", &tail)) { } else if (match_option(option, "-Xmx", &tail)) {
jlong long_max_heap_size = 0; julong long_max_heap_size = 0;
ArgsRange errcode = parse_memory_size(tail, &long_max_heap_size, 1); ArgsRange errcode = parse_memory_size(tail, &long_max_heap_size, 1);
if (errcode != arg_in_range) { if (errcode != arg_in_range) {
jio_fprintf(defaultStream::error_stream(), jio_fprintf(defaultStream::error_stream(),
@ -1905,7 +1920,7 @@ jint Arguments::parse_each_vm_init_arg(const JavaVMInitArgs* args,
} }
// -Xss // -Xss
} else if (match_option(option, "-Xss", &tail)) { } else if (match_option(option, "-Xss", &tail)) {
jlong long_ThreadStackSize = 0; julong long_ThreadStackSize = 0;
ArgsRange errcode = parse_memory_size(tail, &long_ThreadStackSize, 1000); ArgsRange errcode = parse_memory_size(tail, &long_ThreadStackSize, 1000);
if (errcode != arg_in_range) { if (errcode != arg_in_range) {
jio_fprintf(defaultStream::error_stream(), jio_fprintf(defaultStream::error_stream(),
@ -1921,9 +1936,9 @@ jint Arguments::parse_each_vm_init_arg(const JavaVMInitArgs* args,
// HotSpot does not have separate native and Java stacks, ignore silently for compatibility // HotSpot does not have separate native and Java stacks, ignore silently for compatibility
// -Xmaxjitcodesize // -Xmaxjitcodesize
} else if (match_option(option, "-Xmaxjitcodesize", &tail)) { } else if (match_option(option, "-Xmaxjitcodesize", &tail)) {
jlong long_ReservedCodeCacheSize = 0; julong long_ReservedCodeCacheSize = 0;
ArgsRange errcode = parse_memory_size(tail, &long_ReservedCodeCacheSize, ArgsRange errcode = parse_memory_size(tail, &long_ReservedCodeCacheSize,
InitialCodeCacheSize); (size_t)InitialCodeCacheSize);
if (errcode != arg_in_range) { if (errcode != arg_in_range) {
jio_fprintf(defaultStream::error_stream(), jio_fprintf(defaultStream::error_stream(),
"Invalid maximum code cache size: %s\n", "Invalid maximum code cache size: %s\n",
@ -2228,7 +2243,7 @@ jint Arguments::parse_each_vm_init_arg(const JavaVMInitArgs* args,
} else if (match_option(option, "-XX:TLEFragmentationRatio=", &tail)) { } else if (match_option(option, "-XX:TLEFragmentationRatio=", &tail)) {
// No longer used. // No longer used.
} else if (match_option(option, "-XX:TLESize=", &tail)) { } else if (match_option(option, "-XX:TLESize=", &tail)) {
jlong long_tlab_size = 0; julong long_tlab_size = 0;
ArgsRange errcode = parse_memory_size(tail, &long_tlab_size, 1); ArgsRange errcode = parse_memory_size(tail, &long_tlab_size, 1);
if (errcode != arg_in_range) { if (errcode != arg_in_range) {
jio_fprintf(defaultStream::error_stream(), jio_fprintf(defaultStream::error_stream(),
@ -2283,7 +2298,7 @@ SOLARIS_ONLY(
"-XX:ParCMSPromoteBlocksToClaim in the future\n"); "-XX:ParCMSPromoteBlocksToClaim in the future\n");
} else } else
if (match_option(option, "-XX:ParallelGCOldGenAllocBufferSize=", &tail)) { if (match_option(option, "-XX:ParallelGCOldGenAllocBufferSize=", &tail)) {
jlong old_plab_size = 0; julong old_plab_size = 0;
ArgsRange errcode = parse_memory_size(tail, &old_plab_size, 1); ArgsRange errcode = parse_memory_size(tail, &old_plab_size, 1);
if (errcode != arg_in_range) { if (errcode != arg_in_range) {
jio_fprintf(defaultStream::error_stream(), jio_fprintf(defaultStream::error_stream(),
@ -2291,13 +2306,13 @@ SOLARIS_ONLY(
describe_range_error(errcode); describe_range_error(errcode);
return JNI_EINVAL; return JNI_EINVAL;
} }
FLAG_SET_CMDLINE(uintx, OldPLABSize, (julong)old_plab_size); FLAG_SET_CMDLINE(uintx, OldPLABSize, old_plab_size);
jio_fprintf(defaultStream::error_stream(), jio_fprintf(defaultStream::error_stream(),
"Please use -XX:OldPLABSize in place of " "Please use -XX:OldPLABSize in place of "
"-XX:ParallelGCOldGenAllocBufferSize in the future\n"); "-XX:ParallelGCOldGenAllocBufferSize in the future\n");
} else } else
if (match_option(option, "-XX:ParallelGCToSpaceAllocBufferSize=", &tail)) { if (match_option(option, "-XX:ParallelGCToSpaceAllocBufferSize=", &tail)) {
jlong young_plab_size = 0; julong young_plab_size = 0;
ArgsRange errcode = parse_memory_size(tail, &young_plab_size, 1); ArgsRange errcode = parse_memory_size(tail, &young_plab_size, 1);
if (errcode != arg_in_range) { if (errcode != arg_in_range) {
jio_fprintf(defaultStream::error_stream(), jio_fprintf(defaultStream::error_stream(),
@ -2305,7 +2320,7 @@ SOLARIS_ONLY(
describe_range_error(errcode); describe_range_error(errcode);
return JNI_EINVAL; return JNI_EINVAL;
} }
FLAG_SET_CMDLINE(uintx, YoungPLABSize, (julong)young_plab_size); FLAG_SET_CMDLINE(uintx, YoungPLABSize, young_plab_size);
jio_fprintf(defaultStream::error_stream(), jio_fprintf(defaultStream::error_stream(),
"Please use -XX:YoungPLABSize in place of " "Please use -XX:YoungPLABSize in place of "
"-XX:ParallelGCToSpaceAllocBufferSize in the future\n"); "-XX:ParallelGCToSpaceAllocBufferSize in the future\n");

View File

@ -339,9 +339,9 @@ class Arguments : AllStatic {
} }
static bool verify_percentage(uintx value, const char* name); static bool verify_percentage(uintx value, const char* name);
static void describe_range_error(ArgsRange errcode); static void describe_range_error(ArgsRange errcode);
static ArgsRange check_memory_size(jlong size, jlong min_size); static ArgsRange check_memory_size(julong size, julong min_size);
static ArgsRange parse_memory_size(const char* s, jlong* long_arg, static ArgsRange parse_memory_size(const char* s, julong* long_arg,
jlong min_size); julong min_size);
// methods to build strings from individual args // methods to build strings from individual args
static void build_jvm_args(const char* arg); static void build_jvm_args(const char* arg);

View File

@ -625,6 +625,9 @@ class CommandLineFlags {
develop(bool, CheckZapUnusedHeapArea, false, \ develop(bool, CheckZapUnusedHeapArea, false, \
"Check zapping of unused heap space") \ "Check zapping of unused heap space") \
\ \
develop(bool, ZapFillerObjects, trueInDebug, \
"Zap filler objects with 0xDEAFBABE") \
\
develop(bool, PrintVMMessages, true, \ develop(bool, PrintVMMessages, true, \
"Print vm messages on console") \ "Print vm messages on console") \
\ \
@ -818,7 +821,7 @@ class CommandLineFlags {
product(bool, ClassUnloading, true, \ product(bool, ClassUnloading, true, \
"Do unloading of classes") \ "Do unloading of classes") \
\ \
diagnostic(bool, LinkWellKnownClasses, true, \ diagnostic(bool, LinkWellKnownClasses, false, \
"Resolve a well known class as soon as its name is seen") \ "Resolve a well known class as soon as its name is seen") \
\ \
develop(bool, DisableStartThread, false, \ develop(bool, DisableStartThread, false, \
@ -1200,11 +1203,12 @@ class CommandLineFlags {
product(uintx, ParallelCMSThreads, 0, \ product(uintx, ParallelCMSThreads, 0, \
"Max number of threads CMS will use for concurrent work") \ "Max number of threads CMS will use for concurrent work") \
\ \
develop(bool, ParallelOldMTUnsafeMarkBitMap, false, \ develop(bool, ParallelOldGCSplitALot, false, \
"Use the Parallel Old MT unsafe in marking the bitmap") \ "Provoke splitting (copying data from a young gen space to" \
"multiple destination spaces)") \
\ \
develop(bool, ParallelOldMTUnsafeUpdateLiveData, false, \ develop(uintx, ParallelOldGCSplitInterval, 3, \
"Use the Parallel Old MT unsafe in update of live size") \ "How often to provoke splitting a young gen space") \
\ \
develop(bool, TraceRegionTasksQueuing, false, \ develop(bool, TraceRegionTasksQueuing, false, \
"Trace the queuing of the region tasks") \ "Trace the queuing of the region tasks") \

View File

@ -504,7 +504,7 @@ class SignatureChekker : public SignatureIterator {
intptr_t v = _value[p]; intptr_t v = _value[p];
if (v != 0 ) { if (v != 0 ) {
size_t t = (size_t)v; size_t t = (size_t)v;
bad = (t < (size_t)os::vm_page_size() ) || !(*(oop*)v)->is_oop_or_null(true); bad = (t < (size_t)os::vm_page_size() ) || !Handle::raw_resolve((oop *)v)->is_oop_or_null(true);
if (CheckJNICalls && bad) { if (CheckJNICalls && bad) {
ReportJNIFatalError((JavaThread*)_thread, "Bad JNI oop argument"); ReportJNIFatalError((JavaThread*)_thread, "Bad JNI oop argument");
} }

View File

@ -932,8 +932,9 @@ void os::serialize_thread_states() {
// the mutator thread if such case is encountered. See bug 6546278 for details. // the mutator thread if such case is encountered. See bug 6546278 for details.
Thread::muxAcquire(&SerializePageLock, "serialize_thread_states"); Thread::muxAcquire(&SerializePageLock, "serialize_thread_states");
os::protect_memory((char *)os::get_memory_serialize_page(), os::protect_memory((char *)os::get_memory_serialize_page(),
os::vm_page_size(), MEM_PROT_READ, /*is_committed*/true ); os::vm_page_size(), MEM_PROT_READ);
os::unguard_memory((char *)os::get_memory_serialize_page(), os::vm_page_size()); os::protect_memory((char *)os::get_memory_serialize_page(),
os::vm_page_size(), MEM_PROT_RW);
Thread::muxRelease(&SerializePageLock); Thread::muxRelease(&SerializePageLock);
} }

View File

@ -208,7 +208,7 @@ class os: AllStatic {
enum ProtType { MEM_PROT_NONE, MEM_PROT_READ, MEM_PROT_RW, MEM_PROT_RWX }; enum ProtType { MEM_PROT_NONE, MEM_PROT_READ, MEM_PROT_RW, MEM_PROT_RWX };
static bool protect_memory(char* addr, size_t bytes, ProtType prot, static bool protect_memory(char* addr, size_t bytes, ProtType prot,
bool is_committed = false); bool is_committed = true);
static bool guard_memory(char* addr, size_t bytes); static bool guard_memory(char* addr, size_t bytes);
static bool unguard_memory(char* addr, size_t bytes); static bool unguard_memory(char* addr, size_t bytes);

View File

@ -3363,13 +3363,13 @@ void ObjectMonitor::ExitEpilog (Thread * Self, ObjectWaiter * Wakee) {
// If the wakee is cold then transiently setting it's affinity // If the wakee is cold then transiently setting it's affinity
// to the current CPU is a good idea. // to the current CPU is a good idea.
// See http://j2se.east/~dice/PERSIST/050624-PullAffinity.txt // See http://j2se.east/~dice/PERSIST/050624-PullAffinity.txt
DTRACE_MONITOR_PROBE(contended__exit, this, object(), Self);
Trigger->unpark() ; Trigger->unpark() ;
// Maintain stats and report events to JVMTI // Maintain stats and report events to JVMTI
if (ObjectSynchronizer::_sync_Parks != NULL) { if (ObjectSynchronizer::_sync_Parks != NULL) {
ObjectSynchronizer::_sync_Parks->inc() ; ObjectSynchronizer::_sync_Parks->inc() ;
} }
DTRACE_MONITOR_PROBE(contended__exit, this, object(), Self);
} }

View File

@ -694,10 +694,10 @@ JVM_ENTRY(jlong, jmm_SetPoolThreshold(JNIEnv* env, jobject obj, jmmThresholdType
-1); -1);
} }
if (threshold > max_intx) { if ((size_t)threshold > max_uintx) {
THROW_MSG_(vmSymbols::java_lang_IllegalArgumentException(), stringStream st;
"Invalid threshold value > max value of size_t", st.print("Invalid valid threshold value. Threshold value (" UINT64_FORMAT ") > max value of size_t (" SIZE_FORMAT ")", (size_t)threshold, max_uintx);
-1); THROW_MSG_(vmSymbols::java_lang_IllegalArgumentException(), st.as_string(), -1);
} }
MemoryPool* pool = get_memory_pool_from_jobject(obj, CHECK_(0L)); MemoryPool* pool = get_memory_pool_from_jobject(obj, CHECK_(0L));

View File

@ -332,6 +332,8 @@ void VMError::report(outputStream* st) {
// VM version // VM version
st->print_cr("#"); st->print_cr("#");
JDK_Version::current().to_string(buf, sizeof(buf));
st->print_cr("# JRE version: %s", buf);
st->print_cr("# Java VM: %s (%s %s %s %s)", st->print_cr("# Java VM: %s (%s %s %s %s)",
Abstract_VM_Version::vm_name(), Abstract_VM_Version::vm_name(),
Abstract_VM_Version::vm_release(), Abstract_VM_Version::vm_release(),

View File

@ -0,0 +1,43 @@
/*
* Copyright 2008 Sun Microsystems, Inc. All Rights Reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
* CA 95054 USA or visit www.sun.com if you need additional information or
* have any questions.
*/
/**
* @test
* @bug 6757316
* @summary load_constant() produces a wrong long constant, with high a low words swapped
* @run main/othervm -Xcomp Test6757316
*/
public class Test6757316 {
public static void main(String[] args) {
long[] arr = {
0x11111111aaaaaaaaL,
0xaaaaaaaa11111111L,
0x11111111aaaaaaaaL,
0xaaaaaaaa11111111L
};
if (arr[0] == arr[1]) {
throw new InternalError();
}
}
}

View File

@ -0,0 +1,40 @@
/*
* Copyright 2008 Sun Microsystems, Inc. All Rights Reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
* CA 95054 USA or visit www.sun.com if you need additional information or
* have any questions.
*/
/**
* @test
* @bug 6758234
* @summary if (k cond (a ? : b: c)) returns reversed answer if k is constant and b and c are longs
* @run main/othervm -Xcomp -XX:CompileOnly=Test6758234.main Test6758234
*/
public class Test6758234 {
static int x = 0;
static int y = 1;
public static void main(String[] args) {
if (1 != ((x < y) ? 1L : 0)) {
throw new InternalError();
}
}
}