8153674: Expected SocketException not thrown when calling bind() with setReuseAddress(false)
Reviewed-by: chegar, msheppar
This commit is contained in:
Vyom Tewari
parent
ecdbe768e1
commit
0a885c4bc8
@ -93,23 +93,19 @@ class MulticastSocket extends DatagramSocket {
|
||||
/**
|
||||
* Create a multicast socket.
|
||||
*
|
||||
* <p>If there is a security manager,
|
||||
* its {@code checkListen} method is first called
|
||||
* with 0 as its argument to ensure the operation is allowed.
|
||||
* This could result in a SecurityException.
|
||||
* <p>
|
||||
* If there is a security manager, its {@code checkListen} method is first
|
||||
* called with 0 as its argument to ensure the operation is allowed. This
|
||||
* could result in a SecurityException.
|
||||
* <p>
|
||||
* When the socket is created the
|
||||
* {@link DatagramSocket#setReuseAddress(boolean)} method is
|
||||
* called to enable the SO_REUSEADDR socket option. When
|
||||
* {@link StandardSocketOptions#SO_REUSEPORT SO_REUSEPORT} is
|
||||
* supported then
|
||||
* {@link DatagramSocketImpl#setOption(SocketOption, Object)}
|
||||
* is called to enable the socket option.
|
||||
* {@link DatagramSocket#setReuseAddress(boolean)} method is called to
|
||||
* enable the SO_REUSEADDR socket option.
|
||||
*
|
||||
* @exception IOException if an I/O exception occurs
|
||||
* while creating the MulticastSocket
|
||||
* @exception SecurityException if a security manager exists and its
|
||||
* {@code checkListen} method doesn't allow the operation.
|
||||
* @exception IOException if an I/O exception occurs while creating the
|
||||
* MulticastSocket
|
||||
* @exception SecurityException if a security manager exists and its
|
||||
* {@code checkListen} method doesn't allow the operation.
|
||||
* @see SecurityManager#checkListen
|
||||
* @see java.net.DatagramSocket#setReuseAddress(boolean)
|
||||
* @see java.net.DatagramSocketImpl#setOption(SocketOption, Object)
|
||||
@ -174,17 +170,13 @@ class MulticastSocket extends DatagramSocket {
|
||||
// Enable SO_REUSEADDR before binding
|
||||
setReuseAddress(true);
|
||||
|
||||
// Enable SO_REUSEPORT if supported before binding
|
||||
if (supportedOptions().contains(StandardSocketOptions.SO_REUSEPORT)) {
|
||||
this.setOption(StandardSocketOptions.SO_REUSEPORT, true);
|
||||
}
|
||||
|
||||
if (bindaddr != null) {
|
||||
try {
|
||||
bind(bindaddr);
|
||||
} finally {
|
||||
if (!isBound())
|
||||
if (!isBound()) {
|
||||
close();
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
466
jdk/test/java/net/DatagramSocket/ReuseAddressTest.java
Normal file
466
jdk/test/java/net/DatagramSocket/ReuseAddressTest.java
Normal file
@ -0,0 +1,466 @@
|
||||
/* Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved.
|
||||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
|
||||
*
|
||||
* This code is free software; you can redistribute it and/or modify it
|
||||
* under the terms of the GNU General Public License version 2 only, as
|
||||
* published by the Free Software Foundation.
|
||||
*
|
||||
* This code is distributed in the hope that it will be useful, but WITHOUT
|
||||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
||||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
|
||||
* version 2 for more details (a copy is included in the LICENSE file that
|
||||
* accompanied this code).
|
||||
*
|
||||
* You should have received a copy of the GNU General Public License version
|
||||
* 2 along with this work; if not, write to the Free Software Foundation,
|
||||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
|
||||
*
|
||||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
|
||||
* or visit www.oracle.com if you need additional information or have any
|
||||
* questions.
|
||||
*/
|
||||
|
||||
import java.io.IOException;
|
||||
import java.net.DatagramSocket;
|
||||
import java.net.InetAddress;
|
||||
import java.net.InetSocketAddress;
|
||||
import java.net.MulticastSocket;
|
||||
import java.net.SocketException;
|
||||
|
||||
/*
|
||||
* @test
|
||||
* @bug 8153674
|
||||
* @summary Expected SocketException not thrown when calling bind() with
|
||||
* setReuseAddress(false)
|
||||
* @run main/othervm ReuseAddressTest
|
||||
*/
|
||||
|
||||
public class ReuseAddressTest {
|
||||
|
||||
String getInfo(DatagramSocket soc) {
|
||||
if (soc == null) {
|
||||
return null;
|
||||
}
|
||||
|
||||
return "localPort: " + soc.getLocalPort()
|
||||
+ "; localAddress: " + soc.getLocalAddress()
|
||||
+ "; remotePort: " + soc.getPort()
|
||||
+ "; remoteAddress: " + soc.getInetAddress()
|
||||
+ "; isClosed: " + soc.isClosed()
|
||||
+ "; isBound: " + soc.isBound();
|
||||
}
|
||||
|
||||
static InetSocketAddress createSocketAddress(int testMcastPort) throws Exception {
|
||||
InetAddress localAddress = InetAddress.getLocalHost();
|
||||
InetSocketAddress localSocketAddress = new InetSocketAddress(localAddress, testMcastPort);
|
||||
return localSocketAddress;
|
||||
}
|
||||
|
||||
/* standalone interface */
|
||||
public static void main(String argv[]) throws Exception {
|
||||
ReuseAddressTest test = new ReuseAddressTest();
|
||||
test.DatagramSocket0029();
|
||||
test.DatagramSocket0030();
|
||||
test.DatagramSocket0031();
|
||||
test.DatagramSocket0032();
|
||||
test.DatagramSocket0034();
|
||||
test.DatagramSocket0035();
|
||||
test.DatagramSocket2028();
|
||||
test.DatagramSocket2029();
|
||||
test.DatagramSocket2030();
|
||||
|
||||
}
|
||||
|
||||
/**
|
||||
* Equivalence class partitioning with input values orientation for public
|
||||
* void setReuseAddress(boolean on) throws SocketException,
|
||||
* <br><b>on</b>: false.
|
||||
* <br><b>Expected results</b>: getReuseAddress() will return false
|
||||
*/
|
||||
public void DatagramSocket0029() throws Exception {
|
||||
String testCaseID = "DatagramSocket0029";
|
||||
System.out.println(" >> " + testCaseID + ": " + "public void setReuseAddress(boolean on) throws SocketException");
|
||||
|
||||
DatagramSocket ds = null;
|
||||
try {
|
||||
ds = new DatagramSocket(null);
|
||||
ds.setReuseAddress(false);
|
||||
if (ds.getReuseAddress() == true) {
|
||||
throw new RuntimeException("SO_REUSEADDR is not set to false");
|
||||
}
|
||||
} catch (IOException e) {
|
||||
e.printStackTrace(System.out);
|
||||
throw new RuntimeException("unexpected: " + e);
|
||||
} catch (SecurityException e) {
|
||||
System.out.println("Security restriction");
|
||||
} finally {
|
||||
if (ds != null) {
|
||||
ds.close();
|
||||
}
|
||||
}
|
||||
|
||||
System.out.println("OKAY");
|
||||
}
|
||||
|
||||
/**
|
||||
* Equivalence class partitioning with input values orientation for public
|
||||
* void setReuseAddress(boolean on) throws SocketException,
|
||||
* <br><b>on</b>: true.
|
||||
* <br><b>Expected results</b>: Allows completely duplicate bindings (same
|
||||
* address and port) on multicast sockets
|
||||
*/
|
||||
public void DatagramSocket0030() throws Exception {
|
||||
String testCaseID = "DatagramSocket0030";
|
||||
System.out.println(" >> " + testCaseID + ": " + "public void setReuseAddress(boolean on) throws SocketException");
|
||||
|
||||
MulticastSocket ms1 = null;
|
||||
MulticastSocket ms2 = null;
|
||||
try {
|
||||
InetSocketAddress addr = createSocketAddress(5050);
|
||||
|
||||
ms1 = new MulticastSocket(null);
|
||||
ms1.setReuseAddress(true);
|
||||
if (!ms1.getReuseAddress()) {
|
||||
System.out.println("Cannot check: "
|
||||
+ " safety for SO_REUSEADDR option is not guaranteed");
|
||||
}
|
||||
|
||||
try {
|
||||
ms1.bind(addr);
|
||||
} catch (SocketException e) {
|
||||
throw new RuntimeException("cannot bind first socket to " + addr
|
||||
+ " unexpected " + e);
|
||||
}
|
||||
|
||||
ms2 = new MulticastSocket(null);
|
||||
ms2.setReuseAddress(true);
|
||||
if (!ms2.getReuseAddress()) {
|
||||
System.out.println("Cannot check: "
|
||||
+ " safety for SO_REUSEADDR option is not guaranteed");
|
||||
}
|
||||
|
||||
try {
|
||||
ms2.bind(addr);
|
||||
} catch (SocketException e) {
|
||||
throw new RuntimeException("cannot bind second socket to " + addr
|
||||
+ " unexpected " + e);
|
||||
}
|
||||
|
||||
if (ms1.getLocalPort() != addr.getPort() || !ms1.isBound()
|
||||
|| ms2.getLocalPort() != addr.getPort() || !ms2.isBound()) {
|
||||
System.out.println("bind() fails with: " + addr);
|
||||
System.out.println(" ms1 [" + getInfo(ms1) + "]");
|
||||
System.out.println(" ms2 [" + getInfo(ms2) + "]");
|
||||
System.out.println(" getReuseAddress(): " + ms2.getReuseAddress());
|
||||
throw new RuntimeException("bind() fails with: " + addr);
|
||||
}
|
||||
|
||||
} catch (IOException e) {
|
||||
e.printStackTrace(System.out);
|
||||
throw new RuntimeException("unexpected: " + e);
|
||||
} catch (SecurityException e) {
|
||||
System.out.println("Security restriction");
|
||||
} finally {
|
||||
if (ms1 != null) {
|
||||
ms1.close();
|
||||
}
|
||||
if (ms2 != null) {
|
||||
ms2.close();
|
||||
}
|
||||
}
|
||||
|
||||
System.out.println("OKAY");
|
||||
}
|
||||
|
||||
/**
|
||||
* Equivalence class partitioning with input values orientation for public
|
||||
* void setReuseAddress(boolean on) throws SocketException,
|
||||
* <br><b>on</b>: false.
|
||||
* <br><b>Expected results</b>: The second bind will throw SocketException,
|
||||
* when SO_REUSEADDR disable
|
||||
*/
|
||||
public void DatagramSocket0031() throws Exception {
|
||||
String testCaseID = "DatagramSocket0031";
|
||||
System.out.println(" >> " + testCaseID + ": " + "public void setReuseAddress(boolean on) throws SocketException");
|
||||
|
||||
MulticastSocket ms1 = null;
|
||||
MulticastSocket ms2 = null;
|
||||
try {
|
||||
InetSocketAddress addr = createSocketAddress(6060);
|
||||
|
||||
ms1 = new MulticastSocket(null);
|
||||
try {
|
||||
ms1.bind(addr);
|
||||
} catch (SocketException e) {
|
||||
throw new RuntimeException("cannot bind first socket to " + addr
|
||||
+ " unexpected " + e);
|
||||
}
|
||||
|
||||
ms2 = new MulticastSocket(null);
|
||||
ms2.setReuseAddress(false); // method under test
|
||||
|
||||
try {
|
||||
ms2.bind(addr);
|
||||
System.out.println("No exceptions: ");
|
||||
System.out.println(" addr: " + addr);
|
||||
System.out.println(" ms1 [" + getInfo(ms1) + "]");
|
||||
System.out.println(" ms2 [" + getInfo(ms2) + "]");
|
||||
System.out.println(" getReuseAddress(): " + ms2.getReuseAddress());
|
||||
throw new RuntimeException("no exceptions from bind() with " + addr);
|
||||
} catch (SocketException e) {
|
||||
}
|
||||
|
||||
} catch (IOException e) {
|
||||
e.printStackTrace(System.out);
|
||||
throw new RuntimeException("unexpected: " + e);
|
||||
} catch (SecurityException e) {
|
||||
System.out.println("Security restriction");
|
||||
} finally {
|
||||
if (ms1 != null) {
|
||||
ms1.close();
|
||||
}
|
||||
if (ms2 != null) {
|
||||
ms2.close();
|
||||
}
|
||||
}
|
||||
|
||||
System.out.println("OKAY");
|
||||
}
|
||||
|
||||
/**
|
||||
* Equivalence class partitioning with input values orientation for public
|
||||
* void setReuseAddress(boolean on) throws SocketException,
|
||||
* <br><b>on</b>: true.
|
||||
* <br><b>Expected results</b>: Allows a single process to bind the same
|
||||
* port to multiple sockets as long as each bind specifies a different local
|
||||
* IP address
|
||||
*/
|
||||
public void DatagramSocket0032() throws Exception {
|
||||
String testCaseID = "DatagramSocket0032";
|
||||
System.out.println(" >> " + testCaseID + ": " + "public void setReuseAddress(boolean on) throws SocketException");
|
||||
|
||||
DatagramSocket ds1 = null;
|
||||
DatagramSocket ds2 = null;
|
||||
try {
|
||||
|
||||
InetSocketAddress isa = createSocketAddress(7070);
|
||||
InetAddress addr = isa.getAddress();
|
||||
InetAddress wildcard = InetAddress.getByName("0.0.0.0");
|
||||
if (addr.equals(wildcard) || addr.isLoopbackAddress()) {
|
||||
System.out.println("Cannot check: addresses are equal");
|
||||
}
|
||||
|
||||
InetSocketAddress isa1 = new InetSocketAddress(addr, isa.getPort());
|
||||
InetSocketAddress isa2 = new InetSocketAddress(wildcard, isa.getPort());
|
||||
|
||||
ds1 = new DatagramSocket(null);
|
||||
ds1.setReuseAddress(true); // method under test
|
||||
if (!ds1.getReuseAddress()) {
|
||||
System.out.println("Cannot check: "
|
||||
+ " safety for SO_REUSEADDR option is not guaranteed");
|
||||
}
|
||||
ds1.bind(isa1);
|
||||
|
||||
ds2 = new DatagramSocket(null);
|
||||
ds2.setReuseAddress(true); // method under test
|
||||
if (!ds2.getReuseAddress()) {
|
||||
System.out.println("Cannot check: "
|
||||
+ " safety for SO_REUSEADDR option is not guaranteed");
|
||||
}
|
||||
|
||||
try {
|
||||
ds2.bind(isa2);
|
||||
} catch (SocketException e) {
|
||||
throw new RuntimeException("cannot bind second socket to " + isa2
|
||||
+ " unexpected " + e);
|
||||
}
|
||||
|
||||
if (ds1.getLocalPort() != isa.getPort() || !ds1.isBound()
|
||||
|| ds2.getLocalPort() != isa.getPort() || !ds2.isBound()) {
|
||||
System.out.println("bind() fails with: " + addr);
|
||||
System.out.println(" ds1 [" + getInfo(ds1) + "]");
|
||||
System.out.println(" ds2 [" + getInfo(ds2) + "]");
|
||||
System.out.println(" getReuseAddress(): " + ds2.getReuseAddress());
|
||||
throw new RuntimeException("bind() fails with: " + addr);
|
||||
}
|
||||
|
||||
} catch (IOException e) {
|
||||
e.printStackTrace(System.out);
|
||||
throw new RuntimeException("unexpected: " + e);
|
||||
} catch (SecurityException e) {
|
||||
System.out.println("Security restriction");
|
||||
} finally {
|
||||
if (ds1 != null) {
|
||||
ds1.close();
|
||||
}
|
||||
if (ds2 != null) {
|
||||
ds2.close();
|
||||
}
|
||||
}
|
||||
|
||||
System.out.println("OKAY");
|
||||
}
|
||||
|
||||
/**
|
||||
* Assertion testing for public int getTrafficClass() throws
|
||||
* SocketException, will return a number in range from 0 to 255 or throw
|
||||
* SocketException.
|
||||
*/
|
||||
public void DatagramSocket2028() throws Exception {
|
||||
String testCaseID = "DatagramSocket2028";
|
||||
System.out.println(" >> " + testCaseID + ": " + "public int getTrafficClass() throws SocketException");
|
||||
|
||||
DatagramSocket ds = null;
|
||||
try {
|
||||
ds = new DatagramSocket();
|
||||
int tc = ds.getTrafficClass();
|
||||
if (tc < 0 || tc > 255) {
|
||||
throw new RuntimeException("getTrafficClass() returns: " + tc);
|
||||
}
|
||||
} catch (SecurityException e) {
|
||||
System.out.println("Security restriction: " + e);
|
||||
} catch (SocketException e) {
|
||||
e.printStackTrace(System.out);
|
||||
throw new RuntimeException("Unexpected exception : " + e);
|
||||
} finally {
|
||||
if (ds != null) {
|
||||
ds.close();
|
||||
}
|
||||
}
|
||||
|
||||
System.out.println("OKAY");
|
||||
}
|
||||
|
||||
/**
|
||||
* Assertion testing for public void setTrafficClass(int tc) throws
|
||||
* SocketException, IAE will be thrown with tc less than 0 or greater than
|
||||
* 255.
|
||||
*/
|
||||
public void DatagramSocket2029() throws Exception {
|
||||
String testCaseID = "DatagramSocket2029";
|
||||
System.out.println(" >> " + testCaseID + ": " + "public void setTrafficClass(int tc) throws SocketException");
|
||||
|
||||
DatagramSocket ds = null;
|
||||
try {
|
||||
ds = new DatagramSocket();
|
||||
} catch (SecurityException e) {
|
||||
System.out.println("Security restriction: " + e);
|
||||
} catch (IOException e) {
|
||||
e.printStackTrace(System.out);
|
||||
throw new RuntimeException("cannot create socket: " + e);
|
||||
}
|
||||
|
||||
int[] values = {
|
||||
Integer.MIN_VALUE, Integer.MIN_VALUE + 1, -1000, -2, -1,
|
||||
256, 257, 1000, 50000, Integer.MAX_VALUE - 1, Integer.MAX_VALUE
|
||||
};
|
||||
|
||||
for (int i = 0; i < values.length; i++) {
|
||||
try {
|
||||
ds.setTrafficClass(values[i]);
|
||||
System.out.println("No exception with: " + values[i]);
|
||||
System.out.println("getTrafficClass() returns: " + ds.getTrafficClass());
|
||||
ds.close();
|
||||
throw new RuntimeException("setTrafficClass() fails with : " + values[i]);
|
||||
} catch (SocketException e) {
|
||||
ds.close();
|
||||
e.printStackTrace(System.out);
|
||||
throw new RuntimeException("setTrafficClass() throws : " + e);
|
||||
} catch (IllegalArgumentException e) {
|
||||
}
|
||||
}
|
||||
|
||||
System.out.println("OKAY");
|
||||
}
|
||||
|
||||
/**
|
||||
* Assertion testing for public void setTrafficClass(int tc) throws
|
||||
* SocketException, only SocketException may be thrown with tc in range from
|
||||
* 0 to 255.
|
||||
*/
|
||||
public void DatagramSocket2030() throws Exception {
|
||||
String testCaseID = "DatagramSocket2030";
|
||||
System.out.println(" >> " + testCaseID + ": " + "public void setTrafficClass(int tc) throws SocketException");
|
||||
|
||||
DatagramSocket ds = null;
|
||||
try {
|
||||
ds = new DatagramSocket();
|
||||
} catch (SecurityException e) {
|
||||
System.out.println("Security restriction: " + e);
|
||||
} catch (IOException e) {
|
||||
e.printStackTrace(System.out);
|
||||
throw new RuntimeException("cannot create socket: " + e);
|
||||
}
|
||||
|
||||
for (int i = 0; i <= 255; i++) {
|
||||
try {
|
||||
ds.setTrafficClass(i);
|
||||
} catch (SocketException e) {
|
||||
}
|
||||
}
|
||||
|
||||
System.out.println("OKAY");
|
||||
}
|
||||
|
||||
/**
|
||||
* Equivalence class partitioning with input values orientation for public
|
||||
* void setBroadcast(boolean on) throws SocketException,
|
||||
* <br><b>on</b>: false.
|
||||
* <br><b>Expected results</b>: getBroadcast() will return false
|
||||
*/
|
||||
public void DatagramSocket0034() throws Exception {
|
||||
String testCaseID = "DatagramSocket0034";
|
||||
System.out.println(" >> " + testCaseID + ": " + "public void setBroadcast(boolean on) throws SocketException");
|
||||
|
||||
DatagramSocket ds = null;
|
||||
try {
|
||||
ds = new DatagramSocket();
|
||||
ds.setBroadcast(false);
|
||||
if (ds.getBroadcast() == true) {
|
||||
throw new RuntimeException("SO_BROADCAST is not set to false");
|
||||
}
|
||||
} catch (IOException e) {
|
||||
e.printStackTrace(System.out);
|
||||
throw new RuntimeException("unexpected: " + e);
|
||||
} catch (SecurityException e) {
|
||||
System.out.println("Security restriction");
|
||||
} finally {
|
||||
if (ds != null) {
|
||||
ds.close();
|
||||
}
|
||||
}
|
||||
|
||||
System.out.println("OKAY");
|
||||
}
|
||||
|
||||
/**
|
||||
* Equivalence class partitioning with input values orientation for public
|
||||
* void setBroadcast(boolean on) throws SocketException,
|
||||
* <br><b>on</b>: true.
|
||||
* <br><b>Expected results</b>: getBroadcast() will return true
|
||||
*/
|
||||
public void DatagramSocket0035() throws Exception {
|
||||
String testCaseID = "DatagramSocket0035";
|
||||
System.out.println(" >> " + testCaseID + ": " + "public void setBroadcast(boolean on) throws SocketException");
|
||||
|
||||
DatagramSocket ds = null;
|
||||
try {
|
||||
ds = new DatagramSocket();
|
||||
ds.setBroadcast(true);
|
||||
if (ds.getBroadcast() == false) {
|
||||
throw new RuntimeException("SO_BROADCAST is not set to true");
|
||||
}
|
||||
} catch (IOException e) {
|
||||
e.printStackTrace(System.out);
|
||||
throw new RuntimeException("unexpected: " + e);
|
||||
} catch (SecurityException e) {
|
||||
System.out.println("Security restriction");
|
||||
} finally {
|
||||
if (ds != null) {
|
||||
ds.close();
|
||||
}
|
||||
}
|
||||
|
||||
System.out.println("OKAY");
|
||||
}
|
||||
}
|
||||
Loading…
x
Reference in New Issue
Block a user