1berry/openjdk
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

8277412: Use String.isBlank to simplify code in sun.net.www.protocol.mailto.Handler

Browse Source 
Reviewed-by: dfuchs
This commit is contained in:
Andrey Turbanov 2022-01-29 11:36:11 +00:00
parent d366d15d67
commit 268880b471
1 changed files with 5 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
src/java.base/share/classes/sun/net/www/protocol/mailto/Handler.java
View File

@ -1,5 +1,5 @@
/* /*
* Copyright (c) 1995, 2011, Oracle and/or its affiliates. All rights reserved. * Copyright (c) 1995, 2021, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
* *
* This code is free software; you can redistribute it and/or modify it * This code is free software; you can redistribute it and/or modify it
@ -32,10 +32,6 @@ package sun.net.www.protocol.mailto;
import java.net.URL; import java.net.URL;
import java.net.URLConnection; import java.net.URLConnection;
import java.net.URLStreamHandler; import java.net.URLStreamHandler;
import java.io.*;
import sun.net.www.*;
//import sun.net.www.protocol.news.ArticlePoster;
import sun.net.smtp.SmtpClient;
/** open an nntp input stream given a URL */ /** open an nntp input stream given a URL */
public class Handler extends URLStreamHandler { public class Handler extends URLStreamHandler {
@ -126,33 +122,16 @@ public class Handler extends URLStreamHandler {
/* /*
* Let's just make sure we DO have an Email address in the URL. * Let's just make sure we DO have an Email address in the URL.
*/ */
boolean nogood = false; if (file.isBlank())
if (file == null || file.isEmpty())
nogood = true;
else {
boolean allwhites = true;
for (int i = 0; i < file.length(); i++)
if (!Character.isWhitespace(file.charAt(i)))
allwhites = false;
if (allwhites)
nogood = true;
}
if (nogood)
throw new RuntimeException("No email address"); throw new RuntimeException("No email address");
setURLHandler(u, protocol, host, port, file, null); setURLHandler(u, protocol, host, port, file);
} }
/** /**
* This method is used to suppress the deprecated warning * This method is used to suppress the deprecated warning
*
* @param u the URL to receive the result of parsing the spec
* @param spec the URL string to parse
* @param start the character position to start parsing at. This is
* just past the ':'.
* @param limit the character position to stop parsing at.
*/ */
@SuppressWarnings("deprecation") @SuppressWarnings("deprecation")
private void setURLHandler(URL u, String protocol, String host, int port, String file, String ref) { private void setURLHandler(URL u, String protocol, String host, int port, String file) {
setURL(u,protocol,host,port,file,null); setURL(u, protocol, host, port, file, null);
} }
} }