1berry/openjdk
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

6790677: java.net.HttpCookie.parse(String) should ignore unrecognized attributes, RFC2965

Browse Source 
Changed code not to throw an exception on unknown attributes

Reviewed-by: chegar
This commit is contained in:
Jean-Christophe Collet 2009-01-27 11:36:28 +01:00
parent 61f89b0025
commit 285d905e09
2 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
jdk/src/share/classes/java/net/HttpCookie.java
View File

@ -1058,8 +1058,7 @@ public final class HttpCookie implements Cloneable {
if (assignor != null) { if (assignor != null) {
assignor.assign(cookie, attrName, attrValue); assignor.assign(cookie, attrName, attrValue);
} else { } else {
// must be an error // Ignore the attribute as per RFC 2965
throw new IllegalArgumentException("Illegal cookie attribute");
} }
} }

9
jdk/test/java/net/CookieHandler/TestHttpCookie.java
View File

@ -24,7 +24,7 @@
/** /**
* @test * @test
* @summary Unit test for java.net.HttpCookie * @summary Unit test for java.net.HttpCookie
* @bug 6244040 6277796 6277801 6277808 6294071 6692802 * @bug 6244040 6277796 6277801 6277808 6294071 6692802 6790677
* @author Edward Wang * @author Edward Wang
*/ */
@ -278,10 +278,6 @@ public class TestHttpCookie {
.c("this is a coyote").cu("http://www.coyote.org").dsc(true) .c("this is a coyote").cu("http://www.coyote.org").dsc(true)
.d(".coyote.org").a(3600).port("80"); .d(".coyote.org").a(3600).port("80");
// illegal characters in set-cookie header
test("Set-Cookie2:Customer=;Version#=\"1\";Path=&\"/acme\"")
.nil();
// empty set-cookie string // empty set-cookie string
test("").nil(); test("").nil();
@ -311,6 +307,9 @@ public class TestHttpCookie {
test("Set-Cookie2:C1=\"V1\";Domain=\".sun1.com\";path=\"/www1\";Max-Age=\"100\",C2=\"V2\";Domain=\".sun2.com\";path=\"/www2\";Max-Age=\"200\"") test("Set-Cookie2:C1=\"V1\";Domain=\".sun1.com\";path=\"/www1\";Max-Age=\"100\",C2=\"V2\";Domain=\".sun2.com\";path=\"/www2\";Max-Age=\"200\"")
.n(0, "C1").v(0, "V1").p(0, "/www1").a(0, 100).d(0, ".sun1.com") .n(0, "C1").v(0, "V1").p(0, "/www1").a(0, 100).d(0, ".sun1.com")
.n(1, "C2").v(1, "V2").p(1, "/www2").a(1, 200).d(1, ".sun2.com"); .n(1, "C2").v(1, "V2").p(1, "/www2").a(1, 200).d(1, ".sun2.com");
// Bug 6790677: Should ignore bogus attributes
test("Set-Cookie2:C1=\"V1\";foobar").n(0, "C1").v(0, "V1");
} }
static void netscape() { static void netscape() {